linux-iio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Crt Mori <cmo@melexis.com>
Cc: Jonathan Cameron <jic23@kernel.org>,
	linux-iio <linux-iio@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v6 3/5] iio:temperature:mlx90632: Convert polling while loop to regmap
Date: Wed, 19 Aug 2020 11:08:54 +0300	[thread overview]
Message-ID: <CAHp75Vcv=GtefqJjvKmCZsOuLDgfbGnfGR-+RwWZRS+tMmFZ-Q@mail.gmail.com> (raw)
In-Reply-To: <20200818213737.140613-4-cmo@melexis.com>

On Wed, Aug 19, 2020 at 12:38 AM Crt Mori <cmo@melexis.com> wrote:
>
> Reduce number of lines and improve readability to convert polling while
> loops to regmap_read_poll_timeout.

Usually we refer to a function as regmap_read_poll_timeout(). Note
parentheses. I think Jonathan can fix when applying, no need to
resend.

Precisely what I meant, thanks!
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>

> Signed-off-by: Crt Mori <cmo@melexis.com>
> ---
>  drivers/iio/temperature/mlx90632.c | 16 +++++-----------
>  1 file changed, 5 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/iio/temperature/mlx90632.c b/drivers/iio/temperature/mlx90632.c
> index ce75f5a3486b..d782634c107f 100644
> --- a/drivers/iio/temperature/mlx90632.c
> +++ b/drivers/iio/temperature/mlx90632.c
> @@ -180,25 +180,19 @@ static s32 mlx90632_pwr_continuous(struct regmap *regmap)
>   */
>  static int mlx90632_perform_measurement(struct mlx90632_data *data)
>  {
> -       int ret, tries = 100;
>         unsigned int reg_status;
> +       int ret;
>
>         ret = regmap_update_bits(data->regmap, MLX90632_REG_STATUS,
>                                  MLX90632_STAT_DATA_RDY, 0);
>         if (ret < 0)
>                 return ret;
>
> -       while (tries-- > 0) {
> -               ret = regmap_read(data->regmap, MLX90632_REG_STATUS,
> -                                 &reg_status);
> -               if (ret < 0)
> -                       return ret;
> -               if (reg_status & MLX90632_STAT_DATA_RDY)
> -                       break;
> -               usleep_range(10000, 11000);
> -       }
> +       ret = regmap_read_poll_timeout(data->regmap, MLX90632_REG_STATUS, reg_status,
> +                                      !(reg_status & MLX90632_STAT_DATA_RDY), 10000,
> +                                      100 * 10000);
>
> -       if (tries < 0) {
> +       if (ret < 0) {
>                 dev_err(&data->client->dev, "data not ready");
>                 return -ETIMEDOUT;
>         }
> --
> 2.25.1
>


--
With Best Regards,
Andy Shevchenko

  reply	other threads:[~2020-08-19  8:09 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-18 21:37 [PATCH v6 0/5] iio: temperature: mlx90632: Add extended calibration calculations Crt Mori
2020-08-18 21:37 ` [PATCH v6 1/5] iio:temperature:mlx90632: Reduce number of equal calulcations Crt Mori
2020-08-18 21:37 ` [PATCH v6 2/5] iio:temperature:mlx90632: Add kerneldoc to the internal struct Crt Mori
2020-08-18 21:37 ` [PATCH v6 3/5] iio:temperature:mlx90632: Convert polling while loop to regmap Crt Mori
2020-08-19  8:08   ` Andy Shevchenko [this message]
2020-08-18 21:37 ` [PATCH v6 4/5] iio:temperature:mlx90632: Adding extended calibration option Crt Mori
2020-08-18 21:37 ` [PATCH v6 5/5] iio:temperature:mlx90632: Some stylefixing leftovers Crt Mori
2020-08-19  8:10   ` Andy Shevchenko
2020-08-29 17:28 ` [PATCH v6 0/5] iio: temperature: mlx90632: Add extended calibration calculations Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAHp75Vcv=GtefqJjvKmCZsOuLDgfbGnfGR-+RwWZRS+tMmFZ-Q@mail.gmail.com' \
    --to=andy.shevchenko@gmail.com \
    --cc=cmo@melexis.com \
    --cc=jic23@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: [PATCH v6 3/5] iio:temperature:mlx90632: Convert polling while loop to regmap' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).