From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E373AC43331 for ; Sat, 28 Mar 2020 10:52:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BAF4920717 for ; Sat, 28 Mar 2020 10:52:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Aq4+5gmj" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726283AbgC1KwY (ORCPT ); Sat, 28 Mar 2020 06:52:24 -0400 Received: from mail-pl1-f195.google.com ([209.85.214.195]:41513 "EHLO mail-pl1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726156AbgC1KwY (ORCPT ); Sat, 28 Mar 2020 06:52:24 -0400 Received: by mail-pl1-f195.google.com with SMTP id d24so678489pll.8; Sat, 28 Mar 2020 03:52:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=YcKn/H8EDvahzikQuDQ0C/2jv4PkNkkgCQKKj34zNzU=; b=Aq4+5gmji624zQXh/p3KCAR+m5x43hob634OL/vHwySR8euy8H9Z1vnBgp970IK8eD x24zEis9Y7h6I10OLNJ1oLzuoWRlnMBrL59ojvdpXzWNVKnpAfjCE/quPUckA0C84GB6 ojq87jZ+RoyuIgX3Ch2qpzoMhIFzyqBzoT0/xAxdTnbi6uRbG8HtDmi46tAMTSdtL/NB yUpvK1ndDbPWHjwv5heS52sIEDeI0RsheV2+o2WWh8GzMwD35mlSn3qnsbpVBnUb0/NK OhiPGGPWMGjxHfLiw6D7fqYAZ+E/MZC0FemWrtD2K+5H4+jrFAqdWjApUEyvROiaysas hNAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=YcKn/H8EDvahzikQuDQ0C/2jv4PkNkkgCQKKj34zNzU=; b=OaGzN7ONZYLBdjZtGmpZaKhSP0+wC5Rqzao6bPf5jK0gs2zGqvJBq+gX7hMolUaBWS LRZu4OFJtGDs3TEA2/H4iYdtv4Py1pLn/d9kyytLrFaQnWaoFE4MGqIqKN8fYiOUnhPO y5hjjsMg9Q9h2lZINaxn3mMFmnk9j+FHR2MnBthULMnkIm6iu4piLXPjZWUgjdF/z3cB 8ARFh/5u+xWjbqEg1vNJYLqLm7wTEBEqu1c+H9Ui5vGH/cUtuHW9DD9OzVX0E4C/Afpk qZKuXDC4eRD99dIidWrBZIGAqgWfWruOXwHCgnO6UNMlUwfOXCgkxKu53kJ9yPKH2K0o ZKaw== X-Gm-Message-State: ANhLgQ2+Gkiz3BjWhYWrspC54XMPW2jt2YAqnRQ9i3X6VdkbokzJAuZg JYUT8tlcQ8qPVm4GpmWmBJ3EZp/bdG0P9OFBEIA= X-Google-Smtp-Source: ADFU+vtWEO67dR4rn0uYyS0uWFD2xD8gBrqyU1X3pu1a9Fb0fdsPskth2ohRugs+hg9Jmm/g4k5LlQR5WBgqNXRyHj0= X-Received: by 2002:a17:90a:8403:: with SMTP id j3mr4422773pjn.8.1585392742658; Sat, 28 Mar 2020 03:52:22 -0700 (PDT) MIME-Version: 1.0 References: <20200328001154.17313-1-sravanhome@gmail.com> <20200328001154.17313-4-sravanhome@gmail.com> In-Reply-To: <20200328001154.17313-4-sravanhome@gmail.com> From: Andy Shevchenko Date: Sat, 28 Mar 2020 12:52:11 +0200 Message-ID: Subject: Re: [PATCH v5 3/5] iio: adc: mp2629: Add support for mp2629 ADC driver To: Saravanan Sekar Cc: Lee Jones , Rob Herring , Jonathan Cameron , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald , Sebastian Reichel , devicetree , Linux Kernel Mailing List , linux-iio , Linux PM Content-Type: text/plain; charset="UTF-8" Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Sat, Mar 28, 2020 at 2:12 AM Saravanan Sekar wrote: > > Add support for 8-bit resolution ADC readings for input power > supply and battery charging measurement. Provides voltage, current > readings to mp2629 power supply driver. ... > + ret = regmap_read(info->regmap, chan->address, &rval); > + if (ret < 0) ' < 0' is not needed for regmap call. .. > + case MP2629_INPUT_CURRENT: > + *val = 133; > + *val2 = 10; > + return IIO_VAL_FRACTIONAL; > + > + default: > + return -EINVAL; > + } > + > + default: > + return -EINVAL; > + } > + > + return 0; Do you really need this? Looks to me as dead code. ... > + indio_dev->name = dev_name(dev); Shouldn't be this a part number? I heard something, so, I might be mistaken, but I hope maintainers will help here. -- With Best Regards, Andy Shevchenko