From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3674AC43331 for ; Sat, 28 Mar 2020 18:44:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0ECAC206F6 for ; Sat, 28 Mar 2020 18:44:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ouDCjhKF" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726937AbgC1So2 (ORCPT ); Sat, 28 Mar 2020 14:44:28 -0400 Received: from mail-pg1-f195.google.com ([209.85.215.195]:40248 "EHLO mail-pg1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725882AbgC1So2 (ORCPT ); Sat, 28 Mar 2020 14:44:28 -0400 Received: by mail-pg1-f195.google.com with SMTP id t24so6431050pgj.7; Sat, 28 Mar 2020 11:44:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=AEgBW9QQu99a2sai4d1Uz2IOeiRHB8mBntj4/oX3if8=; b=ouDCjhKFXNz0qHg97LSTL9LtxoMEHHt5XmMHY0O3JWTXTX6KVUoBbbKGEaRoe4suqH Bgodh/bhOWuh+Uw5ZYeUQDC/rlML9443WQkuM+KCmxxhjELg+7MhD0Lq4BubKI4pnMJo ZfzaEEDCyNKntZ4F6dUb4Vs7Vd7wELm98oGUZpswTvhm/Q/HA/SIavwXKsKEUe8xWMC5 veV78phgOYhrh7JtLFf0oynNemIhylY0qL9bQa33NeSOWpUu5C2XlY98iV+luNSHwaoY omgLIxik4AauciZPkWxYN3o5K2+dsH2puaV0rjGc9TgHCkoqYwbi0M9EoN+qXpWdHwjE 0FQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=AEgBW9QQu99a2sai4d1Uz2IOeiRHB8mBntj4/oX3if8=; b=dlULcW7kqArkv4j7DbmJHfUyFt4GbrAIHzZoQXfR5O0KPH5B5AnwTAcncNaFqFEVpX E06XRhfASd74n30kpgSPaPpHVmBaBLt+px8+yi8pR7hgadhBmUQCTHhKh1tNu1WMoqhI lDCteVz/OpqrfBGWA/RbIUR3ff2nD+Sx9UV0M/JPG8cQhJ+SRpI1r4rrer1+FSjPyjmt VeEqSsRWljlBN2KVDVSN3aycD6igJwP4ma3Mvrl0g2YhdQdJPnONRNf7PjBI/HyGtcMX EQD63CYD89GYsxCokQz3zNESrVGi8rfUyaKRbrjrep+wPSwdFUH98NHgOSjYWMJnmHSV MNAw== X-Gm-Message-State: ANhLgQ0zqf6VJTpoj7dsR+EApo/YZ7PAutSsnW6U+DNXAiGhilaWc+z2 uSUMvyc/sLqWtu8CQdiYr6SPqoo11DKGOgLdJ4w= X-Google-Smtp-Source: ADFU+vuLh8bWhofnY0uetIzib0+lVHRoBH+mcX9y4a5vGukmUlw/9WY99xY/uiIsg6cXSU/IMm9zO7gbPWfER27vvoc= X-Received: by 2002:a05:6a00:2b4:: with SMTP id q20mr5459087pfs.36.1585421066788; Sat, 28 Mar 2020 11:44:26 -0700 (PDT) MIME-Version: 1.0 References: <20200328001154.17313-1-sravanhome@gmail.com> <20200328001154.17313-5-sravanhome@gmail.com> <36892440-99b2-10e8-1d7c-dd8c97e03a39@gmail.com> In-Reply-To: <36892440-99b2-10e8-1d7c-dd8c97e03a39@gmail.com> From: Andy Shevchenko Date: Sat, 28 Mar 2020 20:44:14 +0200 Message-ID: Subject: Re: [PATCH v5 4/5] power: supply: Add support for mps mp2629 battery charger To: saravanan sekar Cc: Lee Jones , Rob Herring , Jonathan Cameron , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald , Sebastian Reichel , devicetree , Linux Kernel Mailing List , linux-iio , Linux PM Content-Type: text/plain; charset="UTF-8" Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Sat, Mar 28, 2020 at 1:29 PM saravanan sekar wrote: > On 28/03/20 12:02 pm, Andy Shevchenko wrote: > > On Sat, Mar 28, 2020 at 2:12 AM Saravanan Sekar wrote: ... > >> + val->intval = (rval * props[fld].step) + props[fld].min; > > Too many parentheses. > > > > ... > > > >> + return ((psp == POWER_SUPPLY_PROP_PRECHARGE_CURRENT) || > >> + (psp == POWER_SUPPLY_PROP_CHARGE_TERM_CURRENT) || > >> + (psp == POWER_SUPPLY_PROP_CONSTANT_CHARGE_CURRENT) || > >> + (psp == POWER_SUPPLY_PROP_CONSTANT_CHARGE_VOLTAGE)); > > Ditto. > I think I misunderstood you previous review comment "Redundant > parentheses", no sure what is the expectation (At least) surrounding pair is not needed, return (a == b) || (c == d); > > ... > > > >> + return ((psp == POWER_SUPPLY_PROP_INPUT_VOLTAGE_LIMIT) || > >> + (psp == POWER_SUPPLY_PROP_INPUT_CURRENT_LIMIT)); > > Ditto. ... > >> + struct power_supply_config psy_cfg = {NULL}; > > { 0 } > > > NULL to make compiler happy. Hmm... Can you share warning / error compiler issued in 0 case? -- With Best Regards, Andy Shevchenko