From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 101A0CCA47E for ; Sun, 19 Jun 2022 10:52:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235158AbiFSKwF (ORCPT ); Sun, 19 Jun 2022 06:52:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60296 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232316AbiFSKwE (ORCPT ); Sun, 19 Jun 2022 06:52:04 -0400 Received: from mail-ej1-x630.google.com (mail-ej1-x630.google.com [IPv6:2a00:1450:4864:20::630]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C805710575; Sun, 19 Jun 2022 03:52:03 -0700 (PDT) Received: by mail-ej1-x630.google.com with SMTP id o7so16153686eja.1; Sun, 19 Jun 2022 03:52:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ebd6qW1bmr9UXQKliJw9JMCXnaRgcpZYnpj8vzueGKs=; b=XDbkHZRn044zzJnQOw/jpQIuTiBqWAsb7n6Bk0FYupham0OnCZ89dhObPmdRWwEWxd FtAmz4TYfqDr36tP/dE2fNcDBqAEij2JVPDLxG8dVkm7gAsqTbM/xzmifxG1KTt8sDuy OINMBX4xqBZPpjnjeTK+iVu/Xg9Bn7UvkUhDdWPDgbh5k/q4EXDTDbM8/l4RWc/ULx/1 bqvlfUtAZ1nih/ZmFgjsKe9NjlheTKtnVymRFlejuivzvOBRBhwVzN0yt3kikL8SYaIh Go3c0K5KvKGEz6Bb7xkOqqhdhYBjDxkJHXXNsst8qA5+yt1lImgBMhOnGH05v3H/LpOM 9eAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ebd6qW1bmr9UXQKliJw9JMCXnaRgcpZYnpj8vzueGKs=; b=wBO9+D9Nd2eYreT/wmzaArnIRWBUY2MicSQy2DCyqY4eQcO3CikH69zmnQ5lnvkvub W+XuS2bWpaYF4uczF7S9/6r0EqNYW4sxJe2Sbv8mCAEkAOQylA0y4ZnNopFFY8B/kXfN fzTCG8WZ8dU1BpjJYohPsNJJy+Vl/dejtwg+8ZnEfOxz7guEz+PSMBjVTw/9wgvT/Cn3 oUdJOxHNDU/GmUbVQ8Uio3Wd7jpzzumVZ/OKFD0wcJq8xUiMQ4oPXf5vTqz98yt1g/ji itlpYaSSHcS5CmU+YhV4z2tKvOMFQHcQPmAitaz026X0kS5BqVxDVNSUQRpL+QtaYBch uxgQ== X-Gm-Message-State: AJIora8RvL+87faGkr3hgCd7DCZt2hm8EgAR3GkAvC4ILnkIuhgdaA9u Cxqw30wihxo8Vuf5SbP4CRTSBo4jS6BiKSDDs0s= X-Google-Smtp-Source: AGRyM1uNsTXG8QbLjgaH2Otr2hEazBEbSS6akba0cYFAJ6VMblAbmj1H7bX0ZGOcPh7DPTHCaO7E0ia/Kz/pISCfI0U= X-Received: by 2002:a17:906:434f:b0:711:eb76:c320 with SMTP id z15-20020a170906434f00b00711eb76c320mr16565501ejm.636.1655635922377; Sun, 19 Jun 2022 03:52:02 -0700 (PDT) MIME-Version: 1.0 References: <20220618214009.2178567-1-aidanmacdonald.0x0@gmail.com> <20220618214009.2178567-11-aidanmacdonald.0x0@gmail.com> In-Reply-To: <20220618214009.2178567-11-aidanmacdonald.0x0@gmail.com> From: Andy Shevchenko Date: Sun, 19 Jun 2022 12:51:26 +0200 Message-ID: Subject: Re: [PATCH v3 10/16] iio: adc: axp20x_adc: Minor code cleanups To: Aidan MacDonald Cc: Linus Walleij , Bartosz Golaszewski , Rob Herring , Krzysztof Kozlowski , Chen-Yu Tsai , Jonathan Cameron , Lee Jones , Sebastian Reichel , Mark Brown , Greg Kroah-Hartman , Liam Girdwood , Lars-Peter Clausen , "Rafael J. Wysocki" , quic_gurus@quicinc.com, Sebastian Reichel , Michael Walle , "open list:GPIO SUBSYSTEM" , devicetree , Linux Kernel Mailing List , linux-iio , Linux PM Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Sat, Jun 18, 2022 at 11:40 PM Aidan MacDonald wrote: > > The code may be clearer if parameters are not re-purposed to hold > temporary results like register values, so introduce local variables > as necessary to avoid that. Also, use the common FIELD_PREP macro FIELD_PREP() > instead of a hand-rolled version. ... > #include > #include > #include > +#include Keep it sorted? ... > - val = val ? 1 : 0; > + regval = val ? 1 : 0; > I think you may drop these two lines (including blank line) and... > switch (chan->channel) { > case AXP20X_GPIO0_V: > - reg = AXP20X_GPIO10_IN_RANGE_GPIO0; > - regval = AXP20X_GPIO10_IN_RANGE_GPIO0_VAL(val); > + regmask = AXP20X_GPIO10_IN_RANGE_GPIO0; > + regval = FIELD_PREP(AXP20X_GPIO10_IN_RANGE_GPIO0, regval); ...use !!val as an argument here... > break; > > case AXP20X_GPIO1_V: > - reg = AXP20X_GPIO10_IN_RANGE_GPIO1; > - regval = AXP20X_GPIO10_IN_RANGE_GPIO1_VAL(val); > + regmask = AXP20X_GPIO10_IN_RANGE_GPIO1; > + regval = FIELD_PREP(AXP20X_GPIO10_IN_RANGE_GPIO1, regval); ...and here. > break; > > default: > return -EINVAL; > } -- With Best Regards, Andy Shevchenko