From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DABBFC433EF for ; Sun, 19 Jun 2022 10:44:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233329AbiFSKoy (ORCPT ); Sun, 19 Jun 2022 06:44:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55848 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229887AbiFSKoy (ORCPT ); Sun, 19 Jun 2022 06:44:54 -0400 Received: from mail-ed1-x530.google.com (mail-ed1-x530.google.com [IPv6:2a00:1450:4864:20::530]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 37F112614; Sun, 19 Jun 2022 03:44:53 -0700 (PDT) Received: by mail-ed1-x530.google.com with SMTP id ej4so7505323edb.7; Sun, 19 Jun 2022 03:44:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=yxOIwZjmxFnjMXJ6Xp1+MvDIzBj+ym+fo6gciVI2pfs=; b=erxRoeDeeSAHC7idu736MyEPQuGc5jmV4U1+5N3dAyB/Dl1ew9cIgM9IKFGMi/79J8 zIdqn6oRCY0NvJH7Cm/T7TVHTiyZIeq6jMZ7HHmXrbiU/bD244DgcqOFQ7PdCsMcKcp9 JrI6J6+jH2IiwMDWxNKTZGlWvdIvQOjWs1A7arLZYc66nwF093xRdkT9DuiOnnDqBvah +1hHLH6RSwEdUeOBI5i0cMSUnm5DpZyfcgsCoyAd5b68DY/tO7bIFLoD9n4FLY4Y6Yfv esN7+5TGs01Pcnc27tdEiE9xSxwTG4BIQy7hw2dKznlvL4r3NZ92yvJdyhKh4kaMdk+j 8nQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=yxOIwZjmxFnjMXJ6Xp1+MvDIzBj+ym+fo6gciVI2pfs=; b=ppogYeHJxlaer9oGeCo7jt1zEpQOIe3+RmUgbyOPQpgxpXLYzrIGa1LXfVFtlTzus0 N9vvXb0cmnAw4RQSgGF+CwbxHNG2s6COfo3Tmcg5XT4n+nTihwFghRxUAsKFpOhGGTRq mJinwO5eY7+HPHic9wljfJjDbEubgzWTxViAB6BLCbnsje4qxds/yBJPmsK4/OvVTsR8 Lh6zCcwaqWUnOZLdf9mnKdlubsHxmY3VU6w8G0Bkg/PI9vl8LfrdlPwK+Wca5fGwjTiL qs5l7oUQtqfHvMk+87Y98oQQbMmtYwpXdoThqAxRlI0yzN0aAUfEBrs5Op6zMbN4sSKj ha5w== X-Gm-Message-State: AJIora+jQPiJwajqhpu/44sIDlfpGXMhl5DHFwoPFMua/Ql0OIgPPA7S G/dFtMmB8+zp9bdi5F4t7S8jTqNLuTiw1WGbT7M= X-Google-Smtp-Source: AGRyM1uwpM39Y5hJukPhhAsF+Sd/ykgw+tW++s88t51mRboT6d8T2fs8H7237eve9IHtlfZjLFeZ60kSXT46gM9QNmY= X-Received: by 2002:a05:6402:249e:b0:42d:bb88:865b with SMTP id q30-20020a056402249e00b0042dbb88865bmr22547322eda.141.1655635491659; Sun, 19 Jun 2022 03:44:51 -0700 (PDT) MIME-Version: 1.0 References: <20220618214009.2178567-1-aidanmacdonald.0x0@gmail.com> <20220618214009.2178567-9-aidanmacdonald.0x0@gmail.com> In-Reply-To: <20220618214009.2178567-9-aidanmacdonald.0x0@gmail.com> From: Andy Shevchenko Date: Sun, 19 Jun 2022 12:44:14 +0200 Message-ID: Subject: Re: [PATCH v3 08/16] mfd: axp20x: Add support for AXP192 To: Aidan MacDonald Cc: Linus Walleij , Bartosz Golaszewski , Rob Herring , Krzysztof Kozlowski , Chen-Yu Tsai , Jonathan Cameron , Lee Jones , Sebastian Reichel , Mark Brown , Greg Kroah-Hartman , Liam Girdwood , Lars-Peter Clausen , "Rafael J. Wysocki" , quic_gurus@quicinc.com, Sebastian Reichel , Michael Walle , "open list:GPIO SUBSYSTEM" , devicetree , Linux Kernel Mailing List , linux-iio , Linux PM Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Sat, Jun 18, 2022 at 11:40 PM Aidan MacDonald wrote: > > The AXP192 PMIC is similar to the AXP202/AXP209, but with different > regulators, additional GPIOs, and a different IRQ register layout. ... > +static int axp192_get_irq_reg(unsigned int base_reg, int i) > +{ > + /* linear mapping for IRQ1 to IRQ4 */ > + if (i < 4) > + return base_reg + i; > + > + /* handle IRQ5 separately */ > + if (base_reg == AXP192_IRQ1_EN) > + return AXP192_IRQ5_EN; > + else Redundant 'else'. > + return AXP192_IRQ5_STATE; > +} ... > +enum { > + AXP192_DCDC1 = 0, > + AXP192_DCDC2, > + AXP192_DCDC3, > + AXP192_LDO1, > + AXP192_LDO2, > + AXP192_LDO3, > + AXP192_LDO_IO0, > + AXP192_REG_ID_MAX, Comma is not needed for a terminator. > +}; -- With Best Regards, Andy Shevchenko