From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 754A6C54EE9 for ; Tue, 20 Sep 2022 13:14:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230386AbiITNN7 (ORCPT ); Tue, 20 Sep 2022 09:13:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48046 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229655AbiITNN6 (ORCPT ); Tue, 20 Sep 2022 09:13:58 -0400 Received: from mail-qv1-xf31.google.com (mail-qv1-xf31.google.com [IPv6:2607:f8b0:4864:20::f31]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 62618474EB for ; Tue, 20 Sep 2022 06:13:57 -0700 (PDT) Received: by mail-qv1-xf31.google.com with SMTP id g4so1962211qvo.3 for ; Tue, 20 Sep 2022 06:13:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date; bh=BHlaie6hylWMV8coBd5FIDUSQ9oG1Uphbsv015aZs/4=; b=dhNIARiESV6MyND7GWZFXhtWA4jq4Qay7x+tcorjQneVflX9NA4nkhEmxOaz9iIh4u 6p9TBGmTfswxJiGL/pS/TfyVmKJmkP73qD4dVvYQjP0uvFObt0DclYjTKa3k1qe+UN0i 6XiWp3jw/JUpctW6aAR/dyvS9mX2D5ssCKmbPbsDo//nRDNPTmwBZnguh2sveAHw2xDI ImsdLYJ8SPXNeRD9CZc/DMZCFu6j2D2oo9N5d/wXZgHEXAnVCbEGOOnGRrO8J0b6FcQ0 up7t7CVx4H/+7yxQknO6m/306g+wrgO/GLKMMykOWJzpINEi/VMU6VvwKhKh+SjX+/41 yLYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date; bh=BHlaie6hylWMV8coBd5FIDUSQ9oG1Uphbsv015aZs/4=; b=zu/XCbn6fSbcPnhIVHd6bp2JLh5oDNC2wYH2xD1Wa2SCxSlr1krA/kK+qvjv6jtW6C eCjzEdUqsEEZnXmyN80wXPBPDK1s5dUGtIumOyx6BF2ronC0Iv1Al5pr3RMj4M5oUTaz l0LZ22xAL3cBzSSXztjnA+Nmgq7leZk5JoeRdOpBUByS6AVNrw+1tvFuo005MycTMj0Y dPrkaAXvLQ+R83q24DxO5A40WEKqbOs1edGlO+oUnpoE7yxDJUFfF959ymzExxecNEau rjRX8a1JLAccACJk6D0nHSY9HSRjMB5uHVrKoe1YA6y6iecRXjhqoUHw0MQ8vkFPQ9WH SjuQ== X-Gm-Message-State: ACrzQf3zflVIiddPSL2rxMqNw1wkXaoKC81IhX6Zs3uvx8lQ3jTVTsWy d2qjtsrvJ8LjV+1qHQdu84GwLsWAsCfo8xpA/AA= X-Google-Smtp-Source: AMsMyM56JXV/U4hiso6NAbUubkut0P6ri2M6qFySsSuc+BbVmLxrkRxw+GByxxcwzVFfwDyrKqMuP3Cm+4aDJqRNXkU= X-Received: by 2002:a05:6214:d6f:b0:4ac:7748:2e5c with SMTP id 15-20020a0562140d6f00b004ac77482e5cmr18616202qvs.97.1663679636472; Tue, 20 Sep 2022 06:13:56 -0700 (PDT) MIME-Version: 1.0 References: <20220920112821.975359-1-nuno.sa@analog.com> <20220920112821.975359-4-nuno.sa@analog.com> In-Reply-To: <20220920112821.975359-4-nuno.sa@analog.com> From: Andy Shevchenko Date: Tue, 20 Sep 2022 16:13:20 +0300 Message-ID: Subject: Re: [PATCH 03/15] iio: adc: axp288_adc: do not use internal iio_dev lock To: =?UTF-8?B?TnVubyBTw6E=?= Cc: linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-imx@nxp.com, linux-iio@vger.kernel.org, Chunyan Zhang , Michael Hennerich , Martin Blumenstingl , Sascha Hauer , Cixi Geng , Kevin Hilman , Vladimir Zapolskiy , Pengutronix Kernel Team , Alexandru Ardelean , Fabio Estevam , Andriy Tryshnivskyy , Haibo Chen , Shawn Guo , Hans de Goede , Miquel Raynal , Jerome Brunet , Heiko Stuebner , Florian Boor , Ciprian Regus , Lars-Peter Clausen , Jonathan Cameron , Neil Armstrong , Baolin Wang , Jyoti Bhayana , Chen-Yu Tsai , Orson Zhai Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Tue, Sep 20, 2022 at 2:28 PM Nuno S=C3=A1 wrote: > > The iio_device lock is only meant for internal use. Hence define a > device local lock to protect against concurrent accesses. ... > info =3D iio_priv(indio_dev); > + mutex_init(&info->lock); > info->irq =3D platform_get_irq(pdev, 0); > if (info->irq < 0) > return info->irq; Consider initializing it as late as possible, like after IRQ retrieval in this context (maybe even deeper, but no context available). Ditto for the rest of the series. --=20 With Best Regards, Andy Shevchenko