From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B312BC2BA2B for ; Mon, 13 Apr 2020 20:23:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8F57320663 for ; Mon, 13 Apr 2020 20:23:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="T2opoYpI" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388325AbgDMUXQ (ORCPT ); Mon, 13 Apr 2020 16:23:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37852 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388320AbgDMUXO (ORCPT ); Mon, 13 Apr 2020 16:23:14 -0400 Received: from mail-pg1-x541.google.com (mail-pg1-x541.google.com [IPv6:2607:f8b0:4864:20::541]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CB4C2C0A3BDC; Mon, 13 Apr 2020 13:23:14 -0700 (PDT) Received: by mail-pg1-x541.google.com with SMTP id c23so4978009pgj.3; Mon, 13 Apr 2020 13:23:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=SmYokySQc4mDg5AFnuTSHPu2MaxcLIZMXu10ec67aWA=; b=T2opoYpInMSpCsD8FGnwp8RshE9LSmcUdKcxZmnLcVWaLY+YkwwpiJEbo2CL+dXGQh FDSq6Fguk1B/sqw5Yfb2IUgPZw+S61mN6LTusdBkdA7Zs7fehJhoGl1tg3wvYmXnXD1w QD72ryeQvsJ1KZNxnLlPMDD5PINAK6oVjiQEMqi4HaTdko1Wul28U2GYxRXMBlMWwjuy 0qmlTZ7azXWOdtMZ4Kktw6tp6kID/Q5NrgUlVvWyXChtEQ8x6vkcTUPQcukFs18FQ2WC qNW2Pax98aRgIsVCFqBSoF83wAVb+5+GasXsJg6xN0YdtUPVV6OtjpCNrw/6XYdZos9T boVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=SmYokySQc4mDg5AFnuTSHPu2MaxcLIZMXu10ec67aWA=; b=Ko4USKdTZkNbWJ3Uh5QcFrhLMpJGl0kyDmyd5PtxYDxluSmi+A57rwXGavdUH7YtSD k5accJ9VBhKW79Hmb+11WMfExHKU96kbt+s/N1aYpJdVmi8T2DhOuSYRvnltj8JX7kU/ YWxMazPzqUXCr0CyZuXJt87Vk+Ru58/LOQpChxCNAcRkMu0q3zEFq/FNAqfkiFtxtWXx W3O2+bKlLmwg7i3MidUm+NpcVYcwNXqXsBtcodiJkS8lgGa6plGOFahAV+uS5zPVBd1H w4mtxu9AU47Tj0p7feVQDIkoHtKJO0J95Zij7KnbKA5xll3XXelAq/CpVN85yATrQupm 69xg== X-Gm-Message-State: AGi0PuZu1AGRUvCENexuCrv8prIbiK44tOXMjAA0ka5CT/H+5WDZpRZY fWpA7pMi7BDUcUUts0ZH/I2nU+rvpS6INiZlWKg= X-Google-Smtp-Source: APiQypImH1MBeCQNjKwKjxst1BQnslU5r64FY1doy8gBsgZ1iDkIJUEd6FClNazs9I3WKnl7n2NFqWTsz4jHkZ5580c= X-Received: by 2002:aa7:9097:: with SMTP id i23mr19183933pfa.170.1586809394372; Mon, 13 Apr 2020 13:23:14 -0700 (PDT) MIME-Version: 1.0 References: <20200412183658.6755-1-mani@kernel.org> <20200412183658.6755-4-mani@kernel.org> In-Reply-To: <20200412183658.6755-4-mani@kernel.org> From: Andy Shevchenko Date: Mon, 13 Apr 2020 23:23:03 +0300 Message-ID: Subject: Re: [PATCH 3/3] iio: chemical: Add OF match table for CCS811 VOC sensor To: mani@kernel.org Cc: Jonathan Cameron , Rob Herring , narcisaanamaria12@gmail.com, Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald , linux-iio , devicetree , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Mon, Apr 13, 2020 at 10:23 AM wrote: > > From: Manivannan Sadhasivam > > Add devicetree OF match table support for CCS811 VOC sensor. ... > +#include Why? ... > +static const struct of_device_id ccs811_dt_ids[] = { > + { .compatible = "ams,ccs811" }, > + { } > +}; > +MODULE_DEVICE_TABLE(of, ccs811_dt_ids); Since it has no ugly ifdeffery... > static struct i2c_driver ccs811_driver = { > .driver = { > .name = "ccs811", > + .of_match_table = of_match_ptr(ccs811_dt_ids), ...use of of_match_ptr() brings a compiler warning. Drop of_match_ptr() for good. And thus drop redundant of.h. > }, -- With Best Regards, Andy Shevchenko