From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Matt Ranostay <matt.ranostay@konsulko.com>
Cc: Jonathan Cameron <jic23@kernel.org>,
linux-iio <linux-iio@vger.kernel.org>
Subject: Re: [PATCH] iio: health: max30102: update author's email
Date: Sun, 16 Aug 2020 12:51:53 +0300 [thread overview]
Message-ID: <CAHp75VeP24wrWk49Gic-fR72kU+1sBQD-OCW88ji1ZYShSsNXQ@mail.gmail.com> (raw)
In-Reply-To: <20200814134941.10576-1-matt.ranostay@konsulko.com>
On Sun, Aug 16, 2020 at 1:06 AM Matt Ranostay
<matt.ranostay@konsulko.com> wrote:
>
> Update email to author's current employer
> - * Copyright (C) 2017 Matt Ranostay <matt@ranostay.consulting>
> + * Copyright (C) 2017 Matt Ranostay <matt.ranostay@konsulko.com>
> -MODULE_AUTHOR("Matt Ranostay <matt@ranostay.consulting>");
> +MODULE_AUTHOR("Matt Ranostay <matt.ranostay@konsulko.com>");
This is actually an interesting question, had you been working already
for your current employer?
If no, I don't think this is a proper change in the code (of course it
might require your new contract, then it's probably fine, I dunno). It
would be a good change for MAINTAINERS, though.
If yes, the commit message doesn't clarify this.
In any case, just my 2 cents for the future changes like this, since
the patch already applied.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2020-08-16 9:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-14 13:49 [PATCH] iio: health: max30102: update author's email Matt Ranostay
2020-08-16 8:33 ` Jonathan Cameron
2020-08-16 9:51 ` Andy Shevchenko [this message]
2020-08-16 22:19 ` Matt Ranostay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75VeP24wrWk49Gic-fR72kU+1sBQD-OCW88ji1ZYShSsNXQ@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=matt.ranostay@konsulko.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).