From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Crt Mori <cmo@melexis.com>
Cc: Jonathan Cameron <jic23@kernel.org>,
linux-iio <linux-iio@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4 0/4] iio: temperature: mlx90632: Add extended calibration calculations
Date: Sat, 8 Aug 2020 23:06:53 +0300 [thread overview]
Message-ID: <CAHp75VeY9MgqenaCDJww4m+T6fpYeaGgPr8QXCYLxyx36BHnJg@mail.gmail.com> (raw)
In-Reply-To: <20200808121026.1300375-1-cmo@melexis.com>
On Sat, Aug 8, 2020 at 3:10 PM Crt Mori <cmo@melexis.com> wrote:
>
> Since the second patch is dependent on the first and was still not
> merged, I have decided to send them together. First patch just makes
> second one more readable as it splits out the repeated calculation and
> that enables the second patch to tweak the variable to the new
> condition.
So, we are closer, but here is one remark, it's not good to send a new
version if you are not going to address _all_ comments (it's fine to
do, but you need to answer first why you are not going to satisfy
them). For example, explicit castings here and there, voodoo
arithmetics is left uncommented.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2020-08-08 20:07 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-08 12:10 [PATCH v4 0/4] iio: temperature: mlx90632: Add extended calibration calculations Crt Mori
2020-08-08 12:10 ` [PATCH v4 1/4] iio:temperature:mlx90632: Reduce number of equal calulcations Crt Mori
2020-08-08 19:58 ` Andy Shevchenko
2020-08-08 12:10 ` [PATCH v4 2/4] iio:temperature:mlx90632: Adding extended calibration option Crt Mori
2020-08-08 20:03 ` Andy Shevchenko
2020-08-08 21:57 ` Crt Mori
2020-08-09 13:32 ` Jonathan Cameron
2020-08-09 21:05 ` Crt Mori
2020-08-11 7:53 ` Crt Mori
2020-08-16 9:09 ` Jonathan Cameron
2020-08-08 12:10 ` [PATCH v4 3/4] iio:temperature:mlx90632: Add kerneldoc to the internal struct Crt Mori
2020-08-08 19:54 ` Andy Shevchenko
2020-08-08 12:10 ` [PATCH v4 4/4] iio:temperature:mlx90632: Convert polling while loops to do-while Crt Mori
2020-08-08 19:56 ` [PATCH v4 0/4] iio: temperature: mlx90632: Add extended calibration calculations Andy Shevchenko
2020-08-08 20:04 ` Andy Shevchenko
2020-08-08 20:06 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75VeY9MgqenaCDJww4m+T6fpYeaGgPr8QXCYLxyx36BHnJg@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=cmo@melexis.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).