From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A49BC433E0 for ; Sun, 5 Jul 2020 12:06:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6A17320724 for ; Sun, 5 Jul 2020 12:06:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XnVjoK5p" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726898AbgGEMGG (ORCPT ); Sun, 5 Jul 2020 08:06:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39052 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726819AbgGEMGF (ORCPT ); Sun, 5 Jul 2020 08:06:05 -0400 Received: from mail-pf1-x443.google.com (mail-pf1-x443.google.com [IPv6:2607:f8b0:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A7082C061794 for ; Sun, 5 Jul 2020 05:06:05 -0700 (PDT) Received: by mail-pf1-x443.google.com with SMTP id x72so6403398pfc.6 for ; Sun, 05 Jul 2020 05:06:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=a9gGLAtdTNLLuOtqrem0idEzGGwAm+4JXlYOcyzbgx4=; b=XnVjoK5pN7wm1BLIEAfS+KxoVjASZcFsbQZ2VTCPONlmLZQZiU76eV4TG1fGrdPjCD lrmehEEiBbRFZBtEtf23vfgf7mfcVVPHXcPQEDJ7ra5AypOWqEXhe3JS/Fwj7ydrfjnT 3nvWmtPFdtI5ncdcDvjZvg47jaRB2nabSCUwkZ7F8j9debanifno+twAkFZX3rXEyVox cp+QIM/zkCagIxKS338S93TnCxYMdI3QgUjBhj8AdifQDcd2q3BnkeDK4UfNmSXzkCXE 3q2q6aOgFmu7S1c3BVTr5P7aUtvU0UN7XpQ9TfTXT5/OLTBRPJD1986eddQRBZvyEwt2 uJlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=a9gGLAtdTNLLuOtqrem0idEzGGwAm+4JXlYOcyzbgx4=; b=lA55YTQwlsVXTTg283bBu7ox93euHKPT9Hh323RjEqiVNWaTMeh2eZt9JENQRmfOs0 cA2bOlKvD8v+1m8Cf6V5MLiT0WymHFCU/pFr+txyqXClQIjpCqkKQwmgFx6PiRV8imeQ qhkMdzAvjNXGN0h1LQ29lu5UHuCpKcRTH8QyCTG//aMOG1I7EwODrcMSkgg+EVHo+qqK 2UCSBONbkTXSlodZ/EOIWD6bCIQtQPqKBbCnQyyizG3DHfp4yJiSoeUPDfYP6D5uzhg4 LeAcZqjupHWlo9b43Nv0DcsYDbeLyyMTqFVnCo8ryiXezSDOqqAyhLkgXDl5Id9rsVC6 Cjgw== X-Gm-Message-State: AOAM531we4t8bbjzJ/qfVse24Q5zavuZHjYmVp4aeYpkx0KppIErceL4 egb9lp5f9TjuWrYyanvH2wYUqOInJXDviCQVGTpROYGT X-Google-Smtp-Source: ABdhPJzK+yqC1MMXTDJVH4/+hfR/DwILfINdvy9vvw3tbJ6PHEO3gceRcsXbj557wfenXlFfb+bdX5689yMZK3zoocY= X-Received: by 2002:aa7:8bcb:: with SMTP id s11mr26830886pfd.170.1593950765200; Sun, 05 Jul 2020 05:06:05 -0700 (PDT) MIME-Version: 1.0 References: <20200607155408.958437-1-jic23@kernel.org> <20200607155408.958437-12-jic23@kernel.org> In-Reply-To: <20200607155408.958437-12-jic23@kernel.org> From: Andy Shevchenko Date: Sun, 5 Jul 2020 15:05:49 +0300 Message-ID: Subject: Re: [PATCH 11/32] iio:light:st_uvis25 Fix timestamp alignment and prevent data leak. To: Jonathan Cameron Cc: linux-iio , Andy Shevchenko , Jonathan Cameron , Lars-Peter Clausen , Lorenzo Bianconi Content-Type: text/plain; charset="UTF-8" Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Sun, Jun 7, 2020 at 6:57 PM Jonathan Cameron wrote: ... > + /* Ensure timestamp is naturally aligned */ > + struct { > + u8 chan; > + s64 ts __aligned(8); > + } scan; > }; ... > - err = regmap_read(hw->regmap, ST_UVIS25_REG_OUT_ADDR, (int *)buffer); > + err = regmap_read(hw->regmap, ST_UVIS25_REG_OUT_ADDR, > + (unsigned int *)&hw->scan.chan); Despite knowing that this is okay, from a language perspective this casting is not good. Potential mine for all kinds of static analyzers. I think it should use a temporary unsigned int (or what regmap API wants) variable. -- With Best Regards, Andy Shevchenko