From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54BD3C43331 for ; Sat, 28 Mar 2020 11:02:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2745020716 for ; Sat, 28 Mar 2020 11:02:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gjcm36dX" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726258AbgC1LC3 (ORCPT ); Sat, 28 Mar 2020 07:02:29 -0400 Received: from mail-pl1-f196.google.com ([209.85.214.196]:42327 "EHLO mail-pl1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725973AbgC1LC3 (ORCPT ); Sat, 28 Mar 2020 07:02:29 -0400 Received: by mail-pl1-f196.google.com with SMTP id e1so4512746plt.9; Sat, 28 Mar 2020 04:02:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ybzEvvM/Y1fK+T4WB91lb7mb7tennh3w1iclknsvBKc=; b=gjcm36dXWUs94y8B/p36oRvfBldTX64A6N06TUsXWS0b6nFqH9rrxoCyNRHHeaiVvv 2LEb+zr4cpeSH3c8zLRfFw7jgECmRWw4mCs/f3/u2Ww6lmBoefnBs/fIN8A3GcNwNmVK Gicsud5Vj0H+I01Pg+ccfKrB1dPmMbHfo1vaCaGqSPFv7xrTY5WUlOXlUYi74oWp2hiF z5LLYLMYKpyFvO3E4jC5wkTmryGlRW/yfOWK22PC1u+XAiXNEzFJ45Tz92vRfXqUUlc1 dN8XRULR6WSGhd1zWwvsa8Yy3X25R3H3u2heWimkaCV/Sz8qgKBtT6k0nXrMQ0JfeK5b 2yBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ybzEvvM/Y1fK+T4WB91lb7mb7tennh3w1iclknsvBKc=; b=Mq90f3Nhi73MFpYncHkTweX/jPhRB1Nu8S1AEaweCkrCt3gDehgZKMM4EYbCm+nqxS gFWq0gT7AZThy70TERzTyvPaF+YZfjWooc2QKlL72C56y5g3ssHt0oYCZGUzhZ8EWjEP YHE96N1W3X7pDsy8emZJ1nwPkre4D93C86Zvho88HSv3NjQrMj7MT+Ev9x8xoaoGmGjX BIDOVcTxPAfF98iI4bShycZIsPinJX3WPG3xcu0NDukBI6L/BU55VFDdzrvLIsQuq5u9 GZnO2sDEfTLS7ihC2uOwyKwksO+VNg/7UcF8rnXdxMIrm8MGnAXYTbVPopNE8YVyth8V V6tA== X-Gm-Message-State: ANhLgQ24Kxf25wpCOcwQ2CCrFkSdc7wYOUiEG3M0wKpelBVwt5Y5mCsY 9Ha5dmzr/MudgEZcLpDpt3hmaAD4bhYIZWiZT3Q= X-Google-Smtp-Source: ADFU+vuCr9+XdOtdmikLkVMOj3ejA58Zcuyfi6kogZWnczcwpxiLFPcnu2MTG/IsoHJiICAMnk8f3uvOS5NSWlNwi7k= X-Received: by 2002:a17:90a:9408:: with SMTP id r8mr4479521pjo.1.1585393348229; Sat, 28 Mar 2020 04:02:28 -0700 (PDT) MIME-Version: 1.0 References: <20200328001154.17313-1-sravanhome@gmail.com> <20200328001154.17313-5-sravanhome@gmail.com> In-Reply-To: <20200328001154.17313-5-sravanhome@gmail.com> From: Andy Shevchenko Date: Sat, 28 Mar 2020 13:02:17 +0200 Message-ID: Subject: Re: [PATCH v5 4/5] power: supply: Add support for mps mp2629 battery charger To: Saravanan Sekar Cc: Lee Jones , Rob Herring , Jonathan Cameron , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald , Sebastian Reichel , devicetree , Linux Kernel Mailing List , linux-iio , Linux PM Content-Type: text/plain; charset="UTF-8" Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Sat, Mar 28, 2020 at 2:12 AM Saravanan Sekar wrote: > > The mp2629 provides switching-mode battery charge management for > single-cell Li-ion or Li-polymer battery. Driver supports the > access/control input source and battery charging parameters. ... > +#include > +#include Missed header bits.h. ... > + ret = iio_read_channel_processed(charger->iiochan[ch], &chval); > + if (ret < 0) Is it possible to get positive returned value? > + return ret; ... > + val->intval = (rval * props[fld].step) + props[fld].min; Too many parentheses. ... > + return ((psp == POWER_SUPPLY_PROP_PRECHARGE_CURRENT) || > + (psp == POWER_SUPPLY_PROP_CHARGE_TERM_CURRENT) || > + (psp == POWER_SUPPLY_PROP_CONSTANT_CHARGE_CURRENT) || > + (psp == POWER_SUPPLY_PROP_CONSTANT_CHARGE_VOLTAGE)); Ditto. ... > + return ((psp == POWER_SUPPLY_PROP_INPUT_VOLTAGE_LIMIT) || > + (psp == POWER_SUPPLY_PROP_INPUT_CURRENT_LIMIT)); Ditto. ... > + return sprintf(buf, "%d mohm\n", rval); Hmm... For units we usually have separate node, but it is up to maintainer, I dunno what the common practice is there. ... > + int val; > + int ret; > + > + ret = kstrtoint(buf, 10, &val); > + if (ret) > + return ret; > + > + if (val < 0 && val > 140) What the point to convert negative values in the first place? kstrtouint() > + return -ERANGE; ... > + struct power_supply_config psy_cfg = {NULL}; { 0 } -- With Best Regards, Andy Shevchenko