From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F4091C433DF for ; Thu, 27 Aug 2020 19:56:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CDE0922CB3 for ; Thu, 27 Aug 2020 19:56:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="SR0DcGiR" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726400AbgH0T4I (ORCPT ); Thu, 27 Aug 2020 15:56:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52814 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726246AbgH0T4I (ORCPT ); Thu, 27 Aug 2020 15:56:08 -0400 Received: from mail-pf1-x443.google.com (mail-pf1-x443.google.com [IPv6:2607:f8b0:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E3C80C061264; Thu, 27 Aug 2020 12:56:07 -0700 (PDT) Received: by mail-pf1-x443.google.com with SMTP id p11so4321135pfn.11; Thu, 27 Aug 2020 12:56:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=YLa56i743GyYyvzZsbp7wDSdWi+EGIOQBt69Q105LwQ=; b=SR0DcGiRNSloexRgT5hNz4a+LfcqsIQj20wgCxHugcf+XgWQvmGFw0bnb0I7KbH+/c ogmXVcx8dsIt5IUDS/nGPWPBDatpaPAfM4P20TV5kzuntmfkhHwjvY9r9zW/CV8eKDUc oyYKZqYPt8LQaH829LamjzKyYe8CKpA8OZQMHcTyINmYvBZQ4Df4AnE1g6asyOOpkfCD TLQ5THGMgBFl8C5iKS2IuJ5aKQKMbHXw2v1y9jSF9m0qwPaLjYSjfuAZwAOemI2Rj0bw NMvemTfF1vk0wlIrV2GWv254XcKVuSD1++6tqd8PyFVcEvx3nMHuigVsvGKhuYalkxEc wSqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=YLa56i743GyYyvzZsbp7wDSdWi+EGIOQBt69Q105LwQ=; b=GJZP0fEp/v4KuWgi1S0LBWM6TDZ39NwvE0HqE2DIXIA2nOEtWnyAYAJRXUYMwoMxBn SwRs48DpaoIoAs8OUfDIH+l6irGYZIP3ZHAnaC1su4tGWzM50vq+KAfRZ6R00P05/6L1 FJn8YwF+UE7I55duIQmN5YMj1CluMbCvAy5r1kpxDJjQNuxW8sdERJZ5p1pQK2VKHvUZ j//zp5gkrTYH+KZ4Y32Lyf9NSjRVitrqidhSkQ9mPEbxiVmrvrJzHl54KFUVKlzZOxZ/ v3eD6juKNbZerQJh8psdmEk3x744B5FQslPQop8UzFNQhHDn9YvSYjxlyGb04aXD//UZ Ukfw== X-Gm-Message-State: AOAM532OMH4EZhm44HPBRrn5KrSD5vOvYVdkd4gvaTexz4aaoMJusfD1 WUbK2av6/12fW9MjeKhnljbGCGsq2lmHGwoDngg= X-Google-Smtp-Source: ABdhPJzz9OgKhOSf0QaPl+XE+7282MSmPn4HpuGGEVGW9DN6uF+vFghnleghHOCVxElQYmTrlTqoeuz0+DPlkRO0bPw= X-Received: by 2002:a63:ec18:: with SMTP id j24mr15250227pgh.74.1598558167388; Thu, 27 Aug 2020 12:56:07 -0700 (PDT) MIME-Version: 1.0 References: <20200827192642.1725-1-krzk@kernel.org> <20200827192642.1725-12-krzk@kernel.org> In-Reply-To: <20200827192642.1725-12-krzk@kernel.org> From: Andy Shevchenko Date: Thu, 27 Aug 2020 22:55:51 +0300 Message-ID: Subject: Re: [PATCH v2 12/18] iio: dac: dpot-dac: Simplify with dev_err_probe() To: Krzysztof Kozlowski Cc: Jonathan Cameron , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , Peter Rosin , Kukjin Kim , Michael Hennerich , Kevin Hilman , Neil Armstrong , Jerome Brunet , Martin Blumenstingl , Marek Vasut , Maxime Coquelin , Alexandre Torgue , Beniamin Bia , Tomasz Duszynski , Linus Walleij , linux-iio , Linux Kernel Mailing List , linux-arm Mailing List , linux-samsung-soc@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com Content-Type: text/plain; charset="UTF-8" Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Thu, Aug 27, 2020 at 10:28 PM Krzysztof Kozlowski wrote: > > Common pattern of handling deferred probe can be simplified with > dev_err_probe(). Less code and also it prints the error value. Reviewed-by: Andy Shevchenko > Signed-off-by: Krzysztof Kozlowski > --- > drivers/iio/dac/dpot-dac.c | 16 ++++++---------- > 1 file changed, 6 insertions(+), 10 deletions(-) > > diff --git a/drivers/iio/dac/dpot-dac.c b/drivers/iio/dac/dpot-dac.c > index be61c3b01e8b..2258535b8a42 100644 > --- a/drivers/iio/dac/dpot-dac.c > +++ b/drivers/iio/dac/dpot-dac.c > @@ -183,18 +183,14 @@ static int dpot_dac_probe(struct platform_device *pdev) > indio_dev->num_channels = 1; > > dac->vref = devm_regulator_get(dev, "vref"); > - if (IS_ERR(dac->vref)) { > - if (PTR_ERR(dac->vref) != -EPROBE_DEFER) > - dev_err(&pdev->dev, "failed to get vref regulator\n"); > - return PTR_ERR(dac->vref); > - } > + if (IS_ERR(dac->vref)) > + return dev_err_probe(&pdev->dev, PTR_ERR(dac->vref), > + "failed to get vref regulator\n"); > > dac->dpot = devm_iio_channel_get(dev, "dpot"); > - if (IS_ERR(dac->dpot)) { > - if (PTR_ERR(dac->dpot) != -EPROBE_DEFER) > - dev_err(dev, "failed to get dpot input channel\n"); > - return PTR_ERR(dac->dpot); > - } > + if (IS_ERR(dac->dpot)) > + return dev_err_probe(&pdev->dev, PTR_ERR(dac->dpot), > + "failed to get dpot input channel\n"); > > ret = iio_get_channel_type(dac->dpot, &type); > if (ret < 0) > -- > 2.17.1 > -- With Best Regards, Andy Shevchenko