From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F452C4332B for ; Thu, 19 Mar 2020 10:24:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 23FA3206D7 for ; Thu, 19 Mar 2020 10:24:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="OuLtf1Cv" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726983AbgCSKYN (ORCPT ); Thu, 19 Mar 2020 06:24:13 -0400 Received: from mail-pl1-f195.google.com ([209.85.214.195]:37868 "EHLO mail-pl1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726765AbgCSKYN (ORCPT ); Thu, 19 Mar 2020 06:24:13 -0400 Received: by mail-pl1-f195.google.com with SMTP id f16so878914plj.4; Thu, 19 Mar 2020 03:24:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=p3r+VAHql+NP8pG7ZRzCI1tKv/6Ke1R8Od0R0hVXCz4=; b=OuLtf1CvxjTW12d4iEIOBP4cT+yNyQ4jW6U1i1yAILpZN2xtuL445eKHtrwDy9o0Fg Ck3rGRt1jNxV5Mj1Ligt1lBm6TY+4O4Dzehr7sAStYtFzmAz0pDzJH4CDZfVGoXguJ+z BkMXwOlqvpohkTuI3hmL8O9nACqQP7pPqY9BwWZtDHrcLX+T3/mMAe0ODmsDXTYYgcHv g4t2ShsrJp3OBJegNBZmCSIwc/kq/qgfx0lu7gPFY9L/HFDM7cIDzmxseg4iMN75dsgL Z6w90VKsNG68UliJ8yefBdtcMSyKYjsezaNiOaZAs5P3Ohj6Ym1A/f7cmmjAo6V5yMWk O5gA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=p3r+VAHql+NP8pG7ZRzCI1tKv/6Ke1R8Od0R0hVXCz4=; b=B8ay17Os8l9v0l2Ad5Ps45wStrSg+meMGwxYhEzs0cvn7OWTZgQR27BwAjGV6xBWVJ ozZW6oiqI4gaCfziav9KMgJoYugWo/54z+DHVFzhaFYD+iFFibaS6Ss7P8jEC7WeVZwG a3/Xc+X9+gFGRLrn5cPMn/RL78nrkFUiQk6CkAR+2zqlOccyji81dm00Vxd1Qxz4nnWT sYR5QZywWkPKKQ4YV2GMqi7NCPnVQ4T4uLq8vzgCDi1baWrUnsrMCcUE5lgBflUbd1OL gnDO51g274opxRkABgXPZHReAsO/+WYyFiDcZqWgjGcEnjs9wWZn+89q6ytuU/Q9AzsW TsGw== X-Gm-Message-State: ANhLgQ34rHiyeWB84M9eBFkQcWNtSju63yOmn0rj47WHy0zCyqt+LFGU pM/GI7jNkormnZ4nNH41MffdsdhnvL3vhPqt1Bk= X-Google-Smtp-Source: ADFU+vtSQwZTCu2Njzsv2xzB4wNSocYdn1ZQQiF6gB56AeE27bNJyfK+qypfWdy4jN5YrJnS52/hcob4sWOz7z575Ws= X-Received: by 2002:a17:90a:a48b:: with SMTP id z11mr3147372pjp.1.1584613451888; Thu, 19 Mar 2020 03:24:11 -0700 (PDT) MIME-Version: 1.0 References: <5e730c2f.1c69fb81.9eda3.5c70@mx.google.com> In-Reply-To: <5e730c2f.1c69fb81.9eda3.5c70@mx.google.com> From: Andy Shevchenko Date: Thu, 19 Mar 2020 12:24:00 +0200 Message-ID: Subject: Re: [PATCH] iio: imu: inv_mpu6050: add debugfs register r/w interface To: Rohit Sarkar Cc: linux-iio , Linux Kernel Mailing List , Jonathan Cameron , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , Jean-Baptiste Maneyrol , Andy Shevchenko , Linus Walleij Content-Type: text/plain; charset="UTF-8" Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Thu, Mar 19, 2020 at 8:10 AM Rohit Sarkar wrote: > > The iio debugfs interface provides direct access to read and write device > registers if debugfs is enabled. But regmap API provides at least reading facility. Isn't it enough? ... > static const struct iio_info mpu_info = { > .read_raw = &inv_mpu6050_read_raw, > .write_raw = &inv_mpu6050_write_raw, > .write_raw_get_fmt = &inv_write_raw_get_fmt, > .attrs = &inv_attribute_group, > .validate_trigger = inv_mpu6050_validate_trigger, > + .debugfs_reg_access = &inv_mpu6050_reg_access Leaving comma is helpful for future development. > }; -- With Best Regards, Andy Shevchenko