linux-iio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: linux-iio <linux-iio@vger.kernel.org>,
	Jonathan Cameron <Jonathan.Cameron@huawei.com>
Subject: Re: [PATCH 00/38] iio: remaining easy of_match_ptr removal and related.
Date: Mon, 14 Sep 2020 11:04:43 +0300	[thread overview]
Message-ID: <CAHp75Vf8T44zhS99A9bm3mBO04Cfkqz1N8wGVe0Kjq8JPoPCqQ@mail.gmail.com> (raw)
In-Reply-To: <20200910173242.621168-1-jic23@kernel.org>

On Thu, Sep 10, 2020 at 8:35 PM Jonathan Cameron <jic23@kernel.org> wrote:
>
> From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
>
> This bumper set removes all the remaining cases where of_match_ptr
> is mostly serving to prevent use of the device via ACPI PRP0001 and
> complicating the code. The main aim of this set is to reduce the chances
> of it being used in future drivers.
> It also includes some related refactorings, use of generic fw accessors,
> dropping of CONFIG_OF and lots of header changes inline with the above.
>
> For examples of how to use PRP0001 see https://github.com/westeri/meta-acpi
> which is an excellent resource from which to copy snippets of DSDT tables.
>
> It may well not be worth changing the remaining 10 IIO drivers and I
> certainly don't plan to do so anytime soon.
>

I briefly looked at the series and didn't see anything wrong with it
(esp. taking into consideration that you are already familiar with the
topic).
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>

> Jonathan Cameron (38):
>   iio:potentiometer:ad5272: Drop of_match_ptr and CONFIG_OF protections.
>   iio:potentiometer:ds1803: Drop of_match_ptr and CONFIG_OF protections
>   iio:potentiometer:max5432: Drop of_match_ptr and use generic fw
>     accessors
>   iio:potentiometer:max5481: Drop of_match_ptr and CONFIG_OF
>     protections.
>   iio:potentiometer:max5481: Drop invalid ACPI binding.
>   iio:potentiometer:mcp4018: Drop of_match_ptr and CONFIG_OF
>     protections.
>   iio:potentiometer:mcp4131: Drop of_match_ptr and use generic fw
>     interfaces.
>   iio:potentiometer:mcp4531: Drop of_match_ptr and CONFIG_OF
>     protections.
>   iio:dac:ad5446: Drop of_match_ptr and CONFIG_OF protections
>   iio:dac:ad5592r: Drop of_match_ptr and ACPI_PTR protections.
>   iio:dac:ad5593r: Drop of_match_ptr and ACPI_PTR protections.
>   iio:dac:ad7303: Drop of_match_ptr protection
>   iio:dac:mcp4725: drop of_match_ptr and use generic fw properties
>   iio:dac:ti-dac082s085: Drop of_match_ptr and CONFIG_OF protections
>   iio:dac:ti-dac5571: Drop of_match_ptr and CONFIG_OF protections
>   iio:potentiostat:lmp91000: Drop of_match_ptr and use generic fw
>     accessors
>   iio:pressure:icp10100: Drop of_match_ptr and CONFIG_OF protections
>   iio:pressure:ms5611: Drop of_match_ptr and CONFIG_OF protections
>   iio:pressure:ms5637: Drop of_match_ptr protection
>   iio:pressure:zpa2326: Drop of_match_ptr protection
>   iio:temperature:tsys01: Drop of_match_ptr protection
>   iio:temperature:tmp007: Drop of_match_ptr protection
>   iio:resolver:ad2s1200: Drop of_match_ptr protection
>   iio:chemical:ams-iaq-core: Drop of_match_ptr protection
>   iio:chemical:atlas-sensor: Drop of_match_ptr and use generic fw
>     accessors
>   iio:chemical:sgp30: Use local variable dev to simplify code
>   iio:chemical:sgp30: Drop of_match_ptr and use generic fw accessors
>   iio:chemical:vz89x: Introduce local struct device pointer.
>   iio:chemical:vz89x: Drop of_match_ptr protection and use generic fw
>     accessors
>   iio:humidity:hdc100x: Drop of_match_ptr protection.
>   iio:proximity:as3935: Use local struct device pointer to simplify
>     code.
>   iio:proximity:as3935: Drop of_match_ptr and use generic fw accessors
>   iio:proximity:pulsedlight: Drop of_match_ptr protection
>   iio:magn:ak8975: Drop of_match_ptr and ACPI_PTR protections.
>   iio:magn:ak8974: Drop of_match_ptr protection
>   iio:humidity:htu21: Drop of_match_ptr protection
>   iio:humidity:si7020: Drop of_match_ptr protection
>   iio:health:max30102: Drop of_match_ptr and use generic fw accessors
>
>  drivers/iio/chemical/ams-iaq-core.c           |  3 +-
>  drivers/iio/chemical/atlas-sensor.c           | 10 ++---
>  drivers/iio/chemical/sgp30.c                  | 28 ++++++------
>  drivers/iio/chemical/vz89x.c                  | 18 ++++----
>  drivers/iio/dac/ad5446.c                      |  5 +--
>  drivers/iio/dac/ad5592r.c                     |  7 ++-
>  drivers/iio/dac/ad5593r.c                     |  7 ++-
>  drivers/iio/dac/ad7303.c                      |  3 +-
>  drivers/iio/dac/mcp4725.c                     | 29 +++---------
>  drivers/iio/dac/ti-dac082s085.c               |  5 +--
>  drivers/iio/dac/ti-dac5571.c                  |  7 +--
>  drivers/iio/health/max30102.c                 | 11 +++--
>  drivers/iio/humidity/hdc100x.c                |  3 +-
>  drivers/iio/humidity/htu21.c                  |  3 +-
>  drivers/iio/humidity/si7020.c                 |  3 +-
>  drivers/iio/magnetometer/ak8974.c             |  3 +-
>  drivers/iio/magnetometer/ak8975.c             |  8 ++--
>  drivers/iio/potentiometer/ad5272.c            |  5 +--
>  drivers/iio/potentiometer/ds1803.c            |  6 +--
>  drivers/iio/potentiometer/max5432.c           |  8 ++--
>  drivers/iio/potentiometer/max5481.c           | 23 ++--------
>  drivers/iio/potentiometer/mcp4018.c           | 12 ++---
>  drivers/iio/potentiometer/mcp4131.c           |  8 ++--
>  drivers/iio/potentiometer/mcp4531.c           | 11 ++---
>  drivers/iio/potentiostat/lmp91000.c           | 11 +++--
>  drivers/iio/pressure/icp10100.c               |  3 +-
>  drivers/iio/pressure/ms5611_i2c.c             |  6 +--
>  drivers/iio/pressure/ms5611_spi.c             |  6 +--
>  drivers/iio/pressure/ms5637.c                 |  3 +-
>  drivers/iio/pressure/zpa2326_i2c.c            |  6 +--
>  drivers/iio/pressure/zpa2326_spi.c            |  6 +--
>  drivers/iio/proximity/as3935.c                | 44 +++++++++----------
>  .../iio/proximity/pulsedlight-lidar-lite-v2.c |  3 +-
>  drivers/iio/resolver/ad2s1200.c               |  3 +-
>  drivers/iio/temperature/tmp007.c              |  4 +-
>  drivers/iio/temperature/tsys01.c              |  3 +-
>  36 files changed, 134 insertions(+), 190 deletions(-)
>
> --
> 2.28.0
>


-- 
With Best Regards,
Andy Shevchenko

  parent reply	other threads:[~2020-09-14  8:06 UTC|newest]

Thread overview: 55+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-10 17:32 [PATCH 00/38] iio: remaining easy of_match_ptr removal and related Jonathan Cameron
2020-09-10 17:32 ` [PATCH 01/38] iio:potentiometer:ad5272: Drop of_match_ptr and CONFIG_OF protections Jonathan Cameron
2020-09-10 17:32 ` [PATCH 02/38] iio:potentiometer:ds1803: " Jonathan Cameron
2020-09-10 17:32 ` [PATCH 03/38] iio:potentiometer:max5432: Drop of_match_ptr and use generic fw accessors Jonathan Cameron
2020-09-21 14:24   ` Martin Kaiser
2020-09-10 17:32 ` [PATCH 04/38] iio:potentiometer:max5481: Drop of_match_ptr and CONFIG_OF protections Jonathan Cameron
2020-09-10 17:32 ` [PATCH 05/38] iio:potentiometer:max5481: Drop invalid ACPI binding Jonathan Cameron
2020-09-14  8:07   ` Andy Shevchenko
2020-09-10 17:32 ` [PATCH 06/38] iio:potentiometer:mcp4018: Drop of_match_ptr and CONFIG_OF protections Jonathan Cameron
2020-09-10 17:32 ` [PATCH 07/38] iio:potentiometer:mcp4131: Drop of_match_ptr and use generic fw interfaces Jonathan Cameron
2020-09-10 17:32 ` [PATCH 08/38] iio:potentiometer:mcp4531: Drop of_match_ptr and CONFIG_OF protections Jonathan Cameron
2020-09-10 17:32 ` [PATCH 09/38] iio:dac:ad5446: " Jonathan Cameron
2020-09-10 17:32 ` [PATCH 10/38] iio:dac:ad5592r: Drop of_match_ptr and ACPI_PTR protections Jonathan Cameron
2020-09-10 17:32 ` [PATCH 11/38] iio:dac:ad5593r: " Jonathan Cameron
2020-09-10 17:32 ` [PATCH 12/38] iio:dac:ad7303: Drop of_match_ptr protection Jonathan Cameron
2020-09-10 17:32 ` [PATCH 13/38] iio:dac:mcp4725: drop of_match_ptr and use generic fw properties Jonathan Cameron
2020-09-10 17:32 ` [PATCH 14/38] iio:dac:ti-dac082s085: Drop of_match_ptr and CONFIG_OF protections Jonathan Cameron
2020-09-10 17:32 ` [PATCH 15/38] iio:dac:ti-dac5571: " Jonathan Cameron
2020-09-10 17:32 ` [PATCH 16/38] iio:potentiostat:lmp91000: Drop of_match_ptr and use generic fw accessors Jonathan Cameron
2020-09-15 18:59   ` Matt Ranostay
2020-09-10 17:32 ` [PATCH 17/38] iio:pressure:icp10100: Drop of_match_ptr and CONFIG_OF protections Jonathan Cameron
2020-09-10 17:32 ` [PATCH 18/38] iio:pressure:ms5611: " Jonathan Cameron
2020-09-10 17:32 ` [PATCH 19/38] iio:pressure:ms5637: Drop of_match_ptr protection Jonathan Cameron
2020-09-10 17:32 ` [PATCH 20/38] iio:pressure:zpa2326: " Jonathan Cameron
2020-09-10 17:32 ` [PATCH 21/38] iio:temperature:tsys01: " Jonathan Cameron
2020-09-10 17:32 ` [PATCH 22/38] iio:temperature:tmp007: " Jonathan Cameron
2020-09-10 17:32 ` [PATCH 23/38] iio:resolver:ad2s1200: " Jonathan Cameron
2020-09-10 17:32 ` [PATCH 24/38] iio:chemical:ams-iaq-core: " Jonathan Cameron
2020-09-15 18:55   ` Matt Ranostay
2020-09-10 17:32 ` [PATCH 25/38] iio:chemical:atlas-sensor: Drop of_match_ptr and use generic fw accessors Jonathan Cameron
2020-09-15 18:59   ` Matt Ranostay
2020-09-10 17:32 ` [PATCH 26/38] iio:chemical:sgp30: Use local variable dev to simplify code Jonathan Cameron
2020-09-10 17:32 ` [PATCH 27/38] iio:chemical:sgp30: Drop of_match_ptr and use generic fw accessors Jonathan Cameron
2020-09-10 17:32 ` [PATCH 28/38] iio:chemical:vz89x: Introduce local struct device pointer Jonathan Cameron
2020-09-15 19:02   ` Matt Ranostay
2020-09-10 17:32 ` [PATCH 29/38] iio:chemical:vz89x: Drop of_match_ptr protection and use generic fw accessors Jonathan Cameron
2020-09-15 19:03   ` Matt Ranostay
2020-09-10 17:32 ` [PATCH 30/38] iio:humidity:hdc100x: Drop of_match_ptr protection Jonathan Cameron
2020-09-15 18:59   ` Matt Ranostay
2020-09-10 17:32 ` [PATCH 31/38] iio:proximity:as3935: Use local struct device pointer to simplify code Jonathan Cameron
2020-09-15 18:56   ` Matt Ranostay
2020-09-10 17:32 ` [PATCH 32/38] iio:proximity:as3935: Drop of_match_ptr and use generic fw accessors Jonathan Cameron
2020-09-15 18:55   ` Matt Ranostay
2020-09-10 17:32 ` [PATCH 33/38] iio:proximity:pulsedlight: Drop of_match_ptr protection Jonathan Cameron
2020-09-15 18:55   ` Matt Ranostay
2020-09-10 17:32 ` [PATCH 34/38] iio:magn:ak8975: Drop of_match_ptr and ACPI_PTR protections Jonathan Cameron
2020-09-11 18:59   ` Jonathan Albrieux
2020-09-10 17:32 ` [PATCH 35/38] iio:magn:ak8974: Drop of_match_ptr protection Jonathan Cameron
2020-09-29 12:40   ` Linus Walleij
2020-09-10 17:32 ` [PATCH 36/38] iio:humidity:htu21: " Jonathan Cameron
2020-09-10 17:32 ` [PATCH 37/38] iio:humidity:si7020: " Jonathan Cameron
2020-09-10 17:32 ` [PATCH 38/38] iio:health:max30102: Drop of_match_ptr and use generic fw accessors Jonathan Cameron
2020-09-15 18:54   ` Matt Ranostay
2020-09-14  8:04 ` Andy Shevchenko [this message]
2020-09-17 18:17   ` [PATCH 00/38] iio: remaining easy of_match_ptr removal and related Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAHp75Vf8T44zhS99A9bm3mBO04Cfkqz1N8wGVe0Kjq8JPoPCqQ@mail.gmail.com \
    --to=andy.shevchenko@gmail.com \
    --cc=Jonathan.Cameron@huawei.com \
    --cc=jic23@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).