Linux-IIO Archive on lore.kernel.org
 help / color / Atom feed
From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: linux-iio <linux-iio@vger.kernel.org>,
	Alexandru Ardelean <alexandru.Ardelean@analog.com>,
	Jonathan Cameron <Jonathan.Cameron@huawei.com>
Subject: Re: [PATCH 00/23] iio:adc more of_match_ptr and similar removal
Date: Sun, 28 Jun 2020 20:53:09 +0300
Message-ID: <CAHp75VfP69DZqA2rH+RCTWnwrU=sYX98zXuWqVE9K3UTzCOeJQ@mail.gmail.com> (raw)
In-Reply-To: <20200628123654.32830-1-jic23@kernel.org>

On Sun, Jun 28, 2020 at 3:38 PM Jonathan Cameron <jic23@kernel.org> wrote:
>
> From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
>
> Continuation of slow process to try and remove use of of_match_ptr
> to supress asignment of the of_device_id table when !CONFIG_OF.

suppress assignment ?

> Usual argument that it prevents ACPI being used with these drivers
> via PRP0001 in DSDT.  Perhaps more usefully we are cutting down on the
> number of places it can be cut and paste from into new drivers.
>
> This is just the low hanging fruit.  I'm not yet sure if it makes
> sense to expend the effort to use generic firmware properties etc
> for some of the remaining drivers as it is unlikely they'll ever
> be used with anything other than device tree. There are 4 current
> ADC drivers in this more complex category.

All of them make sense to me, but I did only a shallow review (I would
look closer next week).
Also, perhaps it makes sense to give people an example of what it
looks like in the ACPI table. For example, in the cover letter (this
message) mention a link to meta-acpi repository [1] which has a lot of
examples [2].

[1]: https://github.com/westeri/meta-acpi
[2]: https://github.com/westeri/meta-acpi/tree/master/recipes-bsp/acpi-tables/samples
(Edison has most of the examples right now)


> Jonathan Cameron (23):
>   iio:adc:lpc32xx: Drop of_match_ptr protection
>   iio:adc:axp20x: Convert from OF to generic fw / device properties
>   iio:adc:hi8435: Drop unused of_gpio.h header
>   iio:adc:hi8435: Drop of_match_ptr protection.
>   iio:adc:max1363: Drop of_match_ptr and use generic
>     device_get_match_data
>   iio:adc:max1027: drop of_match_ptr and CONFIG_OF protections
>   iio:adc:ltc2496: Drop of_match_ptr and use mod_devicetable.h
>   iio:adc:cpcap-adc: Drop of_match_ptr protection and use
>     device_get_match_data
>   iio:adc:ltc2497 drop of_match_ptr protection
>   iio:adc:max11100: Drop of_match_ptr protection / add mod_devicetable.h
>     include
>   iio:adc:max1118: Drop CONFIG_OF / of_match_ptr protections
>   iio:adc:mcp320x: Drop CONFIG_OF and of_match_ptr protections
>   iio:adc:mcp3422: remove CONFIG_OF and of_match_ptr protections
>   iio:adc:sd_adc_modulator: Drop of_match_ptr and tweak includes
>   iio:adc:ti-adc081c: Drop of_match_ptr and change to mod_devicetable.h
>   iio:adc:ti-adc0832: drop CONFIG_OF and of_match_ptr protections
>   iio:adc:ti-adc084s021: drop of_match_ptr protection
>   iio:adc:ti-adc108s102: Drop CONFIG_OF and of_match_ptr protections
>   iio:adc:ti-adc128s052: drop of_match_ptr protection
>   iio:adc:ti-adc161s626: Drop of_match_ptr protection.
>   iio:adc:ti-tlc4541: Drop CONFIG_OF and of_match_ptr protections.
>   iio:adc:bcm_iproc: Drop of_match_ptr protection and switch to
>     mod_devicetable.h
>   iio:adc:ingenic: drop of_match_ptr protection and include
>     mod_devicetable.h
>
>  drivers/iio/adc/axp20x_adc.c       | 10 +++++-----
>  drivers/iio/adc/bcm_iproc_adc.c    |  4 ++--
>  drivers/iio/adc/cpcap-adc.c        | 22 ++++++----------------
>  drivers/iio/adc/hi8435.c           |  6 ++----
>  drivers/iio/adc/ingenic-adc.c      |  5 ++---
>  drivers/iio/adc/lpc32xx_adc.c      |  5 ++---
>  drivers/iio/adc/ltc2496.c          |  4 ++--
>  drivers/iio/adc/ltc2497.c          |  4 ++--
>  drivers/iio/adc/max1027.c          |  5 ++---
>  drivers/iio/adc/max11100.c         |  3 ++-
>  drivers/iio/adc/max1118.c          |  7 ++-----
>  drivers/iio/adc/max1363.c          | 11 ++++-------
>  drivers/iio/adc/mcp320x.c          |  5 ++---
>  drivers/iio/adc/mcp3422.c          |  6 ++----
>  drivers/iio/adc/sd_adc_modulator.c |  5 +++--
>  drivers/iio/adc/ti-adc081c.c       |  6 ++----
>  drivers/iio/adc/ti-adc0832.c       |  7 ++-----
>  drivers/iio/adc/ti-adc084s021.c    |  3 ++-
>  drivers/iio/adc/ti-adc108s102.c    |  5 ++---
>  drivers/iio/adc/ti-adc128s052.c    |  3 ++-
>  drivers/iio/adc/ti-adc161s626.c    |  3 ++-
>  drivers/iio/adc/ti-tlc4541.c       |  5 ++---
>  22 files changed, 54 insertions(+), 80 deletions(-)
>
> --
> 2.27.0
>


-- 
With Best Regards,
Andy Shevchenko

  parent reply index

Thread overview: 68+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-28 12:36 Jonathan Cameron
2020-06-28 12:36 ` [PATCH 01/23] iio:adc:lpc32xx: Drop of_match_ptr protection Jonathan Cameron
2020-06-30  7:01   ` Andy Shevchenko
2020-07-04 16:49     ` Jonathan Cameron
2020-06-28 12:36 ` [PATCH 02/23] iio:adc:axp20x: Convert from OF to generic fw / device properties Jonathan Cameron
2020-06-28 17:43   ` Andy Shevchenko
2020-06-28 19:16     ` Jonathan Cameron
2020-06-28 12:36 ` [PATCH 03/23] iio:adc:hi8435: Drop unused of_gpio.h header Jonathan Cameron
2020-07-04 16:52   ` Jonathan Cameron
2020-06-28 12:36 ` [PATCH 04/23] iio:adc:hi8435: Drop of_match_ptr protection Jonathan Cameron
2020-07-04 16:53   ` Jonathan Cameron
2020-06-28 12:36 ` [PATCH 05/23] iio:adc:max1363: Drop of_match_ptr and use generic device_get_match_data Jonathan Cameron
2020-07-04 16:54   ` Jonathan Cameron
2020-06-28 12:36 ` [PATCH 06/23] iio:adc:max1027: drop of_match_ptr and CONFIG_OF protections Jonathan Cameron
2020-07-04 16:56   ` Jonathan Cameron
2020-06-28 12:36 ` [PATCH 07/23] iio:adc:ltc2496: Drop of_match_ptr and use mod_devicetable.h Jonathan Cameron
2020-06-28 15:52   ` Uwe Kleine-König
2020-07-04 16:58     ` Jonathan Cameron
2020-06-28 12:36 ` [PATCH 08/23] iio:adc:cpcap-adc: Drop of_match_ptr protection and use device_get_match_data Jonathan Cameron
2020-06-29 15:21   ` Tony Lindgren
2020-07-04 17:00     ` Jonathan Cameron
2020-06-28 12:36 ` [PATCH 09/23] iio:adc:ltc2497 drop of_match_ptr protection Jonathan Cameron
2020-06-28 15:53   ` Uwe Kleine-König
2020-07-04 17:04     ` Jonathan Cameron
2020-06-28 12:36 ` [PATCH 10/23] iio:adc:max11100: Drop of_match_ptr protection / add mod_devicetable.h include Jonathan Cameron
2020-06-29  7:28   ` Jacopo Mondi
2020-07-04 17:19     ` Jonathan Cameron
2020-06-28 12:36 ` [PATCH 11/23] iio:adc:max1118: Drop CONFIG_OF / of_match_ptr protections Jonathan Cameron
2020-07-04 17:20   ` Jonathan Cameron
2020-06-28 12:36 ` [PATCH 12/23] iio:adc:mcp320x: Drop CONFIG_OF and " Jonathan Cameron
2020-07-04 17:21   ` Jonathan Cameron
2020-06-28 12:36 ` [PATCH 13/23] iio:adc:mcp3422: remove " Jonathan Cameron
2020-07-04 17:22   ` Jonathan Cameron
2020-06-28 12:36 ` [PATCH 14/23] iio:adc:sd_adc_modulator: Drop of_match_ptr and tweak includes Jonathan Cameron
2020-07-04 17:24   ` Jonathan Cameron
2020-06-28 12:36 ` [PATCH 15/23] iio:adc:ti-adc081c: Drop of_match_ptr and change to mod_devicetable.h Jonathan Cameron
2020-06-30  7:12   ` Andy Shevchenko
2020-07-04 15:45     ` Jonathan Cameron
2020-07-04 17:26       ` Jonathan Cameron
2020-07-04 18:31         ` Andy Shevchenko
2020-06-28 12:36 ` [PATCH 16/23] iio:adc:ti-adc0832: drop CONFIG_OF and of_match_ptr protections Jonathan Cameron
2020-07-04 17:29   ` Jonathan Cameron
2020-06-28 12:36 ` [PATCH 17/23] iio:adc:ti-adc084s021: drop of_match_ptr protection Jonathan Cameron
2020-07-04 17:30   ` Jonathan Cameron
2020-06-28 12:36 ` [PATCH 18/23] iio:adc:ti-adc108s102: Drop CONFIG_OF and of_match_ptr protections Jonathan Cameron
2020-06-30  7:20   ` Andy Shevchenko
2020-07-04 15:54     ` Jonathan Cameron
2020-07-04 18:16       ` Andy Shevchenko
2020-06-28 12:36 ` [PATCH 19/23] iio:adc:ti-adc128s052: drop of_match_ptr protection Jonathan Cameron
2020-06-30  7:22   ` Andy Shevchenko
2020-07-04 15:58     ` Jonathan Cameron
2020-07-04 18:20       ` Andy Shevchenko
2020-06-28 12:36 ` [PATCH 20/23] iio:adc:ti-adc161s626: Drop " Jonathan Cameron
2020-06-28 19:51   ` Matt Ranostay
2020-07-04 17:31     ` Jonathan Cameron
2020-06-28 12:36 ` [PATCH 21/23] iio:adc:ti-tlc4541: Drop CONFIG_OF and of_match_ptr protections Jonathan Cameron
2020-06-28 23:43   ` Phil Reid
2020-07-04 17:32     ` Jonathan Cameron
2020-06-28 12:36 ` [PATCH 22/23] iio:adc:bcm_iproc: Drop of_match_ptr protection and switch to mod_devicetable.h Jonathan Cameron
2020-06-30  7:25   ` Andy Shevchenko
2020-07-04 15:59     ` Jonathan Cameron
2020-07-04 18:22       ` Andy Shevchenko
2020-06-28 12:36 ` [PATCH 23/23] iio:adc:ingenic: drop of_match_ptr protection and include mod_devicetable.h Jonathan Cameron
2020-07-04 17:33   ` Jonathan Cameron
2020-06-28 17:53 ` Andy Shevchenko [this message]
2020-06-28 19:32   ` [PATCH 00/23] iio:adc more of_match_ptr and similar removal Jonathan Cameron
2020-06-30  7:27 ` Andy Shevchenko
2020-07-04 17:35   ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAHp75VfP69DZqA2rH+RCTWnwrU=sYX98zXuWqVE9K3UTzCOeJQ@mail.gmail.com' \
    --to=andy.shevchenko@gmail.com \
    --cc=Jonathan.Cameron@huawei.com \
    --cc=alexandru.Ardelean@analog.com \
    --cc=jic23@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-IIO Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-iio/0 linux-iio/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-iio linux-iio/ https://lore.kernel.org/linux-iio \
		linux-iio@vger.kernel.org
	public-inbox-index linux-iio

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-iio


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git