From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50A8CC433FB for ; Tue, 21 Jul 2020 18:32:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 301B7206E9 for ; Tue, 21 Jul 2020 18:32:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="IGBKQTQD" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728750AbgGUScX (ORCPT ); Tue, 21 Jul 2020 14:32:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35812 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730262AbgGUScU (ORCPT ); Tue, 21 Jul 2020 14:32:20 -0400 Received: from mail-pj1-x1044.google.com (mail-pj1-x1044.google.com [IPv6:2607:f8b0:4864:20::1044]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 41198C061794 for ; Tue, 21 Jul 2020 11:32:20 -0700 (PDT) Received: by mail-pj1-x1044.google.com with SMTP id gc15so1744981pjb.0 for ; Tue, 21 Jul 2020 11:32:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=VW28mxbLLqZQ5vQi7qNE17zGy07wpw2UPhzFLH5zplc=; b=IGBKQTQDfZ2dLTkMloFuGRGTRKdOJNdjfM5nL2bkRCp4etjHAj2k9cTtVZpE+P0EpR 7Fc1HNRA/yGf1ZuYXNh+bDQt28PeaQBB9eECJnHaEvcrLncLTP5v0hp9miXCG22fJ1Jq LPUgnH2hPWZj1f+Nci2DxDIr66MO4lAAAfYgRhYXbIFnQF4m/qAtKU2sU+L+4cE0F59h q7je4PQ1vga3EEqJPuNwRjUXgRiNzvwbPq6Y+Fl/+IUdpmqmsoZM3tDPI2szMBpD8N1y Mvn5dFYxYRLZEsnFqI1weDW3kGO6z2KDR0+qfbmqms3dGc5ViV6PzufphVLrNdE67coA RiTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=VW28mxbLLqZQ5vQi7qNE17zGy07wpw2UPhzFLH5zplc=; b=KW2wegMLDVKWvYsQwrBAnAh/UfqOrIxVjrxA0gv0aCohBX47nq940CFXOGHadpuD1Z wLRujUw8mCCMglM+rNMPlCDMS+KnILdbaRNhMjGbsmzu741+cD5sw1zjHDFzu2fm8bh2 OOaJQImlOyGyQwZWkop1wsNDMAuuIT3frhvAlo7Dd7a0IQ8/ZhfnFH2DFHcUZ0JAFAes HPSH7s4iXuqTh3jbnFM/O7cKEZ5SgUKoFPq35E35K1qwDA2r4IWKUf8D0E3X4k4u9bim bC5V1Lo15j7+IFu85Mw/zt4cirVEcX7Kwklb8oPr3vDm78ZZUmweleX0SPMQvrHLFBT/ xNpw== X-Gm-Message-State: AOAM5308H041UfNBmQv69EJkXyp4Kv1JY1TeGzMaBhF1t1YEYzdHR5NS K569IVWOmtzjAjBDnn3EEozUNe7ECJSLB3CWPUg= X-Google-Smtp-Source: ABdhPJyXe+72uz5n1kumlRyfOwhoffH8XdX1MS1viWimoFIHUD/SHigjtMBE+4O32tCkm8RVFQRZJzU8BrchWVbfSRc= X-Received: by 2002:a17:90b:3547:: with SMTP id lt7mr6060163pjb.181.1595356339800; Tue, 21 Jul 2020 11:32:19 -0700 (PDT) MIME-Version: 1.0 References: <20200721171444.825099-1-jic23@kernel.org> <20200721171444.825099-5-jic23@kernel.org> In-Reply-To: <20200721171444.825099-5-jic23@kernel.org> From: Andy Shevchenko Date: Tue, 21 Jul 2020 21:32:03 +0300 Message-ID: Subject: Re: [PATCH v2 4/5] iio:adc:ti-adc128s052: drop of_match_ptr protection To: Jonathan Cameron Cc: linux-iio , Jonathan Cameron , Angelo Compagnucci Content-Type: text/plain; charset="UTF-8" Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Tue, Jul 21, 2020 at 8:16 PM Jonathan Cameron wrote: > > From: Jonathan Cameron > > There is no real advantage in having these protections and > for parts that do not have an explicit ACPI ID, it prevents the > use of PRP0001. I'm trying to clear this out of IIO in general > to avoid copying in new drivers. > > Include mod_devicetable.h as we are using of_device_id in here so > including that header is best practice. Reviewed-by: Andy Shevchenko > Signed-off-by: Jonathan Cameron > Cc: Angelo Compagnucci > --- > v1->v2 > * Mention that some parts of valid IDs, so we are interesting in > enabling PRP0001 option for those that don't. > > drivers/iio/adc/ti-adc128s052.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/iio/adc/ti-adc128s052.c b/drivers/iio/adc/ti-adc128s052.c > index e86f55ce093f..3143f35a6509 100644 > --- a/drivers/iio/adc/ti-adc128s052.c > +++ b/drivers/iio/adc/ti-adc128s052.c > @@ -13,6 +13,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -220,7 +221,7 @@ MODULE_DEVICE_TABLE(acpi, adc128_acpi_match); > static struct spi_driver adc128_driver = { > .driver = { > .name = "adc128s052", > - .of_match_table = of_match_ptr(adc128_of_match), > + .of_match_table = adc128_of_match, > .acpi_match_table = ACPI_PTR(adc128_acpi_match), > }, > .probe = adc128_probe, > -- > 2.27.0 > -- With Best Regards, Andy Shevchenko