From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B95F0C2D0E9 for ; Mon, 30 Mar 2020 07:30:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8DFBC20748 for ; Mon, 30 Mar 2020 07:30:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1585553401; bh=w+OyByBV+I5A3BslKozLHEBsFhvZMzyxKsx/Uvrczsg=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=EQiPLDGmuA8GqegzVKGGN6rtPVHd2Xa2XmLRuABE/qyhAWtsActakoSXIcFimGZXu aplrgzw0c/C+bSOzvCgxxrSrfGcGxY88VNVwzEPzEp3V9RbNQ/pumm93BhKbndfbfy OMeFyQzTr/X3/kx6zJqcphxZwriBXdbskb5qUB1g= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729413AbgC3HaB (ORCPT ); Mon, 30 Mar 2020 03:30:01 -0400 Received: from condef-02.nifty.com ([202.248.20.67]:41104 "EHLO condef-02.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729197AbgC3HaA (ORCPT ); Mon, 30 Mar 2020 03:30:00 -0400 X-Greylist: delayed 833 seconds by postgrey-1.27 at vger.kernel.org; Mon, 30 Mar 2020 03:29:58 EDT Received: from conssluserg-01.nifty.com ([10.126.8.80])by condef-02.nifty.com with ESMTP id 02U7AC7C000608; Mon, 30 Mar 2020 16:10:12 +0900 Received: from mail-vs1-f45.google.com (mail-vs1-f45.google.com [209.85.217.45]) (authenticated) by conssluserg-01.nifty.com with ESMTP id 02U79xvR024938; Mon, 30 Mar 2020 16:10:00 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conssluserg-01.nifty.com 02U79xvR024938 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1585552200; bh=ln1CQt+YaUVnJf/8SbMK3iPTVvG1KE5EE/FUul8MWQc=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=1sthGaoHw8qoSp3F/D3eH8NqZjk++zLNoSrFExAge5M5k4o6izC7znUZmDsjrR95d 3LRi45OyZDxUKTfu4A/3P4aV5+yY39DtCxwP5T2nox/GAPp7PJ3ZaF7u226D4E6kMs pxp3tchjSZY1dsGYXfpp7Fyf63ssOrWN+V8tr3iI8kkkZhdSc6hQrcCJehpowCH1tV t5Ybjs0wWAwMh0SzhZruoB9o66WBYJD1t+qP7ZqRNrr7efxFSXjCoLMubpsREjCj3w uh2OG10xugvGzdVuKY1o+FeM5bjbz3bVeCv27FcaCEJ6WsaSLhERu5H58t5BiMZ2Xi G3vbpTZyiHDew== X-Nifty-SrcIP: [209.85.217.45] Received: by mail-vs1-f45.google.com with SMTP id z125so10303326vsb.13; Mon, 30 Mar 2020 00:09:59 -0700 (PDT) X-Gm-Message-State: AGi0PuaxIQ01k2OIzzRmX0pmP4+GKnL2dKkEkaAhViRjVhNEthRWBKXc iLGdsfopkiPxzS20T9vORC2VKBgWqZ276l6JheA= X-Google-Smtp-Source: APiQypLmGnB9GmkGFIr7L8MQtdRTKDMNPR3ere0jKX6O5/r2adqpWFQ5TPcwWpLgYxRGXDf4dZ6YCv27RE8dCFz54+s= X-Received: by 2002:a67:2d55:: with SMTP id t82mr7452280vst.215.1585552198446; Mon, 30 Mar 2020 00:09:58 -0700 (PDT) MIME-Version: 1.0 References: <20200325220542.19189-1-robh@kernel.org> <20200325220542.19189-5-robh@kernel.org> In-Reply-To: <20200325220542.19189-5-robh@kernel.org> From: Masahiro Yamada Date: Mon, 30 Mar 2020 16:09:22 +0900 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 4/4] dt-bindings: Add missing 'additionalProperties: false' To: Rob Herring Cc: DTML , Linux Kernel Mailing List , Bartosz Golaszewski , Bjorn Andersson , Brian Masney , Daniel Lezcano , "David S. Miller" , Guillaume La Roque , Hartmut Knaack , Jonathan Cameron , Kevin Hilman , Lars-Peter Clausen , Lee Jones , Liam Girdwood , Linus Walleij , Mark Brown , Mauro Carvalho Chehab , Michael Hennerich , Neil Armstrong , Peter Meerwald-Stadler , Stephen Boyd , Thomas Gleixner , Zhang Rui , dri-devel , linux-amlogic@lists.infradead.org, linux-arm-kernel , linux-arm-msm , linux-clk , "open list:GPIO SUBSYSTEM" , linux-iio@vger.kernel.org, Linux Media Mailing List , Linux PM mailing list , Networking Content-Type: text/plain; charset="UTF-8" Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Thu, Mar 26, 2020 at 7:06 AM Rob Herring wrote: > > Setting 'additionalProperties: false' is frequently omitted, but is > important in order to check that there aren't extra undocumented > properties in a binding. > > Ideally, we'd just add this automatically and make this the default, but > there's some cases where it doesn't work. For example, if a common > schema is referenced, then properties in the common schema aren't part > of what's considered for 'additionalProperties'. Also, sometimes there > are bus specific properties such as 'spi-max-frequency' that go into > bus child nodes, but aren't defined in the child node's schema. > > So let's stick with the json-schema defined default and add > 'additionalProperties: false' where needed. This will be a continual > review comment and game of wack-a-mole. > > Signed-off-by: Rob Herring > --- > .../devicetree/bindings/gpio/socionext,uniphier-gpio.yaml | 2 ++ You may have already queue this up, but just in case. Acked-by: Masahiro Yamada -- Best Regards Masahiro Yamada