From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4771C47404 for ; Mon, 7 Oct 2019 12:42:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9105F2173B for ; Mon, 7 Oct 2019 12:42:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570452167; bh=QlmGxXN75S6KDpXUeIecyQv5YkpxdOrHAZ4tfkFVv1Y=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=pL5dt/KTC1/pTlrcqYBulV0lxgG3DDD6lC1XQuTFvOPyH7qeE7popSfKGqvDbs21Y aqFcxqmMZUaKhEKXWqQfJ6CTeZLHhhrY4b482KQY/zGTvPFMs1VzywBb917xl2+3RW uJ0Pl1e515Rn0XpKlzkZEy2AuZUebc1+LtB22R2E= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727514AbfJGMmn (ORCPT ); Mon, 7 Oct 2019 08:42:43 -0400 Received: from mail.kernel.org ([198.145.29.99]:41900 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727490AbfJGMmn (ORCPT ); Mon, 7 Oct 2019 08:42:43 -0400 Received: from mail-qt1-f179.google.com (mail-qt1-f179.google.com [209.85.160.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D454921871; Mon, 7 Oct 2019 12:42:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570452162; bh=QlmGxXN75S6KDpXUeIecyQv5YkpxdOrHAZ4tfkFVv1Y=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=sFjDkU5fwAgfAsB2uKtjmiCRkx+xiCc8h2anG7iOYFA/BQP0MtQC85fQvcF9HjkYN kouywKrhqR1d1WeS49TEmwtVwUCsw1OmlED96oFaX2Dg4YpPGvXkqDTVLtgVoubvh7 RkYmxCQvN1nmt4vMNgtCt3SsHmtj7ZSOzdTKgMWc= Received: by mail-qt1-f179.google.com with SMTP id u22so18821813qtq.13; Mon, 07 Oct 2019 05:42:41 -0700 (PDT) X-Gm-Message-State: APjAAAXtIv3ClJtQ53LeDkY9fnJ/jP6Jn9lVtEDs1qqIRCi93dbpyF0Y zy+D3o1cRwuJn90hRM6TL++GC2NF9MLtt1W27w== X-Google-Smtp-Source: APXvYqzgZykjYM+K47WAdfZO6hL3Row4Olz5ZnINVgiZV8PaGcqQNLFCJ5CkCvyGRTvgjU8HbholqiAulEP7V4qx9kw= X-Received: by 2002:ac8:2fe5:: with SMTP id m34mr29115750qta.224.1570452160952; Mon, 07 Oct 2019 05:42:40 -0700 (PDT) MIME-Version: 1.0 References: <20191006142715.45k64cgw7mzlekm5@arbad> In-Reply-To: <20191006142715.45k64cgw7mzlekm5@arbad> From: Rob Herring Date: Mon, 7 Oct 2019 07:42:29 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2] dt-bindings: iio: maxbotix,mb1232.yaml: transform to yaml To: Andreas Klinger Cc: Jonathan Cameron , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald , Mark Rutland , "open list:IIO SUBSYSTEM AND DRIVERS" , devicetree@vger.kernel.org, "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Sun, Oct 6, 2019 at 9:27 AM Andreas Klinger wrote: > > transform existing documentation of maxbotix,mb1232 ultrasonic ranger > from text documentation format into yaml. > > Changes in v2: > - removed description of reg property > - added a line: > additionalProperties: false > > Signed-off-by: Andreas Klinger > --- > .../bindings/iio/proximity/maxbotix,mb1232.txt | 29 ----------- > .../bindings/iio/proximity/maxbotix,mb1232.yaml | 56 ++++++++++++++++++++++ > 2 files changed, 56 insertions(+), 29 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/iio/proximity/maxbotix,mb1232.txt > create mode 100644 Documentation/devicetree/bindings/iio/proximity/maxbotix,mb1232.yaml > > diff --git a/Documentation/devicetree/bindings/iio/proximity/maxbotix,mb1232.txt b/Documentation/devicetree/bindings/iio/proximity/maxbotix,mb1232.txt > deleted file mode 100644 > index dd1058fbe9c3..000000000000 > --- a/Documentation/devicetree/bindings/iio/proximity/maxbotix,mb1232.txt > +++ /dev/null > @@ -1,29 +0,0 @@ > -* MaxBotix I2CXL-MaxSonar ultrasonic distance sensor of type mb1202, > - mb1212, mb1222, mb1232, mb1242, mb7040 or mb7137 using the i2c interface > - for ranging > - > -Required properties: > - - compatible: "maxbotix,mb1202", > - "maxbotix,mb1212", > - "maxbotix,mb1222", > - "maxbotix,mb1232", > - "maxbotix,mb1242", > - "maxbotix,mb7040" or > - "maxbotix,mb7137" > - > - - reg: i2c address of the device, see also i2c/i2c.txt > - > -Optional properties: > - - interrupts: Interrupt used to announce the preceding reading > - request has finished and that data is available. > - If no interrupt is specified the device driver > - falls back to wait a fixed amount of time until > - data can be retrieved. > - > -Example: > -proximity@70 { > - compatible = "maxbotix,mb1232"; > - reg = <0x70>; > - interrupt-parent = <&gpio2>; > - interrupts = <2 IRQ_TYPE_EDGE_FALLING>; > -}; > diff --git a/Documentation/devicetree/bindings/iio/proximity/maxbotix,mb1232.yaml b/Documentation/devicetree/bindings/iio/proximity/maxbotix,mb1232.yaml > new file mode 100644 > index 000000000000..e2fb1f6d4dbe > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/proximity/maxbotix,mb1232.yaml > @@ -0,0 +1,56 @@ > +# SPDX-License-Identifier: GPL-2.0 > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/iio/proximity/maxbotix,mb1232.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: MaxBotix I2CXL-MaxSonar ultrasonic distance sensor > + > +maintainers: > + - Andreas Klinger > + > +description: | > + MaxBotix I2CXL-MaxSonar ultrasonic distance sensor of type mb1202, > + mb1212, mb1222, mb1232, mb1242, mb7040 or mb7137 using the i2c interface > + for ranging > + > + Specifications about the devices can be found at: > + https://www.maxbotix.com/documents/I2CXL-MaxSonar-EZ_Datasheet.pdf > + > +properties: > + compatible: > + enum: > + - maxbotix,mb1202 > + - maxbotix,mb1212 > + - maxbotix,mb1222 > + - maxbotix,mb1232 > + - maxbotix,mb1242 > + - maxbotix,mb7040 > + - maxbotix,mb7137 > + > + reg: > + maxItems: 1 > + > + interrupts: > + description: > + Interrupt used to announce the preceding reading request has finished > + and that data is available. If no interrupt is specified the device > + driver falls back to wait a fixed amount of time until data can be > + retrieved. > + maxItems: 1 > + > +required: > + - compatible > + - reg > + > +additionalProperties: false > + > +examples: > + - | > + #include > + proximity@70 { Fails to build with 'make dt_binding_check': Documentation/devicetree/bindings/iio/proximity/maxbotix,mb1232.example.dts:20.11-24: Warning (reg_format): /example-0/proximity@70:reg: property has invalid length (4 bytes) (#address-cells == 1, #size-cells == 1) Documentation/devicetree/bindings/iio/proximity/maxbotix,mb1232.example.dt.yaml: Warning (pci_device_bus_num): Failed prerequisite 'reg_format' Documentation/devicetree/bindings/iio/proximity/maxbotix,mb1232.example.dt.yaml: Warning (i2c_bus_reg): Failed prerequisite 'reg_format' Documentation/devicetree/bindings/iio/proximity/maxbotix,mb1232.example.dt.yaml: Warning (spi_bus_reg): Failed prerequisite 'reg_format' You have to put this under an i2c bus node. i2c { #address-cells = <1>; #size-cells = <0>; ... }; > + compatible = "maxbotix,mb1232"; > + reg = <0x70>; > + interrupt-parent = <&gpio2>; > + interrupts = <2 IRQ_TYPE_EDGE_FALLING>; > + }; > -- > 2.11.0