From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2353FC10F14 for ; Thu, 10 Oct 2019 13:23:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id ED67821920 for ; Thu, 10 Oct 2019 13:23:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570713836; bh=YLrnV8zZisr0XydXNPW9X6NeAxPAWOsdbyS2yRBi/UY=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=TqV8hPW/1RyP2suNcTeck9mB6icssC07n22sudgnOFFkIWwl2fnJkhu3U9hyT6qhZ /2haxQVU7j+Gh26fzDx/efX7ODUozrFYz//z/NrAcPNKjDwWXmfsZdR4ZPMH/mtn8X 5fJNdP7BsC3N9xJPEpIgfHY/QaAnltrL0yJ/Vs3A= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388013AbfJJNXz (ORCPT ); Thu, 10 Oct 2019 09:23:55 -0400 Received: from mail.kernel.org ([198.145.29.99]:60270 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387828AbfJJNXz (ORCPT ); Thu, 10 Oct 2019 09:23:55 -0400 Received: from mail-qt1-f175.google.com (mail-qt1-f175.google.com [209.85.160.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D88B420650; Thu, 10 Oct 2019 13:23:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570713834; bh=YLrnV8zZisr0XydXNPW9X6NeAxPAWOsdbyS2yRBi/UY=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=xJznIvCT1sLkg8Y6BZ2uO6PgIuEgYNWeo1ONKPp9wMRkn9N8ZzERykXgB9/catV38 ja2o57c3K/CDyziofLNz5IR6Aj0msf16qOQkKWyVJzSTpxLve1S3B1mCVoqePs/LG5 O8Utg+Zsg7DU4gpnEl/XAayKKIJMGtCKey2Ymj0s= Received: by mail-qt1-f175.google.com with SMTP id j31so8664596qta.5; Thu, 10 Oct 2019 06:23:53 -0700 (PDT) X-Gm-Message-State: APjAAAXuyb9gBvwtsiV/yGaFdltDCeqetHhgoUE6nnoXctYRO1Wzogii HgCwm+Edd0VgKdqOzbbbXg3mxQ3H1yAyJswgFw== X-Google-Smtp-Source: APXvYqz2PhZiSPi7UGKHnDHJKGkm9997P6Ft0wR/2lKwzfkipGeeDrItJgltFybrUjKdVzL9R9XcBym/c95uuZWFz+s= X-Received: by 2002:ad4:5044:: with SMTP id m4mr10089713qvq.85.1570713832995; Thu, 10 Oct 2019 06:23:52 -0700 (PDT) MIME-Version: 1.0 References: <20190918012856.18963-1-rjones@gateworks.com> <20191010012523.14426-1-rjones@gateworks.com> <20191010012523.14426-2-rjones@gateworks.com> In-Reply-To: <20191010012523.14426-2-rjones@gateworks.com> From: Rob Herring Date: Thu, 10 Oct 2019 08:23:41 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 1/2] dt-bindings: iio: imu: add fxos8700 imu binding To: Robert Jones Cc: Jonathan Cameron , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , Mark Rutland , "open list:IIO SUBSYSTEM AND DRIVERS" , devicetree@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Wed, Oct 9, 2019 at 8:25 PM Robert Jones wrote: > > This adds documentation for the Freescale FXOS8700 Inertial Measurement Unit > device-tree bindings. > > Signed-off-by: Robert Jones > --- > .../devicetree/bindings/iio/imu/fxos8700.yaml | 54 ++++++++++++++++++++++ Follow the compatible string name, so fsl,fxos8700.yaml. > 1 file changed, 54 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/imu/fxos8700.yaml > > diff --git a/Documentation/devicetree/bindings/iio/imu/fxos8700.yaml b/Documentation/devicetree/bindings/iio/imu/fxos8700.yaml > new file mode 100644 > index 0000000..f0dbf4b > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/imu/fxos8700.yaml > @@ -0,0 +1,54 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/iio/imu/fxos8700.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Freescale FXOS8700 Inertial Measurement Unit > + > +maintainers: > + - Robert Jones > + > +description: | > + Accelerometer and magnetometer combo device with an i2c interface. Also has a SPI interface. > + https://www.nxp.com/products/sensors/motion-sensors/6-axis/digital-motion-sensor-3d-accelerometer-2g-4g-8g-plus-3d-magnetometer:FXOS8700CQ > + > +properties: > + compatible: > + enum: > + - fsl,fxos8700 For a new binding, shouldn't this be nxp instead of fsl? > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + interrupt-names: > + maxItems: 1 'const: INT1' instead. However, having '-names' doesn't really buy much when there is only 1 entry, so I'd just drop it. But then I read the datasheet and there are 2 interrupts, so you need to describe 2 interrupts. > + > + drive-open-drain: > + maxItems: 1 Should be boolean. > + > + spi-max-frequency: > + maxItems: 1 spi-max-frequency is not an array. You should define the maximum for it. > + > +required: > + - compatible > + - reg > + > +examples: > + - | > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + > + fxos8700@1e { > + compatible = "fsl,fxos8700"; > + reg = <0x1e>; > + > + interrupt-parent = <&gpio2>; > + interrupts = <7 IRQ_TYPE_EDGE_RISING>; > + interrupt-names = "INT1"; > + }; > + }; > -- > 2.9.2 >