From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,T_DKIMWL_WL_HIGH autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88194C31E44 for ; Tue, 11 Jun 2019 22:00:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 59913205ED for ; Tue, 11 Jun 2019 22:00:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1560290445; bh=6wt58freXYakzLC3l+w1fNDxCWBRmdHXoj+rBGdpgUo=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=Q9qSp2uZCcF5GBJV4ZRA2n4T6rIFRshSknltAGswADldu5uUWXIFOg7dX42D0y59W PNxUcAPY0lsmu+ol3wjAZJDBbXXJegqKCmn6dqpLfUVnSAHm+8yTcYHbcpnJxj+4F6 91ZbD6mv7pPV3cMtUVJPA2AgfXEaPvWnDgUUuHSQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2407775AbfFKWAo (ORCPT ); Tue, 11 Jun 2019 18:00:44 -0400 Received: from mail.kernel.org ([198.145.29.99]:42708 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2407758AbfFKWAo (ORCPT ); Tue, 11 Jun 2019 18:00:44 -0400 Received: from mail-qk1-f177.google.com (mail-qk1-f177.google.com [209.85.222.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id EBE2820866; Tue, 11 Jun 2019 22:00:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1560290443; bh=6wt58freXYakzLC3l+w1fNDxCWBRmdHXoj+rBGdpgUo=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=WwSPphCrIfjN8xr2FGpl9TwUkiKTORJSYOiN1Ar7DBUCd/sN5obikBSc9h7F+f+IN 8uFvcPjF9URXIAWJMWCwfWR5rEMwzmhg2y4HxlHOh36q4n6ofjtkgTgKgGR42+ZL2S m6Q1P9S6eUi8b0/v43UamaEJZKg0cKD8RKupnZx8= Received: by mail-qk1-f177.google.com with SMTP id l128so8712184qke.2; Tue, 11 Jun 2019 15:00:42 -0700 (PDT) X-Gm-Message-State: APjAAAW3BW87NuwCBb4m5fBoRR1W1opKlgIoheHwUqhB4kJIL5y1Vdqc Xcd1ghuy7EW/bgWV8TaW7Q6FOqfLMrR+hFxVaA== X-Google-Smtp-Source: APXvYqxAosGlT5kLbEYc7A8eFkXTwEsqIRmfJhcEbutAwwqMxG2UXqT+bffMX7rQ3up6XhxfhUajYaqFMZeSV3XzK9k= X-Received: by 2002:a05:620a:5b1:: with SMTP id q17mr60654324qkq.174.1560290442211; Tue, 11 Jun 2019 15:00:42 -0700 (PDT) MIME-Version: 1.0 References: <1559653697-2760-1-git-send-email-stefan.popa@analog.com> <20190611215932.GA24974@bogus> In-Reply-To: <20190611215932.GA24974@bogus> From: Rob Herring Date: Tue, 11 Jun 2019 16:00:31 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v5 2/2] dt-bindings: iio: frequency: Add docs for ADF4371 PLL To: Stefan Popa Cc: Jonathan Cameron , Mark Rutland , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald , Michael Hennerich , Greg Kroah-Hartman , "open list:IIO SUBSYSTEM AND DRIVERS" , devicetree@vger.kernel.org, "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Tue, Jun 11, 2019 at 3:59 PM Rob Herring wrote: > > On Tue, Jun 04, 2019 at 04:08:17PM +0300, Stefan Popa wrote: > > Document support for Analog Devices ADF4371 SPI Wideband Synthesizer. > > > > Signed-off-by: Stefan Popa > > --- > > Changes in v2: > > - Nothing changed. > > Changes in v3: > > - Nothing changed. > > Changes in v4: > > - Nothing changed. > > Changes in v5: > > - Nothing changed. > > Please add acks/reviewed-bys when posting new versions. > > But something else I noticed: > > > > > .../devicetree/bindings/iio/frequency/adf4371.yaml | 54 ++++++++++++++++++++++ > > 1 file changed, 54 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/iio/frequency/adf4371.yaml > > > > diff --git a/Documentation/devicetree/bindings/iio/frequency/adf4371.yaml b/Documentation/devicetree/bindings/iio/frequency/adf4371.yaml > > new file mode 100644 > > index 0000000..d7adf074 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/iio/frequency/adf4371.yaml > > @@ -0,0 +1,54 @@ > > +# SPDX-License-Identifier: GPL-2.0 > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/iio/frequency/adf4371.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Analog Devices ADF4371 Wideband Synthesizer > > + > > +maintainers: > > + - Popa Stefan > > + > > +description: | > > + Analog Devices ADF4371 SPI Wideband Synthesizer > > + https://www.analog.com/media/en/technical-documentation/data-sheets/adf4371.pdf > > + > > +properties: > > + compatible: > > + enum: > > + - adi,adf4371 > > + > > + reg: > > + maxItems: 1 > > + > > + clocks: > > + description: > > + Definition of the external clock (see clock/clock-bindings.txt) > > + maxItems: 1 > > + > > + clock-names: > > + description: > > + Must be "clkin" > > This can be a schema: > > clock-names: > items: > - clkin And with that, you can keep my R-by. Rob