Linux-IIO Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH v2] iio: light: vcnl4035 add i2c_device_id
@ 2020-10-18  3:36 Vaishnav M A
  2020-10-18 11:36 ` Jonathan Cameron
  0 siblings, 1 reply; 3+ messages in thread
From: Vaishnav M A @ 2020-10-18  3:36 UTC (permalink / raw)
  To: jic23, knaack.h, lars, pmeerw, alexandru.ardelean, linux-iio,
	linux-kernel
  Cc: jkridner, drew, robertcnelson, rajkovic, vaishnav

add i2c_device_id for the vcnl4035 driver so that
the device can be instantiated using i2c_new_client_device
or from userspace, useful in cases where device tree based
description is not possible now(Eg. a device on a gbphy i2c
adapter created by greybus)

Signed-off-by: Vaishnav M A <vaishnav@beagleboard.org>
---
 v2:
	- fix commit message
 drivers/iio/light/vcnl4035.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/drivers/iio/light/vcnl4035.c b/drivers/iio/light/vcnl4035.c
index 765c44adac57..73a28e30dddc 100644
--- a/drivers/iio/light/vcnl4035.c
+++ b/drivers/iio/light/vcnl4035.c
@@ -652,6 +652,12 @@ static const struct dev_pm_ops vcnl4035_pm_ops = {
 			   vcnl4035_runtime_resume, NULL)
 };
 
+static const struct i2c_device_id vcnl4035_id[] = {
+	{ "vcnl4035", 0},
+	{ }
+};
+MODULE_DEVICE_TABLE(i2c, vcnl4035_id);
+
 static const struct of_device_id vcnl4035_of_match[] = {
 	{ .compatible = "vishay,vcnl4035", },
 	{ }
@@ -666,6 +672,7 @@ static struct i2c_driver vcnl4035_driver = {
 	},
 	.probe  = vcnl4035_probe,
 	.remove	= vcnl4035_remove,
+	.id_table = vcnl4035_id,
 };
 
 module_i2c_driver(vcnl4035_driver);
-- 
2.25.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] iio: light: vcnl4035 add i2c_device_id
  2020-10-18  3:36 [PATCH v2] iio: light: vcnl4035 add i2c_device_id Vaishnav M A
@ 2020-10-18 11:36 ` Jonathan Cameron
  2020-10-18 15:06   ` Vaishnav M A
  0 siblings, 1 reply; 3+ messages in thread
From: Jonathan Cameron @ 2020-10-18 11:36 UTC (permalink / raw)
  To: Vaishnav M A
  Cc: knaack.h, lars, pmeerw, alexandru.ardelean, linux-iio,
	linux-kernel, jkridner, drew, robertcnelson, rajkovic

On Sun, 18 Oct 2020 09:06:02 +0530
Vaishnav M A <vaishnav@beagleboard.org> wrote:

> add i2c_device_id for the vcnl4035 driver so that
> the device can be instantiated using i2c_new_client_device
> or from userspace, useful in cases where device tree based
> description is not possible now(Eg. a device on a gbphy i2c
> adapter created by greybus)
> 
> Signed-off-by: Vaishnav M A <vaishnav@beagleboard.org>
Rewrite the description and this should be fine.

Thanks,

Jonathan

> ---
>  v2:
> 	- fix commit message
>  drivers/iio/light/vcnl4035.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/iio/light/vcnl4035.c b/drivers/iio/light/vcnl4035.c
> index 765c44adac57..73a28e30dddc 100644
> --- a/drivers/iio/light/vcnl4035.c
> +++ b/drivers/iio/light/vcnl4035.c
> @@ -652,6 +652,12 @@ static const struct dev_pm_ops vcnl4035_pm_ops = {
>  			   vcnl4035_runtime_resume, NULL)
>  };
>  
> +static const struct i2c_device_id vcnl4035_id[] = {
> +	{ "vcnl4035", 0},
> +	{ }
> +};
> +MODULE_DEVICE_TABLE(i2c, vcnl4035_id);
> +
>  static const struct of_device_id vcnl4035_of_match[] = {
>  	{ .compatible = "vishay,vcnl4035", },
>  	{ }
> @@ -666,6 +672,7 @@ static struct i2c_driver vcnl4035_driver = {
>  	},
>  	.probe  = vcnl4035_probe,
>  	.remove	= vcnl4035_remove,
> +	.id_table = vcnl4035_id,
>  };
>  
>  module_i2c_driver(vcnl4035_driver);


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] iio: light: vcnl4035 add i2c_device_id
  2020-10-18 11:36 ` Jonathan Cameron
@ 2020-10-18 15:06   ` Vaishnav M A
  0 siblings, 0 replies; 3+ messages in thread
From: Vaishnav M A @ 2020-10-18 15:06 UTC (permalink / raw)
  To: Jonathan Cameron
  Cc: Hartmut Knaack, Lars-Peter Clausen, Peter Meerwald-Stadler,
	Alexandru Ardelean, open list:IIO SUBSYSTEM AND DRIVERS,
	open list, Jason Kridner, Drew Fustini, Robert Nelson,
	Ivan Rajković

On Sun, Oct 18, 2020 at 5:06 PM Jonathan Cameron <jic23@kernel.org> wrote:
>
> On Sun, 18 Oct 2020 09:06:02 +0530
> Vaishnav M A <vaishnav@beagleboard.org> wrote:
>
> > add i2c_device_id for the vcnl4035 driver so that
> > the device can be instantiated using i2c_new_client_device
> > or from userspace, useful in cases where device tree based
> > description is not possible now(Eg. a device on a gbphy i2c
> > adapter created by greybus)
> >
> > Signed-off-by: Vaishnav M A <vaishnav@beagleboard.org>
> Rewrite the description and this should be fine.
>
> Thanks,
>
> Jonathan
>
Thank you Jonathan for the Review, I have submitted v3 patch
with the modified description: https://lore.kernel.org/patchwork/patch/1322195/

Thanks,
Vaishnav
> > ---
> >  v2:
> >       - fix commit message
> >  drivers/iio/light/vcnl4035.c | 7 +++++++
> >  1 file changed, 7 insertions(+)
> >
> > diff --git a/drivers/iio/light/vcnl4035.c b/drivers/iio/light/vcnl4035.c
> > index 765c44adac57..73a28e30dddc 100644
> > --- a/drivers/iio/light/vcnl4035.c
> > +++ b/drivers/iio/light/vcnl4035.c
> > @@ -652,6 +652,12 @@ static const struct dev_pm_ops vcnl4035_pm_ops = {
> >                          vcnl4035_runtime_resume, NULL)
> >  };
> >
> > +static const struct i2c_device_id vcnl4035_id[] = {
> > +     { "vcnl4035", 0},
> > +     { }
> > +};
> > +MODULE_DEVICE_TABLE(i2c, vcnl4035_id);
> > +
> >  static const struct of_device_id vcnl4035_of_match[] = {
> >       { .compatible = "vishay,vcnl4035", },
> >       { }
> > @@ -666,6 +672,7 @@ static struct i2c_driver vcnl4035_driver = {
> >       },
> >       .probe  = vcnl4035_probe,
> >       .remove = vcnl4035_remove,
> > +     .id_table = vcnl4035_id,
> >  };
> >
> >  module_i2c_driver(vcnl4035_driver);
>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-18  3:36 [PATCH v2] iio: light: vcnl4035 add i2c_device_id Vaishnav M A
2020-10-18 11:36 ` Jonathan Cameron
2020-10-18 15:06   ` Vaishnav M A

Linux-IIO Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-iio/0 linux-iio/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-iio linux-iio/ https://lore.kernel.org/linux-iio \
		linux-iio@vger.kernel.org
	public-inbox-index linux-iio

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-iio


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git