Linux-IIO Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH v3] iio: proximity: vl53l0x-i2c add i2c_device_id
@ 2020-10-18 15:17 Vaishnav M A
  2020-10-18 18:30 ` Andy Shevchenko
  0 siblings, 1 reply; 3+ messages in thread
From: Vaishnav M A @ 2020-10-18 15:17 UTC (permalink / raw)
  To: jic23, wsa, songqiang1304521, knaack.h, lars, alexandru.ardelean,
	matt.ranostay, linux-iio, linux-kernel
  Cc: jkridner, drew, robertcnelson, rajkovic, vaishnav

Add i2c_device_id table for the vl53l0x-i2c driver,
helps in device instantiation using i2c_new_client_device
or from userspace in cases where device-tree based description
is not possible now (Example: device on a gbphy i2c adapter
created by greybus)

Signed-off-by: Vaishnav M A <vaishnav@beagleboard.org>
---
 v3:
	-modify commit message for readability
	 as suggested by Jonathan Cameron
 v2:
	-fix commit message
 drivers/iio/proximity/vl53l0x-i2c.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/drivers/iio/proximity/vl53l0x-i2c.c b/drivers/iio/proximity/vl53l0x-i2c.c
index 5fbda9475ba9..7c29d4cae24a 100644
--- a/drivers/iio/proximity/vl53l0x-i2c.c
+++ b/drivers/iio/proximity/vl53l0x-i2c.c
@@ -143,6 +143,12 @@ static int vl53l0x_probe(struct i2c_client *client)
 	return devm_iio_device_register(&client->dev, indio_dev);
 }
 
+static const struct i2c_device_id vl53l0x_id[] = {
+	{ "vl53l0x", 0},
+	{ }
+};
+MODULE_DEVICE_TABLE(i2c, vl53l0x_id);
+
 static const struct of_device_id st_vl53l0x_dt_match[] = {
 	{ .compatible = "st,vl53l0x", },
 	{ }
@@ -155,6 +161,7 @@ static struct i2c_driver vl53l0x_driver = {
 		.of_match_table = st_vl53l0x_dt_match,
 	},
 	.probe_new = vl53l0x_probe,
+	.id_table = vl53l0x_id,
 };
 module_i2c_driver(vl53l0x_driver);
 
-- 
2.25.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v3] iio: proximity: vl53l0x-i2c add i2c_device_id
  2020-10-18 15:17 [PATCH v3] iio: proximity: vl53l0x-i2c add i2c_device_id Vaishnav M A
@ 2020-10-18 18:30 ` Andy Shevchenko
  2020-10-18 20:06   ` Vaishnav M A
  0 siblings, 1 reply; 3+ messages in thread
From: Andy Shevchenko @ 2020-10-18 18:30 UTC (permalink / raw)
  To: Vaishnav M A
  Cc: Jonathan Cameron, Wolfram Sang, Song Qiang, Hartmut Knaack,
	Lars-Peter Clausen, Alexandru Ardelean, Matt Ranostay, linux-iio,
	Linux Kernel Mailing List, Jason Kridner, Drew Fustini,
	robertcnelson, rajkovic

On Sun, Oct 18, 2020 at 6:53 PM Vaishnav M A <vaishnav@beagleboard.org> wrote:
>
> Add i2c_device_id table for the vl53l0x-i2c driver,
> helps in device instantiation using i2c_new_client_device
> or from userspace in cases where device-tree based description
> is not possible now (Example: device on a gbphy i2c adapter
> created by greybus)

Same comments as per v1.

-- 
With Best Regards,
Andy Shevchenko

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v3] iio: proximity: vl53l0x-i2c add i2c_device_id
  2020-10-18 18:30 ` Andy Shevchenko
@ 2020-10-18 20:06   ` Vaishnav M A
  0 siblings, 0 replies; 3+ messages in thread
From: Vaishnav M A @ 2020-10-18 20:06 UTC (permalink / raw)
  To: Andy Shevchenko
  Cc: Jonathan Cameron, Wolfram Sang, Song Qiang, Hartmut Knaack,
	Lars-Peter Clausen, Alexandru Ardelean, Matt Ranostay, linux-iio,
	Linux Kernel Mailing List, Jason Kridner, Drew Fustini,
	Robert Nelson, Ivan Rajković

On Mon, Oct 19, 2020 at 12:00 AM Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
>
> On Sun, Oct 18, 2020 at 6:53 PM Vaishnav M A <vaishnav@beagleboard.org> wrote:
> >
> > Add i2c_device_id table for the vl53l0x-i2c driver,
> > helps in device instantiation using i2c_new_client_device
> > or from userspace in cases where device-tree based description
> > is not possible now (Example: device on a gbphy i2c adapter
> > created by greybus)
>
> Same comments as per v1.
>
> --
> With Best Regards,
> Andy Shevchenko

Thank you Andy for your review, I have updated v4 patch with your
suggestions : https://lore.kernel.org/patchwork/patch/1322218/

Thanks,
Vaishnav

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-18 15:17 [PATCH v3] iio: proximity: vl53l0x-i2c add i2c_device_id Vaishnav M A
2020-10-18 18:30 ` Andy Shevchenko
2020-10-18 20:06   ` Vaishnav M A

Linux-IIO Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-iio/0 linux-iio/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-iio linux-iio/ https://lore.kernel.org/linux-iio \
		linux-iio@vger.kernel.org
	public-inbox-index linux-iio

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-iio


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git