* [PATCH] iio: dac: lpc18xx: Use devm_platform_ioremap_resource
@ 2019-10-13 17:14 jic23
2019-11-04 15:16 ` Ardelean, Alexandru
0 siblings, 1 reply; 3+ messages in thread
From: jic23 @ 2019-10-13 17:14 UTC (permalink / raw)
To: linux-iio; +Cc: Jonathan Cameron, Joachim Eastwood
From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Reduce boilerplate.
Suggested by coccinelle
CHECK drivers/iio/dac/lpc18xx_dac.c
drivers/iio/dac/lpc18xx_dac.c:121:1-10: WARNING: Use devm_platform_ioremap_resource for dac -> base
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
CC: Joachim Eastwood <manabian@gmail.com>
---
drivers/iio/dac/lpc18xx_dac.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/iio/dac/lpc18xx_dac.c b/drivers/iio/dac/lpc18xx_dac.c
index 883e84e96609..0ab357bd3633 100644
--- a/drivers/iio/dac/lpc18xx_dac.c
+++ b/drivers/iio/dac/lpc18xx_dac.c
@@ -106,7 +106,6 @@ static int lpc18xx_dac_probe(struct platform_device *pdev)
{
struct iio_dev *indio_dev;
struct lpc18xx_dac *dac;
- struct resource *res;
int ret;
indio_dev = devm_iio_device_alloc(&pdev->dev, sizeof(*dac));
@@ -117,8 +116,7 @@ static int lpc18xx_dac_probe(struct platform_device *pdev)
dac = iio_priv(indio_dev);
mutex_init(&dac->lock);
- res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- dac->base = devm_ioremap_resource(&pdev->dev, res);
+ dac->base = devm_platform_ioremap_resource(pdev, 0);
if (IS_ERR(dac->base))
return PTR_ERR(dac->base);
--
2.23.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] iio: dac: lpc18xx: Use devm_platform_ioremap_resource
2019-10-13 17:14 [PATCH] iio: dac: lpc18xx: Use devm_platform_ioremap_resource jic23
@ 2019-11-04 15:16 ` Ardelean, Alexandru
2019-11-09 12:30 ` Jonathan Cameron
0 siblings, 1 reply; 3+ messages in thread
From: Ardelean, Alexandru @ 2019-11-04 15:16 UTC (permalink / raw)
To: jic23, linux-iio; +Cc: manabian, Jonathan.Cameron
On Sun, 2019-10-13 at 18:14 +0100, jic23@kernel.org wrote:
> From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
>
> Reduce boilerplate.
> Suggested by coccinelle
> CHECK drivers/iio/dac/lpc18xx_dac.c
> drivers/iio/dac/lpc18xx_dac.c:121:1-10: WARNING: Use
> devm_platform_ioremap_resource for dac -> base
>
Reviewed-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> CC: Joachim Eastwood <manabian@gmail.com>
> ---
> drivers/iio/dac/lpc18xx_dac.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/iio/dac/lpc18xx_dac.c
> b/drivers/iio/dac/lpc18xx_dac.c
> index 883e84e96609..0ab357bd3633 100644
> --- a/drivers/iio/dac/lpc18xx_dac.c
> +++ b/drivers/iio/dac/lpc18xx_dac.c
> @@ -106,7 +106,6 @@ static int lpc18xx_dac_probe(struct platform_device
> *pdev)
> {
> struct iio_dev *indio_dev;
> struct lpc18xx_dac *dac;
> - struct resource *res;
> int ret;
>
> indio_dev = devm_iio_device_alloc(&pdev->dev, sizeof(*dac));
> @@ -117,8 +116,7 @@ static int lpc18xx_dac_probe(struct platform_device
> *pdev)
> dac = iio_priv(indio_dev);
> mutex_init(&dac->lock);
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - dac->base = devm_ioremap_resource(&pdev->dev, res);
> + dac->base = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(dac->base))
> return PTR_ERR(dac->base);
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] iio: dac: lpc18xx: Use devm_platform_ioremap_resource
2019-11-04 15:16 ` Ardelean, Alexandru
@ 2019-11-09 12:30 ` Jonathan Cameron
0 siblings, 0 replies; 3+ messages in thread
From: Jonathan Cameron @ 2019-11-09 12:30 UTC (permalink / raw)
To: Ardelean, Alexandru; +Cc: linux-iio, manabian, Jonathan.Cameron
On Mon, 4 Nov 2019 15:16:44 +0000
"Ardelean, Alexandru" <alexandru.Ardelean@analog.com> wrote:
> On Sun, 2019-10-13 at 18:14 +0100, jic23@kernel.org wrote:
> > From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> >
> > Reduce boilerplate.
> > Suggested by coccinelle
> > CHECK drivers/iio/dac/lpc18xx_dac.c
> > drivers/iio/dac/lpc18xx_dac.c:121:1-10: WARNING: Use
> > devm_platform_ioremap_resource for dac -> base
> >
>
> Reviewed-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
>
Applied,
Thanks,
J
> > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> > CC: Joachim Eastwood <manabian@gmail.com>
> > ---
> > drivers/iio/dac/lpc18xx_dac.c | 4 +---
> > 1 file changed, 1 insertion(+), 3 deletions(-)
> >
> > diff --git a/drivers/iio/dac/lpc18xx_dac.c
> > b/drivers/iio/dac/lpc18xx_dac.c
> > index 883e84e96609..0ab357bd3633 100644
> > --- a/drivers/iio/dac/lpc18xx_dac.c
> > +++ b/drivers/iio/dac/lpc18xx_dac.c
> > @@ -106,7 +106,6 @@ static int lpc18xx_dac_probe(struct platform_device
> > *pdev)
> > {
> > struct iio_dev *indio_dev;
> > struct lpc18xx_dac *dac;
> > - struct resource *res;
> > int ret;
> >
> > indio_dev = devm_iio_device_alloc(&pdev->dev, sizeof(*dac));
> > @@ -117,8 +116,7 @@ static int lpc18xx_dac_probe(struct platform_device
> > *pdev)
> > dac = iio_priv(indio_dev);
> > mutex_init(&dac->lock);
> >
> > - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> > - dac->base = devm_ioremap_resource(&pdev->dev, res);
> > + dac->base = devm_platform_ioremap_resource(pdev, 0);
> > if (IS_ERR(dac->base))
> > return PTR_ERR(dac->base);
> >
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-11-09 12:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-13 17:14 [PATCH] iio: dac: lpc18xx: Use devm_platform_ioremap_resource jic23
2019-11-04 15:16 ` Ardelean, Alexandru
2019-11-09 12:30 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).