From: Hans de Goede <hdegoede@redhat.com>
To: Wen-chien Jesse Sung <jesse.sung@canonical.com>,
linux-iio@vger.kernel.org
Subject: Re: [PATCH] iio: st_sensors: remap SMO8840 to LIS2DH12
Date: Mon, 24 Feb 2020 20:23:28 +0100 [thread overview]
Message-ID: <a4f690f2-19a5-fc67-8072-eb14b8df0017@redhat.com> (raw)
In-Reply-To: <20200224095426.25681-1-jesse.sung@canonical.com>
Hi,
On 2/24/20 10:54 AM, Wen-chien Jesse Sung wrote:
> According to ST, the HID is for LIS2DH12.
>
> Signed-off-by: Wen-chien Jesse Sung <jesse.sung@canonical.com>
I added the original "SMO8840" entry since I did not have any
docs I just copied the "SMO8A90" entry. Looking at the driver
the only difference seems to be that the LNG2DM only has 8 bits
accuracy where as the LIS2DH12 has 12 bits. I can confirm that
this patch works on my Lenovo Ideapad Miix 320, for which the
original patch was submitted, and that I indeed get 12 bits of
accuracy with this patch.
So this patch is:
Tested-by: Hans de Goede <hdegoede@redhat.com>
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Regards,
Hans
> ---
> drivers/iio/accel/st_accel_i2c.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/accel/st_accel_i2c.c b/drivers/iio/accel/st_accel_i2c.c
> index 633955d764cc..849cf74153c4 100644
> --- a/drivers/iio/accel/st_accel_i2c.c
> +++ b/drivers/iio/accel/st_accel_i2c.c
> @@ -110,7 +110,7 @@ MODULE_DEVICE_TABLE(of, st_accel_of_match);
>
> #ifdef CONFIG_ACPI
> static const struct acpi_device_id st_accel_acpi_match[] = {
> - {"SMO8840", (kernel_ulong_t)LNG2DM_ACCEL_DEV_NAME},
> + {"SMO8840", (kernel_ulong_t)LIS2DH12_ACCEL_DEV_NAME},
> {"SMO8A90", (kernel_ulong_t)LNG2DM_ACCEL_DEV_NAME},
> { },
> };
>
next prev parent reply other threads:[~2020-02-24 19:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-24 9:54 [PATCH] iio: st_sensors: remap SMO8840 to LIS2DH12 Wen-chien Jesse Sung
2020-02-24 19:23 ` Hans de Goede [this message]
2020-03-01 14:22 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a4f690f2-19a5-fc67-8072-eb14b8df0017@redhat.com \
--to=hdegoede@redhat.com \
--cc=jesse.sung@canonical.com \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).