From: Martin Kelly <martin@martingkelly.com>
To: Rob Herring <robh@kernel.org>
Cc: linux-iio@vger.kernel.org, Jonathan Cameron <jic23@kernel.org>,
Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Daniel Baluta <daniel.baluta@gmail.com>,
devicetree@vger.kernel.org
Subject: Re: [PATCH v3 4/6] dt-bindings: document open-drain property
Date: Wed, 30 Jan 2019 19:02:54 -0800 [thread overview]
Message-ID: <a58bfea9-9570-53ab-2811-05c1519952fb@martingkelly.com> (raw)
In-Reply-To: <20190130165723.GA22934@bogus>
On 1/30/19 8:57 AM, Rob Herring wrote:
> On Sun, Jan 27, 2019 at 12:39:09PM -0800, Martin Kelly wrote:
>> From: Martin Kelly <martin@martingkelly.com>
>>
>> We have added an optional boolean property for configuring a BMI160
>> interrupt pin as open-drain, as opposed to the default push-pull, so
>> document this.
>>
>> Signed-off-by: Martin Kelly <martin@martingkelly.com>
>> ---
>> Documentation/devicetree/bindings/iio/imu/bmi160.txt | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/iio/imu/bmi160.txt b/Documentation/devicetree/bindings/iio/imu/bmi160.txt
>> index 1aec19997fb5..7eb4b6016404 100644
>> --- a/Documentation/devicetree/bindings/iio/imu/bmi160.txt
>> +++ b/Documentation/devicetree/bindings/iio/imu/bmi160.txt
>> @@ -12,6 +12,8 @@ Optional properties:
>> - interrupts : interrupt mapping for IRQ
>> - interrupt-names : set to "INT1" if INT1 pin should be used as interrupt
>> input, set to "INT2" if INT2 pin should be used instead
>> +- bmi160,open-drain : set if the specified interrupt pin should be configured as
>> + open drain. If not set, defaults to push-pull.
>
> Use 'drive-open-drain' like others.
>
OK, I'll do this in the next revision.
>>
>> Examples:
>>
>> --
>> 2.11.0
>>
next prev parent reply other threads:[~2019-01-31 3:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-27 20:39 [PATCH v3 0/6] iio:bmi160: add drdy interrupt support Martin Kelly
2019-01-27 20:39 ` [PATCH v3 1/6] iio:bmi160: add SPDX identifiers Martin Kelly
2019-01-27 20:39 ` [PATCH v3 2/6] iio:bmi160: add drdy interrupt support Martin Kelly
2019-01-27 20:39 ` [PATCH v3 3/6] dt-bindings: fix incorrect bmi160 IRQ note Martin Kelly
2019-01-30 16:56 ` Rob Herring
2019-01-27 20:39 ` [PATCH v3 4/6] dt-bindings: document open-drain property Martin Kelly
2019-01-30 16:57 ` Rob Herring
2019-01-31 3:02 ` Martin Kelly [this message]
2019-01-27 20:39 ` [PATCH v3 5/6] iio:bmi160: use iio_pollfunc_store_time Martin Kelly
2019-01-27 20:39 ` [PATCH v3 6/6] iio:bmi160: use if (ret) instead of if (ret < 0) Martin Kelly
2019-02-02 9:46 ` [PATCH v3 0/6] iio:bmi160: add drdy interrupt support Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a58bfea9-9570-53ab-2811-05c1519952fb@martingkelly.com \
--to=martin@martingkelly.com \
--cc=daniel.baluta@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).