From: Matthias Brugger <matthias.bgg@gmail.com>
To: Fabien Parent <fparent@baylibre.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
DTML <devicetree@vger.kernel.org>,
linux-iio@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
pmeerw@pmeerw.net, lars@metafoo.de, knaack.h@gmx.de,
jic23@kernel.org
Subject: Re: [PATCH 2/2] arm64: dts: mediatek: mt8516: add auxadc node
Date: Tue, 13 Oct 2020 17:29:08 +0200 [thread overview]
Message-ID: <ab900e0f-fd5f-a1cc-8300-b681c97f7231@gmail.com> (raw)
In-Reply-To: <CAOwMV_yqK+yLZH1tOSeUHP7qz35k-bYmWf7jg6qQpvhO9LeJ6g@mail.gmail.com>
On 13/10/2020 11:06, Fabien Parent wrote:
> Hi Matthias,
>
>> Any reason you don't enable the status in the pumpkin dts?
>
> No particular reasons. I looked at what other MTK SoC did for this IP,
> and half went with the status to be disabled and the other half went
> with an enabled status. So I went the mt8183 way since it is the last
> MTK SoC to have been merged and disabled by default. If you think it
> is better to be enabled by default, I can change it, I don't have any
> strong opinion about this.
>
Well on mt8183 it is missing the thermal driver although as you can read the
values via sysfs I'd say to enable it. No need to resend just because of that.
I'll take the patch as-is as soon as Jonathan takes 1/2.
Regards,
Matthias
next prev parent reply other threads:[~2020-10-13 15:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-12 20:52 [PATCH 1/2] dt-bindings: iio: adc: auxadc: add doc for MT8516 SoC Fabien Parent
2020-10-12 20:52 ` [PATCH 2/2] arm64: dts: mediatek: mt8516: add auxadc node Fabien Parent
2020-10-13 6:01 ` Matthias Brugger
2020-10-13 9:06 ` Fabien Parent
2020-10-13 15:29 ` Matthias Brugger [this message]
2020-10-19 10:21 ` Matthias Brugger
2020-10-13 6:00 ` [PATCH 1/2] dt-bindings: iio: adc: auxadc: add doc for MT8516 SoC Matthias Brugger
2020-10-18 10:11 ` Jonathan Cameron
2020-10-13 17:22 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ab900e0f-fd5f-a1cc-8300-b681c97f7231@gmail.com \
--to=matthias.bgg@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=fparent@baylibre.com \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=pmeerw@pmeerw.net \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).