From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5AD0C4332B for ; Thu, 19 Mar 2020 07:03:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 86D452072C for ; Thu, 19 Mar 2020 07:03:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725812AbgCSHDN (ORCPT ); Thu, 19 Mar 2020 03:03:13 -0400 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:1311 "EHLO mail3-relais-sop.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725787AbgCSHDM (ORCPT ); Thu, 19 Mar 2020 03:03:12 -0400 X-IronPort-AV: E=Sophos;i="5.70,570,1574118000"; d="scan'208";a="342881201" Received: from abo-173-121-68.mrs.modulonet.fr (HELO hadrien) ([85.68.121.173]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Mar 2020 08:03:08 +0100 Date: Thu, 19 Mar 2020 08:03:08 +0100 (CET) From: Julia Lawall X-X-Sender: jll@hadrien To: "Ardelean, Alexandru" cc: "mh12gx2825@gmail.com" , "kieran.bingham@ideasonboard.com" , "gregkh@linuxfoundation.org" , "linux-iio@vger.kernel.org" , "jic23@kernel.org" , "knaack.h@gmx.de" , "Hennerich, Michael" , "lars@metafoo.de" , "outreachy-kernel@googlegroups.com" , "daniel.baluta@gmail.com" , "pmeerw@pmeerw.net" Subject: Re: [Outreachy kernel] Re: [PATCH 2/2] staging: iio: adc: ad7280a: Add spaces around operators In-Reply-To: Message-ID: References: <6703668c512dd665a2299a1f5bf14d99262314f8.1584505215.git.mh12gx2825@gmail.com> <20200318060038.GB1594471@kroah.com> <35afdc4b-bd59-7851-aa4f-3d8807668931@metafoo.de> <20200318151924.GB2862853@kroah.com> <20200318162353.GA23226@deeUbuntu> <20200318170051.GA23498@deeUbuntu> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Thu, 19 Mar 2020, Ardelean, Alexandru wrote: > On Wed, 2020-03-18 at 22:30 +0530, DEEPAK VARMA wrote: > > [External] > > > > On Wed, Mar 18, 2020 at 05:28:17PM +0100, Julia Lawall wrote: > > > > > > On Wed, 18 Mar 2020, DEEPAK VARMA wrote: > > > > > > > On Wed, Mar 18, 2020 at 04:19:24PM +0100, Greg KH wrote: > > > > > On Wed, Mar 18, 2020 at 04:12:28PM +0100, Lars-Peter Clausen wrote: > > > > > > On 3/18/20 7:00 AM, Greg KH wrote: > > > > > > > On Wed, Mar 18, 2020 at 09:58:13AM +0530, Deepak R Varma wrote: > > > > > > > > Add spaces around operator symbols to improve readability. Warning > > > > > > > > flagged by checkpatch script. > > > > > > > > > > > > > > > > Signed-off-by: Deepak R Varma > > > > > > > > --- > > > > > > > > drivers/staging/iio/adc/ad7280a.c | 4 ++-- > > > > > > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > > > > > > > > > > > diff --git a/drivers/staging/iio/adc/ad7280a.c > > > > > > > > b/drivers/staging/iio/adc/ad7280a.c > > > > > > > > index 19a5f244dcae..34ca0d09db85 100644 > > > > > > > > --- a/drivers/staging/iio/adc/ad7280a.c > > > > > > > > +++ b/drivers/staging/iio/adc/ad7280a.c > > > > > > > > @@ -825,14 +825,14 @@ static irqreturn_t ad7280_event_handler(int > > > > > > > > irq, void *private) > > > > > > > > } > > > > > > > > static IIO_DEVICE_ATTR_NAMED(in_thresh_low_value, > > > > > > > > - in_voltage-voltage_thresh_low_value, > > > > > > > > + in_voltage - voltage_thresh_low_value, > > > > > > > > 0644, > > > > > > > > ad7280_read_channel_config, > > > > > > > > ad7280_write_channel_config, > > > > > > > > AD7280A_CELL_UNDERVOLTAGE); > > > > > > > > static IIO_DEVICE_ATTR_NAMED(in_thresh_high_value, > > > > > > > > - in_voltage-voltage_thresh_high_value, > > > > > > > > + in_voltage - voltage_thresh_high_value, > > > > > > > > 0644, > > > > > > > > ad7280_read_channel_config, > > > > > > > > ad7280_write_channel_config, > > > > > > > > > > > > > > Did you try building this code? > > > > > > > > > > > > > > It catches everyone... > > > > > > > > > > > > The problem is it builds. The token is stringyfied and > > > > > > "in_voltage - voltage_thresh_high_value" is a valid string. > > > > > > > > > > Ah, I thought it used to break the build when it happened. Oh well, > > > > > it's still a great "trick" to see if people understand C or not :) > > > > > > > > > Yes, it did build. I am sorry but I am not following you fully. Can you > > > > please let me know if the change I introduced is not good. You may > > > > please direct me to a document where I can read more about it. > > > > > > The code involves a macro, as indicated by the capital letters. You will > > > see the issue when you look at the definition of the macro. > > > > > > julia > > > > Thank you Julia and all. I got my mistake. I will revert the change. > > Sorry for the trouble. > > I'll try to make some time to address this somehow, so that checkpatch doesn't > bump into this. > > In the last 2-3 years, I think I saw 3-4 patches trying to address this [for > various Analog drivers]. > So, don't feel too bad. Maybe a comment? julia > > > > > > Deepak. > > > > Thanks, > > > > Deepak. > > > > > thanks, > > > > > > > > > > greg k-h > > > > > > > > -- > > > > You received this message because you are subscribed to the Google Groups > > > > "outreachy-kernel" group. > > > > To unsubscribe from this group and stop receiving emails from it, send an > > > > email to outreachy-kernel+unsubscribe@googlegroups.com. > > > > To view this discussion on the web visit > > > > https://groups.google.com/d/msgid/outreachy-kernel/20200318162353.GA23226%40deeUbuntu > > > > . > > > > >