Linux-IIO Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH v2] media: staging/intel-ipu3: Reformat pointer initialization
@ 2020-03-22 18:53 Deepak R Varma
  2020-03-22 19:17 ` [Outreachy kernel] " Julia Lawall
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: Deepak R Varma @ 2020-03-22 18:53 UTC (permalink / raw)
  To: outreachy-kernel, gregkh, daniel.baluta, kieran.bingham
  Cc: lars, Michael.Hennerich, jic23, knaack.h, pmeerw, gregkh, linux-iio

Reformat pointer initialization to make it more readable as per the
coding standards. Problem detected by checkpatch.

Signed-off-by: Deepak R Varma <mh12gx2825@gmail.com>
---

Changes since v1:
    - Correct commit message and description as advised vy Stefano. Its
      pointer initialization and not declaration as mentioned earlier.
    
 drivers/staging/media/ipu3/ipu3-v4l2.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/media/ipu3/ipu3-v4l2.c b/drivers/staging/media/ipu3/ipu3-v4l2.c
index 569e27b824c8..52826fad6f42 100644
--- a/drivers/staging/media/ipu3/ipu3-v4l2.c
+++ b/drivers/staging/media/ipu3/ipu3-v4l2.c
@@ -485,7 +485,6 @@ static int imgu_vb2_start_streaming(struct vb2_queue *vq, unsigned int count)
 	if (r < 0)
 		goto fail_return_bufs;
 
-
 	if (!imgu_all_nodes_streaming(imgu, node))
 		return 0;
 
@@ -1013,8 +1012,9 @@ static const struct v4l2_ioctl_ops imgu_v4l2_meta_ioctl_ops = {
 
 static int imgu_sd_s_ctrl(struct v4l2_ctrl *ctrl)
 {
-	struct imgu_v4l2_subdev *imgu_sd =
-		container_of(ctrl->handler, struct imgu_v4l2_subdev, ctrl_handler);
+	struct imgu_v4l2_subdev *imgu_sd = container_of(ctrl->handler,
+							struct imgu_v4l2_subdev,
+							ctrl_handler);
 	struct imgu_device *imgu = v4l2_get_subdevdata(&imgu_sd->subdev);
 	struct device *dev = &imgu->pci_dev->dev;
 
-- 
2.17.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [Outreachy kernel] [PATCH v2] media: staging/intel-ipu3: Reformat pointer initialization
  2020-03-22 18:53 [PATCH v2] media: staging/intel-ipu3: Reformat pointer initialization Deepak R Varma
@ 2020-03-22 19:17 ` " Julia Lawall
  2020-03-22 23:35 ` Andy Shevchenko
  2020-03-28 13:24 ` Jonathan Cameron
  2 siblings, 0 replies; 5+ messages in thread
From: Julia Lawall @ 2020-03-22 19:17 UTC (permalink / raw)
  To: Deepak R Varma
  Cc: outreachy-kernel, gregkh, daniel.baluta, kieran.bingham, lars,
	Michael.Hennerich, jic23, knaack.h, pmeerw, linux-iio



On Mon, 23 Mar 2020, Deepak R Varma wrote:

> Reformat pointer initialization to make it more readable as per the
> coding standards. Problem detected by checkpatch.
>
> Signed-off-by: Deepak R Varma <mh12gx2825@gmail.com>
> ---
>
> Changes since v1:
>     - Correct commit message and description as advised vy Stefano. Its
>       pointer initialization and not declaration as mentioned earlier.
>
>  drivers/staging/media/ipu3/ipu3-v4l2.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/media/ipu3/ipu3-v4l2.c b/drivers/staging/media/ipu3/ipu3-v4l2.c
> index 569e27b824c8..52826fad6f42 100644
> --- a/drivers/staging/media/ipu3/ipu3-v4l2.c
> +++ b/drivers/staging/media/ipu3/ipu3-v4l2.c
> @@ -485,7 +485,6 @@ static int imgu_vb2_start_streaming(struct vb2_queue *vq, unsigned int count)
>  	if (r < 0)
>  		goto fail_return_bufs;
>
> -

This change shouldn't be part of this patch.

julia

>  	if (!imgu_all_nodes_streaming(imgu, node))
>  		return 0;
>
> @@ -1013,8 +1012,9 @@ static const struct v4l2_ioctl_ops imgu_v4l2_meta_ioctl_ops = {
>
>  static int imgu_sd_s_ctrl(struct v4l2_ctrl *ctrl)
>  {
> -	struct imgu_v4l2_subdev *imgu_sd =
> -		container_of(ctrl->handler, struct imgu_v4l2_subdev, ctrl_handler);
> +	struct imgu_v4l2_subdev *imgu_sd = container_of(ctrl->handler,
> +							struct imgu_v4l2_subdev,
> +							ctrl_handler);
>  	struct imgu_device *imgu = v4l2_get_subdevdata(&imgu_sd->subdev);
>  	struct device *dev = &imgu->pci_dev->dev;
>
> --
> 2.17.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20200322185350.GA12377%40deeUbuntu.
>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v2] media: staging/intel-ipu3: Reformat pointer initialization
  2020-03-22 18:53 [PATCH v2] media: staging/intel-ipu3: Reformat pointer initialization Deepak R Varma
  2020-03-22 19:17 ` [Outreachy kernel] " Julia Lawall
@ 2020-03-22 23:35 ` Andy Shevchenko
  2020-03-23 15:17   ` DEEPAK VARMA
  2020-03-28 13:24 ` Jonathan Cameron
  2 siblings, 1 reply; 5+ messages in thread
From: Andy Shevchenko @ 2020-03-22 23:35 UTC (permalink / raw)
  To: Deepak R Varma
  Cc: outreachy-kernel, Greg Kroah-Hartman, Daniel Baluta,
	kieran.bingham, Lars-Peter Clausen, Michael Hennerich,
	Jonathan Cameron, Hartmut Knaack, Peter Meerwald, linux-iio

On Sun, Mar 22, 2020 at 8:54 PM Deepak R Varma <mh12gx2825@gmail.com> wrote:
>
> Reformat pointer initialization to make it more readable as per the
> coding standards. Problem detected by checkpatch.

> -       struct imgu_v4l2_subdev *imgu_sd =
> -               container_of(ctrl->handler, struct imgu_v4l2_subdev, ctrl_handler);
> +       struct imgu_v4l2_subdev *imgu_sd = container_of(ctrl->handler,
> +                                                       struct imgu_v4l2_subdev,
> +                                                       ctrl_handler);

I'm sorry I don't see benefit of this change, actually an opposite.

-- 
With Best Regards,
Andy Shevchenko

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v2] media: staging/intel-ipu3: Reformat pointer initialization
  2020-03-22 23:35 ` Andy Shevchenko
@ 2020-03-23 15:17   ` DEEPAK VARMA
  0 siblings, 0 replies; 5+ messages in thread
From: DEEPAK VARMA @ 2020-03-23 15:17 UTC (permalink / raw)
  To: Andy Shevchenko
  Cc: outreachy-kernel, Greg Kroah-Hartman, Daniel Baluta,
	kieran.bingham, Lars-Peter Clausen, Michael Hennerich,
	Jonathan Cameron, Hartmut Knaack, Peter Meerwald, linux-iio

On Mon, Mar 23, 2020 at 01:35:58AM +0200, Andy Shevchenko wrote:
> On Sun, Mar 22, 2020 at 8:54 PM Deepak R Varma <mh12gx2825@gmail.com> wrote:
> >
> > Reformat pointer initialization to make it more readable as per the
> > coding standards. Problem detected by checkpatch.
> 
> > -       struct imgu_v4l2_subdev *imgu_sd =
> > -               container_of(ctrl->handler, struct imgu_v4l2_subdev, ctrl_handler);
> > +       struct imgu_v4l2_subdev *imgu_sd = container_of(ctrl->handler,
> > +                                                       struct imgu_v4l2_subdev,
> > +                                                       ctrl_handler);
> 
> I'm sorry I don't see benefit of this change, actually an opposite.

Hello Andy,
Thank you for your comment. To me, it helps quickly and clearly spot
*imgu_sd. Also the initialization looks more structured. But that's just
me.

I will wait to see if anyone else wants to share their thoughts, and
then circle back to you on next steps. Is that fine?

Deepak.
> 
> -- 
> With Best Regards,
> Andy Shevchenko

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v2] media: staging/intel-ipu3: Reformat pointer initialization
  2020-03-22 18:53 [PATCH v2] media: staging/intel-ipu3: Reformat pointer initialization Deepak R Varma
  2020-03-22 19:17 ` [Outreachy kernel] " Julia Lawall
  2020-03-22 23:35 ` Andy Shevchenko
@ 2020-03-28 13:24 ` Jonathan Cameron
  2 siblings, 0 replies; 5+ messages in thread
From: Jonathan Cameron @ 2020-03-28 13:24 UTC (permalink / raw)
  To: Deepak R Varma
  Cc: outreachy-kernel, gregkh, daniel.baluta, kieran.bingham, lars,
	Michael.Hennerich, knaack.h, pmeerw, linux-iio

On Mon, 23 Mar 2020 00:23:54 +0530
Deepak R Varma <mh12gx2825@gmail.com> wrote:

> Reformat pointer initialization to make it more readable as per the
> coding standards. Problem detected by checkpatch.
> 
> Signed-off-by: Deepak R Varma <mh12gx2825@gmail.com>

Check your cc list before sending and make sure it makes sense.
Driver has nothing to do with IIO and half your list are from
IIO MAINTAINERS entry.

> ---
> 
> Changes since v1:
>     - Correct commit message and description as advised vy Stefano. Its
>       pointer initialization and not declaration as mentioned earlier.
>     
>  drivers/staging/media/ipu3/ipu3-v4l2.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/media/ipu3/ipu3-v4l2.c b/drivers/staging/media/ipu3/ipu3-v4l2.c
> index 569e27b824c8..52826fad6f42 100644
> --- a/drivers/staging/media/ipu3/ipu3-v4l2.c
> +++ b/drivers/staging/media/ipu3/ipu3-v4l2.c
> @@ -485,7 +485,6 @@ static int imgu_vb2_start_streaming(struct vb2_queue *vq, unsigned int count)
>  	if (r < 0)
>  		goto fail_return_bufs;
>  
> -
>  	if (!imgu_all_nodes_streaming(imgu, node))
>  		return 0;
>  
> @@ -1013,8 +1012,9 @@ static const struct v4l2_ioctl_ops imgu_v4l2_meta_ioctl_ops = {
>  
>  static int imgu_sd_s_ctrl(struct v4l2_ctrl *ctrl)
>  {
> -	struct imgu_v4l2_subdev *imgu_sd =
> -		container_of(ctrl->handler, struct imgu_v4l2_subdev, ctrl_handler);
> +	struct imgu_v4l2_subdev *imgu_sd = container_of(ctrl->handler,
> +							struct imgu_v4l2_subdev,
> +							ctrl_handler);
>  	struct imgu_device *imgu = v4l2_get_subdevdata(&imgu_sd->subdev);
>  	struct device *dev = &imgu->pci_dev->dev;
>  


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, back to index

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-22 18:53 [PATCH v2] media: staging/intel-ipu3: Reformat pointer initialization Deepak R Varma
2020-03-22 19:17 ` [Outreachy kernel] " Julia Lawall
2020-03-22 23:35 ` Andy Shevchenko
2020-03-23 15:17   ` DEEPAK VARMA
2020-03-28 13:24 ` Jonathan Cameron

Linux-IIO Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-iio/0 linux-iio/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-iio linux-iio/ https://lore.kernel.org/linux-iio \
		linux-iio@vger.kernel.org
	public-inbox-index linux-iio

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-iio


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git