From: "Ardelean, Alexandru" <alexandru.Ardelean@analog.com>
To: "pmeerw@pmeerw.net" <pmeerw@pmeerw.net>,
"Hennerich, Michael" <Michael.Hennerich@analog.com>,
"manivannan.sadhasivam@linaro.org"
<manivannan.sadhasivam@linaro.org>,
"lars@metafoo.de" <lars@metafoo.de>,
"jic23@kernel.org" <jic23@kernel.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"knaack.h@gmx.de" <knaack.h@gmx.de>
Cc: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>
Subject: Re: [PATCH 1/2] dt-bindings: iio: light: Add binding for ADUX1020
Date: Mon, 7 Oct 2019 13:21:50 +0000 [thread overview]
Message-ID: <b03c8de71e6d568d54ddfd07758c07c03c0eb89d.camel@analog.com> (raw)
In-Reply-To: <4EC23AB5-B8BE-4E45-8E5B-FCCD5B1508BA@linaro.org>
On Mon, 2019-10-07 at 18:10 +0530, Manivannan Sadhasivam wrote:
> [External]
>
> Hi Ardelean,
>
> On 7 October 2019 3:51:16 PM IST, "Ardelean, Alexandru" <
> alexandru.Ardelean@analog.com> wrote:
> > On Mon, 2019-10-07 at 15:40 +0530, Manivannan Sadhasivam wrote:
> > > [External]
> > >
> > > Add devicetree binding for Analog Devices ADUX1020 Photometric
> > > sensor.
> > >
> >
> > Hey,
> >
> > Thanks for the patches.
> >
> > This dt-binding docs is in text format.
> > dt-binding docs now need to be in YAML format.
> >
>
> Sure. I can convert to YAML binding.
>
> > Also, patches for dt-bindings docs usually come after the driver is
> > added.
> > So, this patch should be the second in the series, not the first.
> >
>
> I don't think so. The convention is to put dt-bindings patch upfront for
> all subsystems. Not sure if IIO differs here.
Now that you mention, I'm not sure either.
We typically sent the dt-bindings one last, so I assumed it was the
default.
>
> Thanks,
> Mani
> > Alex
> >
> > > Signed-off-by: Manivannan Sadhasivam
> > <manivannan.sadhasivam@linaro.org>
> > > ---
> > > .../bindings/iio/light/adux1020.txt | 22
> > +++++++++++++++++++
> > > 1 file changed, 22 insertions(+)
> > > create mode 100644
> > > Documentation/devicetree/bindings/iio/light/adux1020.txt
> > >
> > > diff --git a/Documentation/devicetree/bindings/iio/light/adux1020.txt
> > > b/Documentation/devicetree/bindings/iio/light/adux1020.txt
> > > new file mode 100644
> > > index 000000000000..e896dda30e36
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/iio/light/adux1020.txt
> > > @@ -0,0 +1,22 @@
> > > +Analog Devices ADUX1020 Photometric sensor
> > > +
> > > +Link to datasheet:
> > >
> > https://www.analog.com/media/en/technical-documentation/data-sheets/ADUX1020.pdf
> > > +
> > > +Required properties:
> > > +
> > > + - compatible: should be "adi,adux1020"
> > > + - reg: the I2C address of the sensor
> > > +
> > > +Optional properties:
> > > +
> > > + - interrupts: interrupt mapping for IRQ as documented in
> > > +
> > Documentation/devicetree/bindings/interrupt-controller/interrupts.txt
> > > +
> > > +Example:
> > > +
> > > +adux1020@64 {
> > > + compatible = "adi,adux1020";
> > > + reg = <0x64>;
> > > + interrupt-parent = <&msmgpio>;
> > > + interrupts = <24 IRQ_TYPE_LEVEL_HIGH>;
> > > +};
next prev parent reply other threads:[~2019-10-07 13:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-07 10:10 [PATCH 0/2] Add support for ADUX1020 sensor Manivannan Sadhasivam
2019-10-07 10:10 ` [PATCH 1/2] dt-bindings: iio: light: Add binding for ADUX1020 Manivannan Sadhasivam
2019-10-07 10:21 ` Ardelean, Alexandru
2019-10-07 12:40 ` Manivannan Sadhasivam
2019-10-07 13:21 ` Ardelean, Alexandru [this message]
2019-10-08 12:29 ` Jonathan Cameron
2019-10-07 10:10 ` [PATCH 2/2] iio: light: Add support for ADUX1020 sensor Manivannan Sadhasivam
2019-10-08 6:52 ` Ardelean, Alexandru
2019-10-09 9:45 ` Manivannan Sadhasivam
2019-10-09 10:21 ` Ardelean, Alexandru
2019-10-12 11:59 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b03c8de71e6d568d54ddfd07758c07c03c0eb89d.camel@analog.com \
--to=alexandru.ardelean@analog.com \
--cc=Michael.Hennerich@analog.com \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=pmeerw@pmeerw.net \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).