Linux-IIO Archive on lore.kernel.org
 help / color / Atom feed
From: Lars-Peter Clausen <lars@metafoo.de>
To: "Guido Günther" <agx@sigxcpu.org>,
	"Tomas Novotny" <tomas@novotny.cz>,
	"Jonathan Cameron" <jic23@kernel.org>,
	"Hartmut Knaack" <knaack.h@gmx.de>,
	"Peter Meerwald-Stadler" <pmeerw@pmeerw.net>,
	"Angus Ainslie (Purism)" <angus@akkea.ca>,
	"Marco Felsch" <m.felsch@pengutronix.de>,
	"Thomas Gleixner" <tglx@linutronix.de>,
	linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org
Subject: Re: [PATCH v2 3/4] iio: vcnl4000: Export near level property for proximity sensor
Date: Mon, 16 Mar 2020 19:23:01 +0100
Message-ID: <c787921f-c412-4986-14ea-e31b531d3d5b@metafoo.de> (raw)
In-Reply-To: <5566fe01df933d3281f058666e2147cb97b38126.1584380360.git.agx@sigxcpu.org>

On 3/16/20 6:46 PM, Guido Günther wrote:
> [...]
> +static ssize_t vcnl4000_read_near_level(struct iio_dev *indio_dev,
> +					uintptr_t priv,
> +					const struct iio_chan_spec *chan,
> +					char *buf)
> +{
> +	struct vcnl4000_data *data = iio_priv(indio_dev);
> +
> +	return sprintf(buf, "%u\n", data->near_level);
> +}
> +
> +static const struct iio_chan_spec_ext_info vcnl4000_ext_info[] = {
> +	{
> +		.name = "near_level",

Generally having properties with a underscore in them breaks generic 
parsing of the property name by userspace applications. This is because 
we use underscores to separate different components (type, modifier, 
etc.) of the attribute from each other.

Do you think calling this "nearlevel" would work?

I know there are existing bad examples of properties that use an 
underscore, but we should try to limit introducing new ones.

> +		.shared = IIO_SEPARATE,
> +		.read = vcnl4000_read_near_level,
> +	},
> +	{ /* sentinel */ }
> +};
> +
>   static const struct iio_chan_spec vcnl4000_channels[] = {
>   	{
>   		.type = IIO_LIGHT,
> @@ -350,6 +371,7 @@ static const struct iio_chan_spec vcnl4000_channels[] = {
>   	}, {
>   		.type = IIO_PROXIMITY,
>   		.info_mask_separate = BIT(IIO_CHAN_INFO_RAW),
> +		.ext_info = vcnl4000_ext_info,
>   	}
>   };
>   
> @@ -439,6 +461,10 @@ static int vcnl4000_probe(struct i2c_client *client,
>   	dev_dbg(&client->dev, "%s Ambient light/proximity sensor, Rev: %02x\n",
>   		data->chip_spec->prod, data->rev);
>   
> +	if (device_property_read_u32(&client->dev, "near-level",
> +				     &data->near_level) < 0)
> +		data->near_level = 0;
> +
>   	indio_dev->dev.parent = &client->dev;
>   	indio_dev->info = &vcnl4000_info;
>   	indio_dev->channels = vcnl4000_channels;



  reply index

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-16 17:46 [PATCH v2 0/4] " Guido Günther
2020-03-16 17:46 ` [PATCH v2 1/4] dt-bindings: iio: vcnl4000: convert bindings to YAML format Guido Günther
2020-03-22 17:29   ` Jonathan Cameron
2020-03-22 17:37     ` Nishant Malpani
2020-03-22 18:24       ` Jonathan Cameron
2020-03-16 17:46 ` [PATCH v2 2/4] dt-bindings: iio: light: vcnl4000: Add near-level Guido Günther
2020-03-16 17:46 ` [PATCH v2 3/4] iio: vcnl4000: Export near level property for proximity sensor Guido Günther
2020-03-16 18:23   ` Lars-Peter Clausen [this message]
2020-03-17 12:05     ` Guido Günther
2020-03-17 13:11       ` Lars-Peter Clausen
2020-03-22  0:21   ` Andy Shevchenko
2020-03-16 17:46 ` [PATCH v2 4/4] Documentation: ABI: document IIO in_proximity_near_level file Guido Günther

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c787921f-c412-4986-14ea-e31b531d3d5b@metafoo.de \
    --to=lars@metafoo.de \
    --cc=agx@sigxcpu.org \
    --cc=angus@akkea.ca \
    --cc=devicetree@vger.kernel.org \
    --cc=jic23@kernel.org \
    --cc=knaack.h@gmx.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=m.felsch@pengutronix.de \
    --cc=pmeerw@pmeerw.net \
    --cc=tglx@linutronix.de \
    --cc=tomas@novotny.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-IIO Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-iio/0 linux-iio/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-iio linux-iio/ https://lore.kernel.org/linux-iio \
		linux-iio@vger.kernel.org
	public-inbox-index linux-iio

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-iio


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git