From: Benjamin GAIGNARD <benjamin.gaignard@st.com>
To: Rob Herring <robh@kernel.org>,
Benjamin Gaignard <benjamin.gaignard@linaro.org>
Cc: Jonathan Cameron <jic23@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Alexandre TORGUE <alexandre.torgue@st.com>,
Linux PWM List <linux-pwm@vger.kernel.org>,
"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
"u.kleine-koenig@pengutronix.de" <u.kleine-koenig@pengutronix.de>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Thierry Reding <thierry.reding@gmail.com>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Hartmut Knaack <knaack.h@gmx.de>,
Fabrice GASNIER <fabrice.gasnier@st.com>,
Lee Jones <lee.jones@linaro.org>,
"linux-stm32@st-md-mailman.stormreply.com"
<linux-stm32@st-md-mailman.stormreply.com>,
Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 2/4] dt-bindings: iio: timer: Convert stm32 IIO trigger bindings to json-schema
Date: Wed, 6 Nov 2019 19:51:56 +0000 [thread overview]
Message-ID: <d0196570-9140-c775-742c-89092056e651@st.com> (raw)
In-Reply-To: <20191106040657.GA5294@bogus>
On 11/6/19 5:06 AM, Rob Herring wrote:
> On Tue, Nov 05, 2019 at 11:07:16AM +0100, Benjamin Gaignard wrote:
>> Le dim. 3 nov. 2019 à 12:08, Jonathan Cameron <jic23@kernel.org> a écrit :
>>> On Thu, 31 Oct 2019 13:30:38 +0100
>>> Benjamin Gaignard <benjamin.gaignard@st.com> wrote:
>>>
>>>> Convert the STM32 IIO trigger binding to DT schema format using json-schema
>>>>
>>>> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@st.com>
>>> I'm far from great on these as still haven't taken the time I should to learn
>>> the yaml syntax properly. A few comments inline however based mostly on this
>>> doesn't quite look like other ones I've seen recently.
>>>
>>> Thanks,
>>>
>>> Jonathan
>>>
>>>> ---
>>>> .../bindings/iio/timer/st,stm32-timer-trigger.yaml | 44 ++++++++++++++++++++++
>>>> .../bindings/iio/timer/stm32-timer-trigger.txt | 25 ------------
>>>> 2 files changed, 44 insertions(+), 25 deletions(-)
>>>> create mode 100644 Documentation/devicetree/bindings/iio/timer/st,stm32-timer-trigger.yaml
>>>> delete mode 100644 Documentation/devicetree/bindings/iio/timer/stm32-timer-trigger.txt
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/iio/timer/st,stm32-timer-trigger.yaml b/Documentation/devicetree/bindings/iio/timer/st,stm32-timer-trigger.yaml
>>>> new file mode 100644
>>>> index 000000000000..1c8c8b55e8cd
>>>> --- /dev/null
>>>> +++ b/Documentation/devicetree/bindings/iio/timer/st,stm32-timer-trigger.yaml
>>>> @@ -0,0 +1,44 @@
>>>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>>>> +%YAML 1.2
>>>> +---
>>>> +$id: http://devicetree.org/schemas/iio/timer/st,stm32-timer-trigger.yaml#
>>>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>>>> +
>>>> +title: STMicroelectronics STM32 Timers IIO timer bindings
>>>> +
>>>> +maintainers:
>>>> + - Benjamin Gaignard <benjamin.gaignard@st.com>
>>>> + - Fabrice Gasnier <fabrice.gasnier@st.com>
>>>> +
>>>> +properties:
>>>> + $nodemane:
>>> nodename?
>> That will be in v2
> No, $nodename is correct. The '$' signifies something we generate and
> add in. IOW, not a real property. I guess we could have used 'name' here
> and stuck with traditional OpenFirmware.
let's go for $name
>>>> + pattern: "^timer@[0-9]+$"
>>>> + type: object
>>>> +
>>>> + description:
>>>> + must be a sub-node of an STM32 Timer device tree node
>>>> +
>>>> + properties:
>>>> + compatible:
>>>> + oneOf:
>>> enum is I think preferred for these.
>> as you like it will be in v2
>>
>>>> + - const: st,stm32-timer-trigger
>>>> + - const: st,stm32h7-timer-trigger
>>>> +
>>>> + reg: true
>>> Normally some info for what the reg value is..
>> I can't put "description" on this field because the syntax doesn't allow it.
>> I will add a comment in v2 to explain what reg is.
> items:
> - maximum: <max timer number>
reg is an index from 0 up to X, I will try with your syntax.
Thanks,
Benjamin
>
> Rob
next prev parent reply other threads:[~2019-11-06 19:52 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-31 12:30 [PATCH 0/4] Convert STM32 Timer mdf bindings to yaml Benjamin Gaignard
2019-10-31 12:30 ` [PATCH 1/4] dt-bindings: counter: Convert stm32 counter bindings to json-schema Benjamin Gaignard
2019-11-06 4:10 ` Rob Herring
2019-11-06 4:16 ` Rob Herring
2019-11-06 19:58 ` Benjamin GAIGNARD
2019-10-31 12:30 ` [PATCH 2/4] dt-bindings: iio: timer: Convert stm32 IIO trigger " Benjamin Gaignard
2019-11-03 11:08 ` Jonathan Cameron
2019-11-05 10:07 ` Benjamin Gaignard
2019-11-06 4:06 ` Rob Herring
2019-11-06 19:51 ` Benjamin GAIGNARD [this message]
2019-11-06 23:35 ` Rob Herring
2019-11-09 12:43 ` Jonathan Cameron
2019-10-31 12:30 ` [PATCH 3/4] dt-bindings: pwm: Convert stm32 pwm " Benjamin Gaignard
2019-10-31 12:30 ` [PATCH 4/4] dt-bindings: mfd: Convert stm32 timers " Benjamin Gaignard
2019-11-06 4:15 ` Rob Herring
2019-11-06 19:57 ` Benjamin GAIGNARD
2019-11-06 23:33 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d0196570-9140-c775-742c-89092056e651@st.com \
--to=benjamin.gaignard@st.com \
--cc=alexandre.torgue@st.com \
--cc=benjamin.gaignard@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=fabrice.gasnier@st.com \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mark.rutland@arm.com \
--cc=pmeerw@pmeerw.net \
--cc=robh@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).