From: Sean Nyekjaer <sean@geanix.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: linux-iio@vger.kernel.org
Subject: Re: [PATCH 1/2] iio: adc: ti-ads8688: save values correct in buffer
Date: Sat, 11 May 2019 14:03:10 +0200 [thread overview]
Message-ID: <d858d6d8-59ef-dee1-92ae-e1f896b1b745@geanix.com> (raw)
In-Reply-To: <20190511124417.1b5bbf23@archlinux>
On 11/05/2019 13.44, Jonathan Cameron wrote:
> On Tue, 7 May 2019 10:23:03 +0200
> Sean Nyekjaer <sean@geanix.com> wrote:
>
>> Fill the read values in the buffer so we comply
>> with the given index values.
> Why?
>
> They are not supposed to always remain in the same place. If some channels
> are turned off then they will shift 'down'. That has to happen in general
> to allow us to do more efficient packing when they happen to fit into a
> smaller power of 2 size.
> So if channels 0-3 (8 bits each) are enabled and timestamp, it should be
>
> 0 1 2 3 X X X X Timestamp, 0 1 2 3 X X X X Timestamp..
>
> If no timestamp it should fall back to the packing
> 0 1 2 3, 0 1 2 3
>
> If only channels 0, 1 and 3 we should get
>
> 0 1 3 X, 0 1 3 X (padding to 32 bits)
>
> For only 0 and 3
> 0 3, 0 3, 0 3
>
> For only 0
> 0, 0, 0, 0, 0, 0
>
> Jonathan
>
Thanks for clarifying :-)
/Sean
prev parent reply other threads:[~2019-05-11 12:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-07 8:23 [PATCH 1/2] iio: adc: ti-ads8688: save values correct in buffer Sean Nyekjaer
2019-05-07 8:23 ` [PATCH 2/2] iio: adc: ti-ads8688: fix timestamp is not updated " Sean Nyekjaer
2019-05-11 11:50 ` Jonathan Cameron
2019-05-11 11:44 ` [PATCH 1/2] iio: adc: ti-ads8688: save values correct " Jonathan Cameron
2019-05-11 12:03 ` Sean Nyekjaer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d858d6d8-59ef-dee1-92ae-e1f896b1b745@geanix.com \
--to=sean@geanix.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).