From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 270CDC28CC0 for ; Thu, 30 May 2019 12:35:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EFF7824A35 for ; Thu, 30 May 2019 12:35:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726029AbfE3MfO (ORCPT ); Thu, 30 May 2019 08:35:14 -0400 Received: from mail-ed1-f66.google.com ([209.85.208.66]:37020 "EHLO mail-ed1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725919AbfE3MfO (ORCPT ); Thu, 30 May 2019 08:35:14 -0400 Received: by mail-ed1-f66.google.com with SMTP id w37so8935041edw.4 for ; Thu, 30 May 2019 05:35:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=xPIgMrsDPU059Y3vze9kPfFnp36/EoKGG25nHsTs/Yw=; b=N31MAW/g/++jfhJrLMOh+/tFvLQkmyMZ/nVl2Wl+iazWxbtEiwt3DwR/EJhLWW4cv3 XZwYYhLmTuAN6omWCdbDCv8YdTmJXdPwrNsENx1C93SiLfULag1k4C2NWWLTV80IL6u4 0mCCzMawrCa/nTufQwVR8KXtFicbawCTERvmdN4B/JpI7hgOosXMa04Bo3B1HNFpNeRB FGy3EHN+xJstnoNIOv9JXXNqOEqJ7xa+MsKWIcfXVrQXgq7I/41Y5iR86uzqwtjBxLHo 0QGW6IqG1G1AZw2RDkucy8XBSwm/XFNnFPsnq7MHYHIC+4LSzRHKk/GBi0j0eN5+6v2n ZfVw== X-Gm-Message-State: APjAAAXMDolkK6Jw9/YI4M/HnyByV3FqLvVu0UxwK8CNyQntCil6eJbe gTFxBxy35Ht52aiCmApLeTaiTg== X-Google-Smtp-Source: APXvYqyiiK1senMjy75Dno+02Gqym6f26u/x6/fAF2WQr2fSd2jSOzYrNvoVrZsrXQd+KznmuEB7nQ== X-Received: by 2002:a17:906:ecf0:: with SMTP id qt16mr3274518ejb.166.1559219712478; Thu, 30 May 2019 05:35:12 -0700 (PDT) Received: from shalem.localdomain (84-106-84-65.cable.dynamic.v4.ziggo.nl. [84.106.84.65]) by smtp.gmail.com with ESMTPSA id d4sm699576edk.46.2019.05.30.05.35.10 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Thu, 30 May 2019 05:35:11 -0700 (PDT) Subject: Re: [PATCH] iio: accel: add missing sensor for some 2-in-1 based ultrabooks To: =?UTF-8?Q?Lu=c3=ads_Ferreira?= Cc: jic23@kernel.org, Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , Stephan Gerhold , "open list:IIO SUBSYSTEM AND DRIVERS" , open list References: <20190402160433.15810-1-luis@aurorafoss.org> <55a52a4e-01d1-2f4c-25e3-0047537bef86@redhat.com> <9d8458a1-fc47-0727-4dc8-1d1eb185886d@redhat.com> <96658776-bd09-4b2d-2049-f2b213d60f8a@redhat.com> From: Hans de Goede Message-ID: Date: Thu, 30 May 2019 14:35:10 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org Hi, On 30-05-19 13:53, Luís Ferreira wrote: > Hi, > > @poettering just merged the pull request. Is it ready to go now? You mean the kernel patch, yes merging that now is fine with me. Regards, Hans > > Sincerely, > Luís Ferreira > E2AB 2BF8 F3EC ABE2 E149 F2FD BC43 0831 9CE4 0B64 > > On Wed, 29 May 2019 at 10:57, Hans de Goede wrote: >> >> Hi, >> >> On 5/23/19 2:03 PM, Luís Ferreira wrote: >>> Hi Hams, >>> >>> https://github.com/systemd/systemd/pull/12322 >>> https://github.com/hadess/iio-sensor-proxy/pull/262 >>> >>> As all the pull requests to systemd and iio-sensor-proxy has already >>> been merged, I just need your review on this: >>> https://github.com/systemd/systemd/pull/12449 >>> >>> Then, I guess this patch is ready to go. Please let me know if theres any issue. >> >> Thank you for your work on this. I've given a favorable review to the >> >> last systemd pull-req. >> >> Regards, >> >> Hans >> >> >>> On Wed, 17 Apr 2019 at 16:08, Hans de Goede wrote: >>>> >>>> Hi, >>>> >>>> On 15-04-19 17:40, luis@aurorafoss.org wrote: >>>>> April 6, 2019 10:36 AM, "Hans de Goede" wrote: >>>>> >>>>> Hi, >>>>> >>>>>> Yes that seems the best way forward with this. >>>>>> >>>>>> Note I think "base" is better then "keyboard" for the sensor which >>>>>> is in the base/keyboard. But neither is perfect, so go which whatever >>>>>> you prefer. >>>>> >>>>> Reference to: >>>>> - https://github.com/hadess/iio-sensor-proxy/pull/262 > - https://github.com/systemd/systemd/pull/12322 >>>> >>>> Thank you for your work on this, I see that Bastien has >>>> already reviewed the iio-sensor-proxy changes. >>>> >>>> I've just added one small remark to the systemd changes, >>>> except for that small remark the systemd changes look good to me. >>>> >>>> Regards, >>>> >>>> Hams >>>> >>>> >>>> >>>> >>>>>> On 06-04-19 01:01, Luís Ferreira wrote: >>>>>> >>>>>>> Hi, >>>>>>> Basically we need to come up with a convention to (optionally) indicate >>>>>> >>>>>> the sensors location with a udev attribute set by: >>>>>> /lib/udev/hwdb.d/60-sensor.hwdb >>>>>>> So should we start adding `ACCEL_LOCATION=display` and >>>>>>> `ACCEL_LOCATION=keyboard` attributes to that file and patch >>>>>>> iio-sensor-proxy to ignore the keyboard ones as a first step ? >>>>>> >>>>>> Yes that seems the best way forward with this. >>>>>> >>>>>> Note I think "base" is better then "keyboard" for the sensor which >>>>>> is in the base/keyboard. But neither is perfect, so go which whatever >>>>>> you prefer. >>>>>> >>>>>> Thanks & Regards, >>>>>> >>>>>> Hans >>>>>> >>>>>>> On Wed, 3 Apr 2019 at 10:10, Hans de Goede wrote: >>>>>> >>>>>> Hi, >>>>>> >>>>>> On 02-04-19 18:04, Luís Ferreira wrote: >>>>>>> Some ultrabooks, like Teclast F6 Pro, use KIOX010A sensor on display >>>>>>> and KIOX020A sensor on keyboard base, to detect tablet mode or screen >>>>>>> orientation. >>>>>> >>>>>> I deliberately left out the KIOX020A id for now, because currently >>>>>> userspace cannot really deal with having 2 sensors. >>>>>> >>>>>> See: >>>>>> https://github.com/systemd/systemd/issues/6557 >>>>>> https://github.com/hadess/iio-sensor-proxy/issues/166 >>>>>> >>>>>> Basically we need to come up with a convention to (optionally) indicate >>>>>> the sensors location with a udev attribute set by: >>>>>> /lib/udev/hwdb.d/60-sensor.hwdb >>>>>> >>>>>> And then patch iio-sensor-proxy to consume that attribute and ignore >>>>>> the one which has e.g. ACCEL_LOCATION=keyboard in its udev properties >>>>>> >>>>>> Ignoring would be a first step, maybe later it can do something useful >>>>>> with it, see e.g. : https://github.com/alesguzik/linux_detect_tablet_mode >>>>>> >>>>>> IMHO we really should minimally get code in place for iio-sensor-proxy >>>>>> to ignore the keyboard accelerometer before merging this patch. >>>>>> >>>>>> I realize that having the code in place will not magically get it on >>>>>> all users machines, but I believe this is the minimum which needs to >>>>>> happen before we push this out and potentially breaks people screen >>>>>> rotation. >>>>>> >>>>>> I've had working on this on my TODO list for a long long time now, >>>>>> but -ENOTIME. If you have some time to work on this then that would >>>>>> be great. >>>>>> >>>>>> Regards, >>>>>> >>>>>> Hans >>>>>>> Signed-off-by: Luís Ferreira >>>>>>> --- >>>>>>> drivers/iio/accel/kxcjk-1013.c | 1 + >>>>>>> 1 file changed, 1 insertion(+) >>>>>>> >>>>>>> diff --git a/drivers/iio/accel/kxcjk-1013.c b/drivers/iio/accel/kxcjk-1013.c >>>>>>> index 7096e577b23f..9a5e445facc1 100644 >>>>>>> --- a/drivers/iio/accel/kxcjk-1013.c >>>>>>> +++ b/drivers/iio/accel/kxcjk-1013.c >>>>>>> @@ -1492,6 +1492,7 @@ static const struct acpi_device_id kx_acpi_match[] = { >>>>>>> {"KIOX0009", KXTJ21009}, >>>>>>> {"KIOX000A", KXCJ91008}, >>>>>>> {"KIOX010A", KXCJ91008}, /* KXCJ91008 inside the display of a 2-in-1 */ >>>>>>> + {"KIOX020A", KXCJ91008}, >>>>>>> {"KXTJ1009", KXTJ21009}, >>>>>>> {"KXJ2109", KXTJ21009}, >>>>>>> {"SMO8500", KXCJ91008},