linux-iio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
To: Greg KH <gregkh@linuxfoundation.org>,
	Jonathan Cameron <Jonathan.Cameron@huawei.com>
Cc: linux-iio@vger.kernel.org, Martyn Welch <martyn.welch@collabora.com>
Subject: Re: [PATCH] iio:light:noa1305: Fix missing break statement.
Date: Tue, 13 Aug 2019 12:25:21 -0500	[thread overview]
Message-ID: <ee9c3b4f-9a20-5182-d15e-dc2603895d2c@embeddedor.com> (raw)
In-Reply-To: <20190813135802.GB27392@kroah.com>



On 8/13/19 8:58 AM, Greg KH wrote:
> On Tue, Aug 13, 2019 at 09:38:51PM +0800, Jonathan Cameron wrote:
>> This got caught by the implicit fall through detection but is
>> a bug rather than missing marking.
>>
>> Reported-by: 0-DAY kernel test infrastructure
>> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
>> Fixes: 741172d18e8a ("iio: light: noa1305: Add support for NOA1305")
>> ---
>>  drivers/iio/light/noa1305.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/iio/light/noa1305.c b/drivers/iio/light/noa1305.c
>> index 7b859ae1044d..5ebfbc52f541 100644
>> --- a/drivers/iio/light/noa1305.c
>> +++ b/drivers/iio/light/noa1305.c
>> @@ -85,6 +85,7 @@ static int noa1305_scale(struct noa1305_priv *priv, int *val, int *val2)
>>  	case NOA1305_INTEGR_TIME_400MS:
>>  		*val = 100;
>>  		*val2 = 77 * 4;
>> +		break;
>>  	case NOA1305_INTEGR_TIME_200MS:
>>  		*val = 100;
>>  		*val2 = 77 * 2;
>> -- 
>> 2.20.1
>>
> 
> Gustavo, your work caught a bug _before_ it hit Linus's tree this time :)
> 

This is so great! I think I can now officially say: mission accomplished.

Thanks for sharing this with me. It made my day. :)

--
Gustavo

      reply	other threads:[~2019-08-13 17:51 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-13 13:38 [PATCH] iio:light:noa1305: Fix missing break statement Jonathan Cameron
2019-08-13 13:58 ` Greg KH
2019-08-13 17:25   ` Gustavo A. R. Silva [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ee9c3b4f-9a20-5182-d15e-dc2603895d2c@embeddedor.com \
    --to=gustavo@embeddedor.com \
    --cc=Jonathan.Cameron@huawei.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=martyn.welch@collabora.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).