Linux-IIO Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] iio:light:noa1305: Fix missing break statement.
@ 2019-08-13 13:38 Jonathan Cameron
  2019-08-13 13:58 ` Greg KH
  0 siblings, 1 reply; 3+ messages in thread
From: Jonathan Cameron @ 2019-08-13 13:38 UTC (permalink / raw)
  To: jonathan.cameron, linux-iio, gregkh; +Cc: Martyn Welch, Jonathan Cameron

This got caught by the implicit fall through detection but is
a bug rather than missing marking.

Reported-by: 0-DAY kernel test infrastructure
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Fixes: 741172d18e8a ("iio: light: noa1305: Add support for NOA1305")
---
 drivers/iio/light/noa1305.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/iio/light/noa1305.c b/drivers/iio/light/noa1305.c
index 7b859ae1044d..5ebfbc52f541 100644
--- a/drivers/iio/light/noa1305.c
+++ b/drivers/iio/light/noa1305.c
@@ -85,6 +85,7 @@ static int noa1305_scale(struct noa1305_priv *priv, int *val, int *val2)
 	case NOA1305_INTEGR_TIME_400MS:
 		*val = 100;
 		*val2 = 77 * 4;
+		break;
 	case NOA1305_INTEGR_TIME_200MS:
 		*val = 100;
 		*val2 = 77 * 2;
-- 
2.20.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] iio:light:noa1305: Fix missing break statement.
  2019-08-13 13:38 [PATCH] iio:light:noa1305: Fix missing break statement Jonathan Cameron
@ 2019-08-13 13:58 ` Greg KH
  2019-08-13 17:25   ` Gustavo A. R. Silva
  0 siblings, 1 reply; 3+ messages in thread
From: Greg KH @ 2019-08-13 13:58 UTC (permalink / raw)
  To: Gustavo A. R. Silva, Jonathan Cameron; +Cc: linux-iio, Martyn Welch

On Tue, Aug 13, 2019 at 09:38:51PM +0800, Jonathan Cameron wrote:
> This got caught by the implicit fall through detection but is
> a bug rather than missing marking.
> 
> Reported-by: 0-DAY kernel test infrastructure
> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> Fixes: 741172d18e8a ("iio: light: noa1305: Add support for NOA1305")
> ---
>  drivers/iio/light/noa1305.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/iio/light/noa1305.c b/drivers/iio/light/noa1305.c
> index 7b859ae1044d..5ebfbc52f541 100644
> --- a/drivers/iio/light/noa1305.c
> +++ b/drivers/iio/light/noa1305.c
> @@ -85,6 +85,7 @@ static int noa1305_scale(struct noa1305_priv *priv, int *val, int *val2)
>  	case NOA1305_INTEGR_TIME_400MS:
>  		*val = 100;
>  		*val2 = 77 * 4;
> +		break;
>  	case NOA1305_INTEGR_TIME_200MS:
>  		*val = 100;
>  		*val2 = 77 * 2;
> -- 
> 2.20.1
> 

Gustavo, your work caught a bug _before_ it hit Linus's tree this time :)

I'll go queue this up now, thanks for the fast response Jonathan.

greg k-h

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] iio:light:noa1305: Fix missing break statement.
  2019-08-13 13:58 ` Greg KH
@ 2019-08-13 17:25   ` Gustavo A. R. Silva
  0 siblings, 0 replies; 3+ messages in thread
From: Gustavo A. R. Silva @ 2019-08-13 17:25 UTC (permalink / raw)
  To: Greg KH, Jonathan Cameron; +Cc: linux-iio, Martyn Welch



On 8/13/19 8:58 AM, Greg KH wrote:
> On Tue, Aug 13, 2019 at 09:38:51PM +0800, Jonathan Cameron wrote:
>> This got caught by the implicit fall through detection but is
>> a bug rather than missing marking.
>>
>> Reported-by: 0-DAY kernel test infrastructure
>> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
>> Fixes: 741172d18e8a ("iio: light: noa1305: Add support for NOA1305")
>> ---
>>  drivers/iio/light/noa1305.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/iio/light/noa1305.c b/drivers/iio/light/noa1305.c
>> index 7b859ae1044d..5ebfbc52f541 100644
>> --- a/drivers/iio/light/noa1305.c
>> +++ b/drivers/iio/light/noa1305.c
>> @@ -85,6 +85,7 @@ static int noa1305_scale(struct noa1305_priv *priv, int *val, int *val2)
>>  	case NOA1305_INTEGR_TIME_400MS:
>>  		*val = 100;
>>  		*val2 = 77 * 4;
>> +		break;
>>  	case NOA1305_INTEGR_TIME_200MS:
>>  		*val = 100;
>>  		*val2 = 77 * 2;
>> -- 
>> 2.20.1
>>
> 
> Gustavo, your work caught a bug _before_ it hit Linus's tree this time :)
> 

This is so great! I think I can now officially say: mission accomplished.

Thanks for sharing this with me. It made my day. :)

--
Gustavo

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-13 13:38 [PATCH] iio:light:noa1305: Fix missing break statement Jonathan Cameron
2019-08-13 13:58 ` Greg KH
2019-08-13 17:25   ` Gustavo A. R. Silva

Linux-IIO Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-iio/0 linux-iio/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-iio linux-iio/ https://lore.kernel.org/linux-iio \
		linux-iio@vger.kernel.org linux-iio@archiver.kernel.org
	public-inbox-index linux-iio


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-iio


AGPL code for this site: git clone https://public-inbox.org/ public-inbox