From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7AF0C433E4 for ; Fri, 14 Aug 2020 16:30:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8BC1920855 for ; Fri, 14 Aug 2020 16:30:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728376AbgHNQa2 (ORCPT ); Fri, 14 Aug 2020 12:30:28 -0400 Received: from hostingweb31-40.netsons.net ([89.40.174.40]:58597 "EHLO hostingweb31-40.netsons.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728099AbgHNQa1 (ORCPT ); Fri, 14 Aug 2020 12:30:27 -0400 Received: from [37.160.38.175] (port=40734 helo=[192.168.42.162]) by hostingweb31.netsons.net with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93) (envelope-from ) id 1k6cay-0001mB-F9; Fri, 14 Aug 2020 18:30:20 +0200 Subject: Re: [PATCH] dt-bindings: Whitespace clean-ups in schema files To: Rob Herring Cc: devicetree@vger.kernel.org, "linux-kernel@vger.kernel.org" , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , linux-clk , dri-devel , linux-spi , "open list:GPIO SUBSYSTEM" , "open list:REMOTE PROCESSOR (REMOTEPROC) SUBSYSTEM" , Linux HWMON List , Linux I2C , Linux Fbdev development list , "open list:IIO SUBSYSTEM AND DRIVERS" , Linux Input , "open list:THERMAL" , Linux Media Mailing List , Linux-ALSA , linux-mmc , MTD Maling List , netdev , "open list:REAL TIME CLOCK (RTC) SUBSYSTEM" , "open list:SERIAL DRIVERS" , Linux USB List References: <20200812203618.2656699-1-robh@kernel.org> From: Luca Ceresoli Message-ID: Date: Fri, 14 Aug 2020 18:30:17 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - hostingweb31.netsons.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - lucaceresoli.net X-Get-Message-Sender-Via: hostingweb31.netsons.net: authenticated_id: luca@lucaceresoli.net X-Authenticated-Sender: hostingweb31.netsons.net: luca@lucaceresoli.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org Hi, On 14/08/20 16:51, Rob Herring wrote: > On Thu, Aug 13, 2020 at 4:31 AM Luca Ceresoli wrote: >> >> Hi Rob, >> >> On 12/08/20 22:36, Rob Herring wrote: >>> Clean-up incorrect indentation, extra spaces, long lines, and missing >>> EOF newline in schema files. Most of the clean-ups are for list >>> indentation which should always be 2 spaces more than the preceding >>> keyword. >>> >>> Found with yamllint (which I plan to integrate into the checks). >> >> [...] >> >>> diff --git a/Documentation/devicetree/bindings/clock/idt,versaclock5.yaml b/Documentation/devicetree/bindings/clock/idt,versaclock5.yaml >>> index 3d4e1685cc55..28c6461b9a9a 100644 >>> --- a/Documentation/devicetree/bindings/clock/idt,versaclock5.yaml >>> +++ b/Documentation/devicetree/bindings/clock/idt,versaclock5.yaml >>> @@ -95,10 +95,10 @@ allOf: >>> # Devices without builtin crystal >>> properties: >>> clock-names: >>> - minItems: 1 >>> - maxItems: 2 >>> - items: >>> - enum: [ xin, clkin ] >>> + minItems: 1 >>> + maxItems: 2 >>> + items: >>> + enum: [ xin, clkin ] >>> clocks: >>> minItems: 1 >>> maxItems: 2 >> >> Thanks for noticing, LGTM. >> >> [...] >> >>> diff --git a/Documentation/devicetree/bindings/input/touchscreen/touchscreen.yaml b/Documentation/devicetree/bindings/input/touchscreen/touchscreen.yaml >>> index d7dac16a3960..36dc7b56a453 100644 >>> --- a/Documentation/devicetree/bindings/input/touchscreen/touchscreen.yaml >>> +++ b/Documentation/devicetree/bindings/input/touchscreen/touchscreen.yaml >>> @@ -33,8 +33,8 @@ properties: >>> $ref: /schemas/types.yaml#/definitions/uint32 >>> >>> touchscreen-min-pressure: >>> - description: minimum pressure on the touchscreen to be achieved in order for the >>> - touchscreen driver to report a touch event. >>> + description: minimum pressure on the touchscreen to be achieved in order >>> + for the touchscreen driver to report a touch event. >> >> Out of personal taste, I find the original layout more pleasant and >> readable. This third option is also good, especially for long descriptions: >> >> description: >> minimum pressure on the touchscreen to be achieved in order for the >> touchscreen driver to report a touch event. >> >> At first glance yamllint seems to support exactly these two by default: >> >>> With indentation: {spaces: 4, check-multi-line-strings: true} > > Turning on check-multi-line-strings results in 10K+ warnings, so no. > > The other issue is the style ruamel.yaml wants to write out is as the > patch does above. This matters when doing some scripted > transformations where we read in the files and write them back out. I > can somewhat work around that by first doing a pass with no changes > and then another pass with the actual changes, but that's completely > scriptable. Hopefully, ruamel learns to preserve the style better. Kind of sad, but I understand the reason as far as my understanding of the yaml world allows. Thanks for the explanation. [For idt,versaclock5.yaml, plus an overview of whole patch] Reviewed-by: Luca Ceresoli -- Luca