Linux-IIO Archive on lore.kernel.org
 help / color / Atom feed
From: "Ardelean, Alexandru" <alexandru.Ardelean@analog.com>
To: "robh+dt@kernel.org" <robh+dt@kernel.org>
Cc: "linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH] dt-bindings: iio: accel: adxl345: switch to YAML bindings
Date: Thu, 16 May 2019 13:34:10 +0000
Message-ID: <f2c3728e370bab8998d11ecabd4366e4776ea671.camel@analog.com> (raw)
In-Reply-To: <CAL_JsqJLEuCJWnD1G5iXdCNcJ+a_0zhoUH2a=4i6VBm8_B9r6w@mail.gmail.com>

On Thu, 2019-05-16 at 08:29 -0500, Rob Herring wrote:
> [External]
> 
> 
> On Thu, May 16, 2019 at 7:15 AM Alexandru Ardelean
> <alexandru.ardelean@analog.com> wrote:
> > 
> > The ADX345 supports both I2C & SPI bindings.
> > This change switches from old text bindings, to YAML bindings, and also
> > tries to make use of the recent multiple-examples support.
> > 
> > Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
> > ---
> >  .../bindings/iio/accel/adi,adxl345.yaml       | 74 +++++++++++++++++++
> >  .../devicetree/bindings/iio/accel/adxl345.txt | 39 ----------
> >  2 files changed, 74 insertions(+), 39 deletions(-)
> >  create mode 100644
> > Documentation/devicetree/bindings/iio/accel/adi,adxl345.yaml
> >  delete mode 100644
> > Documentation/devicetree/bindings/iio/accel/adxl345.txt
> > 
> > diff --git
> > a/Documentation/devicetree/bindings/iio/accel/adi,adxl345.yaml
> > b/Documentation/devicetree/bindings/iio/accel/adi,adxl345.yaml
> > new file mode 100644
> > index 000000000000..47cdfb3b8182
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/iio/accel/adi,adxl345.yaml
> > @@ -0,0 +1,74 @@
> > +# SPDX-License-Identifier: GPL-2.0
> > +%YAML 1.2
> > +---
> > +$id: 
> > http://devicetree.org/schemas/iio/accelerometers/adi,adxl345.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Analog Devices ADXL345/ADXL375 3-Axis Digital Accelerometers
> > +
> > +maintainers:
> > +  - Michael Hennerich <michael.hennerich@analog.com>
> > +
> > +description: |
> > +  Analog Devices ADXL345/ADXL375 3-Axis Digital Accelerometers that
> > supports
> > +  both I2C & SPI interfaces.
> > +    http://www.analog.com/en/products/mems/accelerometers/adxl345.html
> > +    
> > http://www.analog.com/en/products/sensors-mems/accelerometers/adxl375.html
> > +
> > +properties:
> > +  compatible:
> > +    enum:
> > +      - adi,adxl345
> > +      - adi,adxl375
> > +
> > +  reg:
> > +    maxItems: 1
> > +
> > +  spi-cpha: true
> > +
> > +  spi-cpol: true
> > +
> > +  interrupt-parent: true
> 
> You don't need to document interrupt-parent. It is implied. With that
> dropped,

I'll send a V2 dropping it.

Thanks
Alex

> 
> Reviewed-by: Rob Herring <robh@kernel.org>
> 
> > +
> > +  interrupts:
> > +    maxItems: 1
> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +  - interrupts
> > +
> > +examples:
> > +  - |
> > +    #include <dt-bindings/gpio/gpio.h>
> > +    #include <dt-bindings/interrupt-controller/irq.h>
> > +    i2c0 {
> > +        #address-cells = <1>;
> > +        #size-cells = <0>;
> > +
> > +        /* Example for a I2C device node */
> > +        accelerometer@2a {
> > +            compatible = "adi,adxl345";
> > +            reg = <0x53>;
> > +            interrupt-parent = <&gpio0>;
> > +            interrupts = <0 IRQ_TYPE_LEVEL_HIGH>;
> > +        };
> > +    };
> > +  - |
> > +    #include <dt-bindings/gpio/gpio.h>
> > +    #include <dt-bindings/interrupt-controller/irq.h>
> > +    spi0 {
> > +        #address-cells = <1>;
> > +        #size-cells = <0>;
> > +
> > +        /* Example for a SPI device node */
> > +        accelerometer@0 {
> > +            compatible = "adi,adxl345";
> > +            reg = <0>;
> > +            spi-max-frequency = <5000000>;
> > +            spi-cpol;
> > +            spi-cpha;
> > +            interrupt-parent = <&gpio0>;
> > +            interrupts = <0 IRQ_TYPE_LEVEL_HIGH>;
> > +        };
> > +    };
> > diff --git a/Documentation/devicetree/bindings/iio/accel/adxl345.txt
> > b/Documentation/devicetree/bindings/iio/accel/adxl345.txt
> > deleted file mode 100644
> > index f9525f6e3d43..000000000000
> > --- a/Documentation/devicetree/bindings/iio/accel/adxl345.txt
> > +++ /dev/null
> > @@ -1,39 +0,0 @@
> > -Analog Devices ADXL345/ADXL375 3-Axis Digital Accelerometers
> > -
> > -http://www.analog.com/en/products/mems/accelerometers/adxl345.html
> > -
> > http://www.analog.com/en/products/sensors-mems/accelerometers/adxl375.html
> > -
> > -Required properties:
> > - - compatible : should be one of
> > -               "adi,adxl345"
> > -               "adi,adxl375"
> > - - reg : the I2C address or SPI chip select number of the sensor
> > -
> > -Required properties for SPI bus usage:
> > - - spi-max-frequency : set maximum clock frequency, must be 5000000
> > - - spi-cpol and spi-cpha : must be defined for adxl345 to enable SPI
> > mode 3
> > -
> > -Optional properties:
> > - - interrupts: interrupt mapping for IRQ as documented in
> > -   Documentation/devicetree/bindings/interrupt-
> > controller/interrupts.txt
> > -
> > -Example for a I2C device node:
> > -
> > -       accelerometer@2a {
> > -               compatible = "adi,adxl345";
> > -               reg = <0x53>;
> > -               interrupt-parent = <&gpio1>;
> > -               interrupts = <0 IRQ_TYPE_LEVEL_HIGH>;
> > -       };
> > -
> > -Example for a SPI device node:
> > -
> > -       accelerometer@0 {
> > -               compatible = "adi,adxl345";
> > -               reg = <0>;
> > -               spi-max-frequency = <5000000>;
> > -               spi-cpol;
> > -               spi-cpha;
> > -               interrupt-parent = <&gpio1>;
> > -               interrupts = <0 IRQ_TYPE_LEVEL_HIGH>;
> > -       };
> > --
> > 2.17.1
> > 

  reply index

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-16 12:15 Alexandru Ardelean
2019-05-16 13:29 ` Rob Herring
2019-05-16 13:34   ` Ardelean, Alexandru [this message]
2019-05-16 13:36 ` [PATCH V2] " Alexandru Ardelean
2019-05-16 13:53   ` Rob Herring
2019-05-17 15:44   ` [PATCH][V3] " Alexandru Ardelean
2019-05-18 10:27     ` Jonathan Cameron

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f2c3728e370bab8998d11ecabd4366e4776ea671.camel@analog.com \
    --to=alexandru.ardelean@analog.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-IIO Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-iio/0 linux-iio/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-iio linux-iio/ https://lore.kernel.org/linux-iio \
		linux-iio@vger.kernel.org linux-iio@archiver.kernel.org
	public-inbox-index linux-iio


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-iio


AGPL code for this site: git clone https://public-inbox.org/ public-inbox