From: Nishant Malpani <nish.malpani25@gmail.com>
To: "Jonathan Cameron" <jic23@kernel.org>, "Guido Günther" <agx@sigxcpu.org>
Cc: Tomas Novotny <tomas@novotny.cz>,
Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
"Angus Ainslie (Purism)" <angus@akkea.ca>,
Marco Felsch <m.felsch@pengutronix.de>,
Thomas Gleixner <tglx@linutronix.de>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, Rob Herring <robh+dt@kernel.org>
Subject: Re: [PATCH v2 1/4] dt-bindings: iio: vcnl4000: convert bindings to YAML format
Date: Sun, 22 Mar 2020 23:07:00 +0530 [thread overview]
Message-ID: <f5ea512c-d427-94c7-cf5f-f1300cbd4aa3@gmail.com> (raw)
In-Reply-To: <20200322172910.51456fe4@archlinux>
On 22/03/20 10:59 pm, Jonathan Cameron wrote:
> On Mon, 16 Mar 2020 18:46:17 +0100
> Guido Günther <agx@sigxcpu.org> wrote:
>
>> Convert the vcnl4000 device tree bindings to the new YAML format.
>>
>> Signed-off-by: Guido Günther <agx@sigxcpu.org>
> Looks good to me. However, I've made far too many mistakes in
> DT binding review recently, so will definitely be waiting for Rob to
> get a chance to look at it!
>
> Jonathan
>
>> ---
>> .../bindings/iio/light/vcnl4000.txt | 24 ----------
>> .../bindings/iio/light/vcnl4000.yaml | 45 +++++++++++++++++++
>> 2 files changed, 45 insertions(+), 24 deletions(-)
>> delete mode 100644 Documentation/devicetree/bindings/iio/light/vcnl4000.txt
>> create mode 100644 Documentation/devicetree/bindings/iio/light/vcnl4000.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/iio/light/vcnl4000.txt b/Documentation/devicetree/bindings/iio/light/vcnl4000.txt
>> deleted file mode 100644
>> index 955af4555c90..000000000000
>> --- a/Documentation/devicetree/bindings/iio/light/vcnl4000.txt
>> +++ /dev/null
>> @@ -1,24 +0,0 @@
>> -VISHAY VCNL4000 - Ambient Light and proximity sensor
>> -
>> -This driver supports the VCNL4000/10/20/40 and VCNL4200 chips
>> -
>> -Required properties:
>> -
>> - -compatible: must be one of :
>> - vishay,vcnl4000
>> - vishay,vcnl4010
>> - vishay,vcnl4020
>> - vishay,vcnl4040
>> - vishay,vcnl4200
>> -
>> - -reg: I2C address of the sensor, should be one from below based on the model:
>> - 0x13
>> - 0x51
>> - 0x60
>> -
>> -Example:
>> -
>> -light-sensor@51 {
>> - compatible = "vishay,vcnl4200";
>> - reg = <0x51>;
>> -};
>> diff --git a/Documentation/devicetree/bindings/iio/light/vcnl4000.yaml b/Documentation/devicetree/bindings/iio/light/vcnl4000.yaml
>> new file mode 100644
>> index 000000000000..74d53cfbeb85
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/iio/light/vcnl4000.yaml
>> @@ -0,0 +1,45 @@
>> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/iio/light/vcnl4000.yaml#
Shouldn't the devicetree binding document be named with the manufacturer
part as well?
With regards,
Nishant
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: VISHAY VCNL4000 ambient light and proximity sensor
>> +
>> +maintainers:
>> + - Peter Meerwald <pmeerw@pmeerw.net>
>> +
>> +description: |
>> + Ambient light sensing with proximity detection over an i2c
>> + interface.
>> +
>> +properties:
>> + compatible:
>> + enum:
>> + - vishay,vcnl4000
>> + - vishay,vcnl4010
>> + - vishay,vcnl4020
>> + - vishay,vcnl4040
>> + - vishay,vcnl4200
>> +
>> + reg:
>> + maxItems: 1
>> +
>> +required:
>> + - compatible
>> + - reg
>> +
>> +additionalProperties: false
>> +
>> +examples:
>> +- |
>> + i2c {
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> +
>> + light-sensor@51 {
>> + compatible = "vishay,vcnl4200";
>> + reg = <0x51>;
>> + };
>> + };
>> +...
>
next prev parent reply other threads:[~2020-03-22 17:37 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-16 17:46 [PATCH v2 0/4] iio: vcnl4000: Export near level property for proximity sensor Guido Günther
2020-03-16 17:46 ` [PATCH v2 1/4] dt-bindings: iio: vcnl4000: convert bindings to YAML format Guido Günther
2020-03-22 17:29 ` Jonathan Cameron
2020-03-22 17:37 ` Nishant Malpani [this message]
2020-03-22 18:24 ` Jonathan Cameron
2020-03-16 17:46 ` [PATCH v2 2/4] dt-bindings: iio: light: vcnl4000: Add near-level Guido Günther
2020-03-16 17:46 ` [PATCH v2 3/4] iio: vcnl4000: Export near level property for proximity sensor Guido Günther
2020-03-16 18:23 ` Lars-Peter Clausen
2020-03-17 12:05 ` Guido Günther
2020-03-17 13:11 ` Lars-Peter Clausen
2020-03-22 0:21 ` Andy Shevchenko
2020-03-16 17:46 ` [PATCH v2 4/4] Documentation: ABI: document IIO in_proximity_near_level file Guido Günther
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f5ea512c-d427-94c7-cf5f-f1300cbd4aa3@gmail.com \
--to=nish.malpani25@gmail.com \
--cc=agx@sigxcpu.org \
--cc=angus@akkea.ca \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.felsch@pengutronix.de \
--cc=pmeerw@pmeerw.net \
--cc=robh+dt@kernel.org \
--cc=tglx@linutronix.de \
--cc=tomas@novotny.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).