From: Vignesh R <vigneshr@ti.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Lee Jones <lee.jones@linaro.org>,
"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>
Subject: Re: [PATCH 4/5] iio: adc: ti_am335x_adc: Disable ADC during suspend unconditionally
Date: Wed, 4 Jul 2018 20:10:46 +0530 [thread overview]
Message-ID: <f639cd3f-ff67-c748-8768-cff05eb11305@ti.com> (raw)
In-Reply-To: <20180630161848.1e72deea@archlinux>
On Saturday 30 June 2018 08:48 PM, Jonathan Cameron wrote:
> On Sat, 30 Jun 2018 16:03:17 +0530
> Vignesh R <vigneshr@ti.com> wrote:
>
>> Parent MFD device takes care of enabling ADC interface whenever
>> touchscreen is marked wakeup capable. Therefore, unconditionally disable
>> ADC interface during system suspend to save power in case of system with
>> just ADC and no TSC.
>>
>> Signed-off-by: Vignesh R <vigneshr@ti.com>
>
> This sounds like a sensible change to me. Is it applicable without the
> rest of the series? If so I'll take it through IIO. If the answer
> is that it needs to go with the rest then
>
This patch as such does not have any compile time dependencies on other
patches, but I would like Dmitry's opinion on the series before being
merged.
> Acked-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
>
Thanks!
Regards
Vignesh
> Thanks,
>
> Jonathan
>> ---
>> drivers/iio/adc/ti_am335x_adc.c | 12 ++++--------
>> 1 file changed, 4 insertions(+), 8 deletions(-)
>>
>> diff --git a/drivers/iio/adc/ti_am335x_adc.c b/drivers/iio/adc/ti_am335x_adc.c
>> index 80df5a377d30..cafb1dcadc48 100644
>> --- a/drivers/iio/adc/ti_am335x_adc.c
>> +++ b/drivers/iio/adc/ti_am335x_adc.c
>> @@ -693,16 +693,12 @@ static int __maybe_unused tiadc_suspend(struct device *dev)
>> {
>> struct iio_dev *indio_dev = dev_get_drvdata(dev);
>> struct tiadc_device *adc_dev = iio_priv(indio_dev);
>> - struct ti_tscadc_dev *tscadc_dev;
>> unsigned int idle;
>>
>> - tscadc_dev = ti_tscadc_dev_get(to_platform_device(dev));
>> - if (!device_may_wakeup(tscadc_dev->dev)) {
>> - idle = tiadc_readl(adc_dev, REG_CTRL);
>> - idle &= ~(CNTRLREG_TSCSSENB);
>> - tiadc_writel(adc_dev, REG_CTRL, (idle |
>> - CNTRLREG_POWERDOWN));
>> - }
>> + idle = tiadc_readl(adc_dev, REG_CTRL);
>> + idle &= ~(CNTRLREG_TSCSSENB);
>> + tiadc_writel(adc_dev, REG_CTRL, (idle |
>> + CNTRLREG_POWERDOWN));
>>
>> return 0;
>> }
>
--
Regards
Vignesh
next prev parent reply other threads:[~2018-07-04 14:40 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-30 10:33 [PATCH 0/5] ti_am335x_tsc: Enable wakeup capability Vignesh R
2018-06-30 10:33 ` [PATCH 1/5] mfd: ti_am335x_tscadc: Don't mark TSCADC MFD as wakeup capable Vignesh R
2018-07-04 7:38 ` Lee Jones
2018-10-09 10:29 ` Lee Jones
2018-06-30 10:33 ` [PATCH 2/5] Input: ti_am335x_tsc: Mark TSC device as wakeup source Vignesh R
2018-07-18 17:06 ` Dmitry Torokhov
2018-10-09 10:29 ` Lee Jones
2018-06-30 10:33 ` [PATCH 3/5] mfd: ti_am335x_tscadc: Keep ADC interface on if child is wakeup capable Vignesh R
2018-07-04 7:39 ` Lee Jones
2018-10-09 10:30 ` Lee Jones
2018-06-30 10:33 ` [PATCH 4/5] iio: adc: ti_am335x_adc: Disable ADC during suspend unconditionally Vignesh R
2018-06-30 15:18 ` Jonathan Cameron
2018-07-04 14:40 ` Vignesh R [this message]
2018-10-09 10:30 ` Lee Jones
2018-06-30 10:33 ` [PATCH 5/5] Input: ti_am335x_tsc: Mark IRQ as wakeup capable Vignesh R
2018-07-18 17:06 ` Dmitry Torokhov
2018-10-09 10:30 ` Lee Jones
2018-07-17 11:45 ` [PATCH 0/5] ti_am335x_tsc: Enable wakeup capability Vignesh R
2018-07-18 7:47 ` Lee Jones
2018-07-18 17:09 ` Dmitry Torokhov
2018-07-21 18:09 ` Jonathan Cameron
2018-07-23 5:37 ` Lee Jones
2018-07-24 17:33 ` Vignesh R
2018-07-25 5:26 ` Lee Jones
2018-09-28 6:12 ` Vignesh R
2018-10-05 5:11 ` Vignesh R
2018-10-09 10:33 ` [GIT PULL] Immutable branch between MFD, IIO and Input due for the v4.20 merge window Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f639cd3f-ff67-c748-8768-cff05eb11305@ti.com \
--to=vigneshr@ti.com \
--cc=dmitry.torokhov@gmail.com \
--cc=jic23@kernel.org \
--cc=lee.jones@linaro.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).