From: "Ardelean, Alexandru" <alexandru.Ardelean@analog.com>
To: "jic23@kernel.org" <jic23@kernel.org>,
"zhongjiang@huawei.com" <zhongjiang@huawei.com>
Cc: "Popa, Stefan Serban" <StefanSerban.Popa@analog.com>,
"Hennerich, Michael" <Michael.Hennerich@analog.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>
Subject: Re: [PATCH 1/2] iio: imu: adis16460: use DEFINE_DEBUGFS_ATTRIBUTE to define debugfs fops
Date: Wed, 30 Oct 2019 09:13:33 +0000 [thread overview]
Message-ID: <fb8722ad2c1ef51944dc814a7b24433f4348721e.camel@analog.com> (raw)
In-Reply-To: <1572423581-59762-2-git-send-email-zhongjiang@huawei.com>
On Wed, 2019-10-30 at 16:19 +0800, zhong jiang wrote:
> [External]
>
> It is more clear to use DEFINE_DEBUGFS_ATTRIBUTE to define debugfs file
> operation rather than DEFINE_SIMPLE_ATTRIBUTE.
Not sure if "more clear" is the word.
But it is more correct to use DEFINE_DEBUGFS_ATTRIBUTE(), since they are
debugfs attrs.
In any case, this is no big deal.
So:
Reviewed-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
>
> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
> ---
> drivers/iio/imu/adis16460.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/iio/imu/adis16460.c b/drivers/iio/imu/adis16460.c
> index 6aed9e8..2e7a582 100644
> --- a/drivers/iio/imu/adis16460.c
> +++ b/drivers/iio/imu/adis16460.c
> @@ -87,7 +87,7 @@ static int adis16460_show_serial_number(void *arg, u64
> *val)
>
> return 0;
> }
> -DEFINE_SIMPLE_ATTRIBUTE(adis16460_serial_number_fops,
> +DEFINE_DEBUGFS_ATTRIBUTE(adis16460_serial_number_fops,
> adis16460_show_serial_number, NULL, "0x%.4llx\n");
>
> static int adis16460_show_product_id(void *arg, u64 *val)
> @@ -105,7 +105,7 @@ static int adis16460_show_product_id(void *arg, u64
> *val)
>
> return 0;
> }
> -DEFINE_SIMPLE_ATTRIBUTE(adis16460_product_id_fops,
> +DEFINE_DEBUGFS_ATTRIBUTE(adis16460_product_id_fops,
> adis16460_show_product_id, NULL, "%llu\n");
>
> static int adis16460_show_flash_count(void *arg, u64 *val)
> @@ -123,7 +123,7 @@ static int adis16460_show_flash_count(void *arg, u64
> *val)
>
> return 0;
> }
> -DEFINE_SIMPLE_ATTRIBUTE(adis16460_flash_count_fops,
> +DEFINE_DEBUGFS_ATTRIBUTE(adis16460_flash_count_fops,
> adis16460_show_flash_count, NULL, "%lld\n");
>
> static int adis16460_debugfs_init(struct iio_dev *indio_dev)
next prev parent reply other threads:[~2019-10-30 9:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-30 8:19 [PATCH 0/2] iio: use DEFINE_DEBUGFS_ATTRIBUTE to define debugfs fops zhong jiang
2019-10-30 8:19 ` [PATCH 1/2] iio: imu: adis16460: " zhong jiang
2019-10-30 9:13 ` Ardelean, Alexandru [this message]
2019-10-30 9:33 ` zhong jiang
2019-11-03 11:25 ` Jonathan Cameron
2019-11-04 11:12 ` Ardelean, Alexandru
2019-10-30 8:19 ` [PATCH 2/2] iio: imu: adis16400: " zhong jiang
2019-10-30 9:13 ` Ardelean, Alexandru
2019-10-30 9:12 ` [PATCH 0/2] iio: " Ardelean, Alexandru
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fb8722ad2c1ef51944dc814a7b24433f4348721e.camel@analog.com \
--to=alexandru.ardelean@analog.com \
--cc=Michael.Hennerich@analog.com \
--cc=StefanSerban.Popa@analog.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=zhongjiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).