linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: Vincent Huang <vincent.huang@tw.synaptics.com>,
	linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Jiri Kosina <jikos@kernel.org>,
	Andrew Duggan <aduggan@synaptics.com>,
	Benjamin Tissoires <btissoir@redhat.com>,
	Lyude Paul <lyude@redhat.com>,
	Chris Heiny <chris.heiny@synaptics.com>
Subject: Re: [PATCH 0/3] Add support for F3A
Date: Sun, 27 Sep 2020 13:12:47 +0200	[thread overview]
Message-ID: <05140fb1-19a5-d740-2c57-e39e450142ec@redhat.com> (raw)
In-Reply-To: <20200924094628.1085000-1-vincent.huang@tw.synaptics.com>

Hi,

On 9/24/20 11:46 AM, Vincent Huang wrote:
> RMI4 F3A supports the touchpad GPIO function, it's designed to support
> more GPIOs and used on newer touchpads. The patches add support of
> touchpad buttons and rename f30_data to avoid confusion.

Thank you for the patch. So as already mentioned patches 1 and 2
need to be combined into a single patch.

Otherwise the patches look good to me and I can confirm that
they fix clickpad clicks not registering when using rmi4 for the touchpad
on the Lenovo T14 gen 1.

So for version 2 (with patches 1 and 2 combined into a single patch)
you may add my:

Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Tested-by: Hans de Goede <hdegoede@redhat.com>

Regards,

Hans

> 
> Vincent Huang (3):
>    Input: synaptics-rmi4 - rename f30_data to gpio_data
>    HID: rmi - rename f30_data to gpio_data
>    Input: synaptics-rmi4 - add support for F3A
> 
>   drivers/hid/hid-rmi.c           |   2 +-
>   drivers/input/mouse/synaptics.c |   2 +-
>   drivers/input/rmi4/Kconfig      |   8 ++
>   drivers/input/rmi4/Makefile     |   1 +
>   drivers/input/rmi4/rmi_bus.c    |   3 +
>   drivers/input/rmi4/rmi_driver.h |   1 +
>   drivers/input/rmi4/rmi_f30.c    |  14 +-
>   drivers/input/rmi4/rmi_f3a.c    | 241 ++++++++++++++++++++++++++++++++
>   include/linux/rmi.h             |  11 +-
>   9 files changed, 269 insertions(+), 14 deletions(-)
>   create mode 100644 drivers/input/rmi4/rmi_f3a.c
> 


  parent reply	other threads:[~2020-09-27 11:12 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-24  9:46 [PATCH 0/3] Add support for F3A Vincent Huang
2020-09-24  9:46 ` [PATCH 1/3] Input: synaptics-rmi4 - rename f30_data to gpio_data Vincent Huang
2020-09-24  9:46 ` [PATCH 2/3] HID: rmi " Vincent Huang
2020-09-24 14:52   ` Jiri Kosina
2020-09-24  9:46 ` [PATCH 3/3] Input: synaptics-rmi4 - add support for F3A Vincent Huang
2020-09-27 11:12 ` Hans de Goede [this message]
2020-09-29 13:45   ` [PATCH 0/3] Add " Jiri Kosina

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=05140fb1-19a5-d740-2c57-e39e450142ec@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=aduggan@synaptics.com \
    --cc=btissoir@redhat.com \
    --cc=chris.heiny@synaptics.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=jikos@kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lyude@redhat.com \
    --cc=vincent.huang@tw.synaptics.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).