From: Lauri Jakku <lauri.jakku@pp.inet.fi>
To: Oliver Neukum <oneukum@suse.com>,
Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cc: Jiri Kosina <jikos@kernel.org>,
"open list:HID CORE LAYER" <linux-input@vger.kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Linux USB Mailing List <linux-usb@vger.kernel.org>
Subject: Re: USB HID fix: Retry sending timedout device commands 20 times
Date: Tue, 4 Feb 2020 11:27:28 +0200 [thread overview]
Message-ID: <11338553-09e7-5201-d829-4c52eb86f50e@pp.inet.fi> (raw)
In-Reply-To: <1580807154.11089.0.camel@suse.com>
On 4.2.2020 11.05, Oliver Neukum wrote:
> Am Dienstag, den 04.02.2020, 09:17 +0100 schrieb Benjamin Tissoires:
>> Ouch, very much ouch. Resending 20 times on a generic path when the
>> timeout can be several seconds is pretty much a bad thing. Again, this
>> should be limited to the device you are talking to, and not be
>> generic. Or maybe you are encountering a usb controller issue.
> Yes. You need a least to consider teh unplug case.
>
> Regards
> Oliver
The patch does not loop in normal case, only if there are timeouts, and
even then not more than 400ms .. 20ms sleep while retry.
--
Br,
Lauri J.
prev parent reply other threads:[~2020-02-04 9:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <9cf20b6f-5bfa-2346-ca9f-5ca81245bfff@pp.inet.fi>
2020-02-04 8:17 ` USB HID fix: Retry sending timedout device commands 20 times Benjamin Tissoires
2020-02-04 9:05 ` Oliver Neukum
2020-02-04 9:27 ` Lauri Jakku [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11338553-09e7-5201-d829-4c52eb86f50e@pp.inet.fi \
--to=lauri.jakku@pp.inet.fi \
--cc=benjamin.tissoires@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=oneukum@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).