From: Bastien Nocera <hadess@hadess.net>
To: Ping Cheng <pinglinux@gmail.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
linux-input <linux-input@vger.kernel.org>,
BlueZ development <linux-bluetooth@vger.kernel.org>,
bgunn@solekai.com
Subject: Re: [PATCHes] Implement Bluetooth Wacom tablet's mode change in the kernel
Date: Mon, 18 Jan 2010 21:35:56 +0000 [thread overview]
Message-ID: <1263850557.20565.3204.camel@localhost.localdomain> (raw)
In-Reply-To: <167e8a331001181144u54cefd15m65a5a63ca8c4c4b6@mail.gmail.com>
On Mon, 2010-01-18 at 11:44 -0800, Ping Cheng wrote:
> On Mon, Jan 18, 2010 at 8:49 AM, Bastien Nocera <hadess@hadess.net>
> wrote:
> Heya,
>
> Here's a patch to do the Bluetooth Wacom tablet's mode setting
> in the
> kernel. In the past, it was done in a patch in bluetootd.
>
> The first patch is probably completely wrong. Right now,
> hid_output_raw_report is done on the intr socket, instead of
> the ctrl
> socket. If it's correct to do it on the intr socket, we'd need
> to add
> some API as a way to select the ctrl socket instead for use in
> that
> driver.
>
> I can not make a comment on the above patch since I know nothing about
> Bluetooth.
I'll let Marcel and Jiri be the judges of the value of this patch. In
the worst case, it'll need a change of API for hid-core.
> I still have the exact same problems as with the user-space
> patch in
> that an error occurs sending the second blob of data to the
> tablet, the
> first time the driver is initialised. Ping, any ideas about
> that?
>
> I am not sure if your issue is similar to what we see with USB devices
> or not. In order to properly set the device to Wacom mode, we had to
> call usb_set_report more than once (up to 5 times for older kernels,
> and up to 3 times for newer kernels) to get it right. Please call:
>
> hdev->hid_output_raw_report again when ret is less than 0. Try up to
> three times to see what you get.
That's pretty straight forward, I'll try and do that.
> You need to check if (ret < 0) before calling dev_err() with the
> second hid_output_raw_report() call, right?
Copy/paste stupidness all around there (as you can see, it's indented
properly already ;)
Cheers
next prev parent reply other threads:[~2010-01-18 21:36 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-18 16:49 [PATCHes] Implement Bluetooth Wacom tablet's mode change in the kernel Bastien Nocera
[not found] ` <167e8a331001181144u54cefd15m65a5a63ca8c4c4b6@mail.gmail.com>
2010-01-18 21:35 ` Bastien Nocera [this message]
[not found] ` <1263850557.20565.3204.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2010-01-19 0:19 ` Bastien Nocera
[not found] ` <1263833399.20565.2905.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2010-01-18 22:01 ` Przemysław Firszt
2010-01-19 7:29 ` Marcel Holtmann
2010-01-19 10:30 ` Bastien Nocera
2010-01-19 14:20 ` Jiri Kosina
2010-01-19 16:36 ` Gunn, Brian
[not found] ` <FE57175CCE23E5419899C1B0CFA26FAD101B5F8B9D-qt6i7J1wJoTyaV9iOGU/das+acoFTUjB@public.gmane.org>
2010-01-19 17:03 ` Bastien Nocera
[not found] ` <1263920596.1816.56.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2010-01-19 17:05 ` Gunn, Brian
2010-01-19 20:47 ` Gunn, Brian
2010-01-21 1:08 ` Gunn, Brian
2010-01-21 1:35 ` Bastien Nocera
[not found] ` <1264037759.1735.5008.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2010-01-28 22:33 ` Gunn, Brian
[not found] ` <FE57175CCE23E5419899C1B0CFA26FAD12CDF72C0F-qt6i7J1wJoTyaV9iOGU/das+acoFTUjB@public.gmane.org>
2010-01-28 22:53 ` Bastien Nocera
2010-01-28 22:57 ` Gunn, Brian
2010-01-29 9:39 ` Jiri Kosina
2010-01-29 13:45 ` Bastien Nocera
2010-01-29 13:53 ` Jiri Kosina
2010-01-20 11:47 Bastien Nocera
[not found] ` <1263988051.1735.2474.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2010-01-20 11:52 ` Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1263850557.20565.3204.camel@localhost.localdomain \
--to=hadess@hadess.net \
--cc=bgunn@solekai.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=pinglinux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).