From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bastien Nocera Subject: Re: [PATCHes] Implement Bluetooth Wacom tablet's mode change in the kernel Date: Tue, 19 Jan 2010 10:30:15 +0000 Message-ID: <1263897015.20565.3988.camel@localhost.localdomain> References: <1263833399.20565.2905.camel@localhost.localdomain> <1263886149.5591.166.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Return-path: Received: from mx1.redhat.com ([209.132.183.28]:58912 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754123Ab0ASKal (ORCPT ); Tue, 19 Jan 2010 05:30:41 -0500 In-Reply-To: <1263886149.5591.166.camel@localhost.localdomain> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Marcel Holtmann Cc: Dmitry Torokhov , linux-input , BlueZ development , bgunn@solekai.com, Ping , Jiri Kosina On Mon, 2010-01-18 at 23:29 -0800, Marcel Holtmann wrote: > Hi Bastien, > > > Here's a patch to do the Bluetooth Wacom tablet's mode setting in the > > kernel. In the past, it was done in a patch in bluetootd. > > > > The first patch is probably completely wrong. Right now, > > hid_output_raw_report is done on the intr socket, instead of the ctrl > > socket. If it's correct to do it on the intr socket, we'd need to add > > some API as a way to select the ctrl socket instead for use in that > > driver. > > actually the interrupt should be incoming only. So moving the raw output > to the control channel seems fine to. Any reason why it is on the > interrupt channel in the first place? The patch was written by Jiri and tested by Brian. Not sure what sort of device Brian tested this with...