Re: [PATCH] Input: add appleir USB driver

[Bastien Nocera <hadess@hadess.net>]

On Wed, 2010-02-03 at 16:54 +0100, Jiri Kosina wrote:
> On Mon, 1 Feb 2010, Bastien Nocera wrote:
> 
> > > > +With 0x05ac being the vendor ID (Apple, you shouldn't need to change this)
> > > > +With 0x8242 being the product ID (check the output of lsusb for your hardware)
> > > > +And 0x08 being "HID_CONNECT_HIDDEV"
> > > 
> > > I am afraid this is not true, 0x08 is HID_QUIRK_NOGET.
> > > 
> > > We currently don't have dynamic quirk for forcing HIDDEV creation from the 
> > > module parameter.
> > 
> > Right. Any chance to change that?
> 
> This particular one might actually make enough sense to be added (although 
> I am really trying to avoid quirk additions completely), for backwards 
> compatibility reasons.

Should I remove the comments there altogether then? That kind of defeats
my "but you can use lirc with some tweaks" argument, even though I still
think that those people needing more keys would be in the minority...

> > > > +	if (!memcmp(data, keydown, sizeof(keydown))) {
> > > > +		/*If we already have a key down, take it up before marking */
> > > > +		/*this one down */
> > > > +		if (appleir->current_key)
> > > > +			key_up(appleir, appleir->current_key);
> > > > +		appleir->current_key = keymap[(data[4] >> 1) & MAX_KEYS_MASK];
> > > > +
> > > > +		key_down(appleir, appleir->current_key);
> > > > +		/*remote doesn't do key up, either pull them up, in the test */
> > > > +		/*above, or here set a timer which pulls them up after 1/8 s */
> > > 
> > > Could you please place spaces after the comment starters?
> > 
> > I've done that on my local copy. I'm now trying to get in touch with
> > Matthew Garrett so he can help me out with the suspend parts of the
> > patch. I'll resubmit when that's done.
> 
> OK, thanks.

Jarod gave me a hand, and the problem is the same as with the bcm5974
driver, the platform reset_resume will work just fine.

Updated patch coming up.

Cheers