From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bastien Nocera Subject: Re: [PATCH] Input: add appleir USB driver Date: Mon, 19 Apr 2010 11:14:40 +0100 Message-ID: <1271672080.17421.91.camel@localhost.localdomain> References: <1271434792.2045.5.camel@localhost.localdomain> <20100417081212.GA19866@core.coreip.homeip.net> <1271669507.17421.39.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Return-path: Received: from relay2-v.mail.gandi.net ([217.70.178.76]:47838 "EHLO relay2-v.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752433Ab0DSKOp (ORCPT ); Mon, 19 Apr 2010 06:14:45 -0400 In-Reply-To: Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Jiri Kosina Cc: Dmitry Torokhov , linux-input@vger.kernel.org On Mon, 2010-04-19 at 12:00 +0200, Jiri Kosina wrote: > On Mon, 19 Apr 2010, Bastien Nocera wrote: > > > > > A few comments... > > > > > > > > > Signed-off-by: Bastien Nocera > > > > > --- > > > > > Documentation/input/appleir.txt | 45 ++++ > > > > > drivers/hid/hid-apple.c | 4 - > > > > > drivers/hid/hid-core.c | 5 +- > > > > > drivers/hid/hid-ids.h | 1 + > > > > > > > > HID pieces need to go through Jiri or he needs to ack them to go through > > > > my tree... > > > > > > Please feel free to put > > > > > > Signed-off-by: Jiri Kosina > > > > > > on the blakclist changes in drivers/hid once you merge the > > > standalone appleir driver from Bastien. > > > > Any comments on the additional quirks necessary to get lirc working? > > Ouch, I thought that we have discussed previously that I am basically fine > with adding those two quirks, but I haven't seen any patch doing that > since then ... ? > > So I'd suggest you either remove that part from the appleir documentation > until this is implemented, or send me a patch adding those two flags. I sent it Friday with the subject: [PATCH] Add HID_QUIRK_HIDDEV_FORCE and HID_QUIRK_NO_IGNORE The patch was also sent to the input list: http://thread.gmane.org/gmane.linux.kernel.input/12176 Cheers