From: Joe Perches <joe@perches.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Rob Schroer <sulamiification@gmail.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers/hid/wacom: fixed coding style issues
Date: Tue, 21 Jan 2014 13:25:54 -0800 [thread overview]
Message-ID: <1390339554.31946.6.camel@joe-AO722> (raw)
In-Reply-To: <20140121211823.GD29615@core.coreip.homeip.net>
On Tue, 2014-01-21 at 13:18 -0800, Dmitry Torokhov wrote:
> On Tue, Jan 21, 2014 at 09:29:44PM +0100, Rob Schroer wrote:
> > As far as I can see, kstrtoXXX() might be an alternative, but I was just
> > fixing coding style issues, no need to break anything IMO.
>
> You could do the breaking in a follow up patch ;)
Yes please.
Include the breaking of multiple statements
into multiple lines too please like
from:
case USB_DEVICE_ID_WACOM_GRAPHIRE_BLUETOOTH:
rep_data[0] = 0x03; rep_data[1] = 0x00;
to:
case USB_DEVICE_ID_WACOM_GRAPHIRE_BLUETOOTH:
rep_data[0] = 0x03;
rep_data[1] = 0x00;
next prev parent reply other threads:[~2014-01-21 21:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-21 19:51 [PATCH] drivers/hid/wacom: fixed coding style issues Robin Schroer
2014-01-21 20:06 ` Dmitry Torokhov
2014-01-21 20:29 ` Rob Schroer
2014-01-21 21:18 ` Dmitry Torokhov
2014-01-21 21:25 ` Joe Perches [this message]
2014-01-21 22:42 ` Rob Schroer
2014-01-22 6:40 ` Dmitry Torokhov
2014-01-22 14:48 ` Rob Schroer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1390339554.31946.6.camel@joe-AO722 \
--to=joe@perches.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sulamiification@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).