From: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
To: Cai Huoqing <caihuoqing@baidu.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Input: ads7846 - Make use of the helper function dev_err_probe()
Date: Fri, 17 Sep 2021 10:08:39 +0200 [thread overview]
Message-ID: <157cce4f-6a8c-bf53-3790-ea43d5662f7f@canonical.com> (raw)
In-Reply-To: <20210917022910.GA17584@LAPTOP-UKSR4ENP.internal.baidu.com>
On 17/09/2021 04:29, Cai Huoqing wrote:
> On 16 9月 21 21:34:26, Krzysztof Kozlowski wrote:
>> On 16/09/2021 17:31, Cai Huoqing wrote:
>>> When possible use dev_err_probe help to properly deal with the
>>> PROBE_DEFER error, the benefit is that DEFER issue will be logged
>>> in the devices_deferred debugfs file.
>>> Using dev_err_probe() can reduce code size, and the error value
>>> gets printed.
>>>
>>> Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
>>> ---
>>> drivers/input/touchscreen/ads7846.c | 7 ++-----
>>> 1 file changed, 2 insertions(+), 5 deletions(-)
>>
>> You sent 32 independent patches. Do you expect us to copy-paste similar
>> feedback on each of them? This would not make any sense. Please organize
>> all your submissions in a series with:
>>
>> git format-patch -32
>> git send-email ..... 00*
> Ok, I'll try. but there are different owners for touchscreen/xxx,
> is it ok to send them the whole series?
I see the same maintainers:
Dmitry Torokhov + linux-input
HWMON also appears because of usage of hwmon API inside, which might
happen anyway for few other input drivers
Best regards,
Krzysztof
prev parent reply other threads:[~2021-09-17 8:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-16 15:31 [PATCH] Input: ads7846 - Make use of the helper function dev_err_probe() Cai Huoqing
2021-09-16 19:34 ` Krzysztof Kozlowski
2021-09-17 2:29 ` Cai Huoqing
2021-09-17 8:08 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=157cce4f-6a8c-bf53-3790-ea43d5662f7f@canonical.com \
--to=krzysztof.kozlowski@canonical.com \
--cc=caihuoqing@baidu.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).