From: Benjamin Tissoires <bentiss@kernel.org>
To: "Filipe Laíns" <lains@riseup.net>,
"Bastien Nocera" <hadess@hadess.net>,
"Jiri Kosina" <jikos@kernel.org>,
"Benjamin Tissoires" <benjamin.tissoires@redhat.com>,
"Hans de Goede" <hdegoede@redhat.com>
Cc: linux-input@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] HID: logitech-hidpp: Fix kernel crash on receiver USB disconnect
Date: Fri, 06 Oct 2023 16:12:07 +0200 [thread overview]
Message-ID: <169660152754.2015335.1504667640819590220.b4-ty@kernel.org> (raw)
In-Reply-To: <20231005182638.3776-1-hdegoede@redhat.com>
On Thu, 05 Oct 2023 20:26:38 +0200, Hans de Goede wrote:
> hidpp_connect_event() has *four* time-of-check vs time-of-use (TOCTOU)
> races when it races with itself.
>
> hidpp_connect_event() primarily runs from a workqueue but it also runs
> on probe() and if a "device-connected" packet is received by the hw
> when the thread running hidpp_connect_event() from probe() is waiting on
> the hw, then a second thread running hidpp_connect_event() will be
> started from the workqueue.
>
> [...]
Applied to hid/hid.git (for-6.6/upstream-fixes), thanks!
[1/1] HID: logitech-hidpp: Fix kernel crash on receiver USB disconnect
https://git.kernel.org/hid/hid/c/dac501397b9d
Cheers,
--
Benjamin Tissoires <bentiss@kernel.org>
prev parent reply other threads:[~2023-10-06 14:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-05 18:26 [PATCH] HID: logitech-hidpp: Fix kernel crash on receiver USB disconnect Hans de Goede
2023-10-06 7:29 ` Benjamin Tissoires
2023-10-06 7:59 ` Hans de Goede
2023-10-06 8:09 ` Benjamin Tissoires
2023-10-06 8:50 ` Hans de Goede
2023-10-06 14:15 ` Benjamin Tissoires
2023-10-06 14:12 ` Benjamin Tissoires [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=169660152754.2015335.1504667640819590220.b4-ty@kernel.org \
--to=bentiss@kernel.org \
--cc=benjamin.tissoires@redhat.com \
--cc=hadess@hadess.net \
--cc=hdegoede@redhat.com \
--cc=jikos@kernel.org \
--cc=lains@riseup.net \
--cc=linux-input@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).