From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE2B0C433DF for ; Fri, 26 Jun 2020 13:36:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AE068207D8 for ; Fri, 26 Jun 2020 13:36:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728591AbgFZNgK (ORCPT ); Fri, 26 Jun 2020 09:36:10 -0400 Received: from ms-10.1blu.de ([178.254.4.101]:42184 "EHLO ms-10.1blu.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728320AbgFZNgJ (ORCPT ); Fri, 26 Jun 2020 09:36:09 -0400 Received: from [78.43.71.214] (helo=marius.localnet) by ms-10.1blu.de with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jooWO-0002Ol-Vf; Fri, 26 Jun 2020 15:36:00 +0200 From: Marius Zachmann To: Guenter Roeck Cc: Jean Delvare , Jiri Kosina , Benjamin Tissoires , linux-hwmon@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org Subject: Re: [PATCH v7] hwmon: add Corsair Commander Pro driver Date: Fri, 26 Jun 2020 15:36:00 +0200 Message-ID: <1840543.YiJnzbJd1b@marius> In-Reply-To: <20200626132135.GA122231@roeck-us.net> References: <20200626132135.GA122231@roeck-us.net> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Con-Id: 241080 X-Con-U: 0-mail X-Originating-IP: 78.43.71.214 Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org On 26.06.20 at 15:21:35 CEST, Guenter Roeck wrote > On Fri, Jun 26, 2020 at 07:59:36AM +0200, Marius Zachmann wrote: > > This is v7 of a driver for the Corsair Commander Pro. > > Note to self: Reword when applying. > > > It provides sysfs attributes for: > > - Reading fan speed > > - Reading temp sensors > > - Reading voltage values > > - Writing pwm and reading last written pwm > > - Reading fan and temp connection status > > > > It is an usb driver, so it needs to be ignored by usbhid. > > The Corsair Commander Pro is a fan controller and provides > > no means for user interaction. > > The two device numbers are there, because there is a slightly > > different version of the same device. (Only difference > > seem to be in some presets.) > > > > This is based on the staging/hwmon tree. > > > > Signed-off-by: Marius Zachmann > > Looks good. For my reference: > > Reviewed-by: Guenter Roeck > > We'll have to wait for an ACK from a HID maintainer before I can apply it. > > Thanks, > Guenter > Thank you very much for your reviews and time! Marius